From patchwork Thu Aug 29 16:53:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 1882 Return-Path: Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [217.70.178.232]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 75E8D60BE5 for ; Thu, 29 Aug 2019 18:51:46 +0200 (CEST) Received: from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101]) (Authenticated sender: jacopo@jmondi.org) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 4D0B4200007; Thu, 29 Aug 2019 16:51:45 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi , kamesan@google.com, jcliang@google.com, shik@google.com, wtlee@google.com Date: Thu, 29 Aug 2019 18:53:07 +0200 Message-Id: <20190829165311.29196-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/4] android: Rework metadata tags X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Aug 2019 16:51:46 -0000 Hello, following a first simple patch "[PATCH] android: camera_device: Add pipeline max depth static metadata" a discussion with Ren-Pei and Ricky made clear the current metadata support was buggy, and since the ANDROID_REQUEST_AVAILABLE_CAPABILITIES tag was not reported, cros_camera_test failed to identify which static tags we were missing. Adding that tag opened a small pandora box, as the test reported -a lot- of tag where missing, and some of there were wrongly reported as part of the capture request template. This series tries to address this, by reporting all tags marked as "BC" and so required by LIMITED hardware level devices, cleaning up and improving the generated request template, and using more opportune sized for each metadata tag. cros_camera_test seems now more happy, both in regard to static metadata and the generated request template: # cros_camera_test --gtest_filter=Camera3ModuleFixture.* [==========] 9 tests from 1 test case ran. (2 ms total) [ PASSED ] 9 tests. # cros_camera_test --gtest_filter=Camera3DeviceTest* [==========] 22 tests from 4 test cases ran. (1044 ms total) [ PASSED ] 18 tests. [ FAILED ] 4 tests, listed below: [ FAILED ] Camera3DeviceTest/Camera3AlgoSandboxIPCErrorTest.IPCErrorBeforeOpen/0, where GetParam() = 0 [ FAILED ] Camera3DeviceTest/Camera3AlgoSandboxIPCErrorTest.IPCErrorBeforeOpen/1, where GetParam() = 1 [ FAILED ] Camera3DeviceTest/Camera3AlgoSandboxIPCErrorTest.IPCErrorAfterOpen/0, where GetParam() = 0 [ FAILED ] Camera3DeviceTest/Camera3AlgoSandboxIPCErrorTest.IPCErrorAfterOpen/1, where GetParam() = 1 (I guess it's fine if we fail the IPC related tests) As all of this has been triggered by a system crash with R78 I would ask Laurent to test the series with his environment. I tested with R77 and things seems fine. Thanks j Jacopo Mondi (4): android: camera_device: Add missing static metadata android: camera_device: Use correct sizes for static metadata android: camera_device: Report available keys android: camera_device: Rework template generation src/android/camera_device.cpp | 499 ++++++++++++++++++++++++++-------- 1 file changed, 379 insertions(+), 120 deletions(-) --- 2.23.0