From patchwork Thu Jul 13 15:12:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 18819 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 370BFBEFBE for ; Thu, 13 Jul 2023 15:12:24 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8A189628C3; Thu, 13 Jul 2023 17:12:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1689261143; bh=mSLo1h3BWM+r186sxgBtqK54EO8F4B4gRD53d5jhCd8=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=fwARtFqIMMDzjXhelJmWdrxT6c6Eezxx+oEd+6rRjs+SZM1zHgw8mi1BY6LWGZmt1 zPY+k39z1XZadoscGZ9Z921scNEqo3zTBIGqYZubzPvYLj5vC5VIjMxVJvSWaM/sHS vxMLi1jM+LgJ0hyghZYk4TaNOAbjdPHEM/wdo32OkBlVHvWsySRRJPlORSAeQ8XNx7 iVnZej1AfiC6qj9BWMlekvBRl95AmmGuRvAGnGi+hzZlYx8bzrdZG3kLNWgj6eBE9d 8zHIHB0xtIywR/niZZEpdwh7yYrW+fPurdfMfw7na9TGSlLnMDcC6hS00Fl/LuVCNl KBulc8yrbQzTg== Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C21F161E37 for ; Thu, 13 Jul 2023 17:12:21 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="J6qU0awO"; dkim-atps=neutral Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-3fbc244d307so7565305e9.1 for ; Thu, 13 Jul 2023 08:12:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1689261141; x=1691853141; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=gH+9VwTh3c2cM3epKAtUfdcmJJ/qx+o7QloPZItfAic=; b=J6qU0awOSG1NA4fDRDhYbyK4mBwR6EL8TytZyUceXqX7VQ/yECnIHbhv/u2srq07Ff yPVFzlhRQKHKerRdsvCn68w1Km9LuH98gYg7+kGUkmFJSQgpZE88dPTWqnZGNN45dl7I hX0xdzPyMii9dO1Gc/GaIZr5zXlRe4SVYHCat30yKVZUNR1+zTkiazkRd3mDtAOVuP/R Lv3ZVH93KT1nYqUB4I4CMsUP2rySjRiwXgKbUwY95Q17Wszo9XKd8W0SzJLEMGDmaQnM g/+TOJQaZoj8d9znsk3TN4f6s3s8uFVpC/uKbc7baP/R5dviDIJVfqObPYZHOmskEBL7 pTUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689261141; x=1691853141; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gH+9VwTh3c2cM3epKAtUfdcmJJ/qx+o7QloPZItfAic=; b=X9wocasdN7mMzSRfOlDp4iEB1ghq4fR99pk9gK58C4JRn0z2yJU8gDar5szTJcbgm0 duRR6nyebjmL5Bo3pTRcWwkOBHkg9Q6/YTs+Vqk4aBCn/dZHACR7FY0dBJw67xnLHpWt 3mxJqTdzp/nzz9g5aX7dqBZFyJqwci8JtUuAbhdWMf/z9sm+dUtyPBK4hbTamp1uoXte XC7s/NZODEizGLYq4Ycz4/zxWvy92PCZS2y6AsXaGiMXX7a0jjf8UzWprP01zTc1PnDb cGP0I4fmVadL1aMcynIjb7yrdaFuRfv+1Nj5kYHh6ytSNisJAy9kVDd2uBotq9xIK/uA 3UHQ== X-Gm-Message-State: ABy/qLbm0d65w2LY4q1xhUYkINhwkXFyOdPr5EwHdg0cbEJADJBtTWUg 3CQVYbXcVdxC9PZLPWtqGSu8GkZNLxXDwVbjDBw= X-Google-Smtp-Source: APBJJlH2NzxGpbW0HUYk5N7rR6HMBNbG1WfJWBPCKM1ZkVOqw/3ps8vYWslWZKq0laYLmsoKnppDTw== X-Received: by 2002:a7b:ca56:0:b0:3fb:9ea6:7a73 with SMTP id m22-20020a7bca56000000b003fb9ea67a73mr1651442wml.23.1689261140878; Thu, 13 Jul 2023 08:12:20 -0700 (PDT) Received: from pi4-davidp.pitowers.org ([2a00:1098:3142:14:2bce:64d6:1a5c:49a2]) by smtp.gmail.com with ESMTPSA id f11-20020a7bc8cb000000b003fa98908014sm18771086wml.8.2023.07.13.08.12.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jul 2023 08:12:20 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Thu, 13 Jul 2023 16:12:16 +0100 Message-Id: <20230713151218.26045-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 0/2] Add flicker avoidance controls X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Plowman via libcamera-devel From: David Plowman Reply-To: David Plowman Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi Here are the flicker avoidance controls, as I think we agreed when discussing it last week. We seem to be up to v4 now. The main change is to remove the explicit 50/60Hz modes, we now use the custom mode with an explicitly supplied time value. Elsewhere documentation is reworded slightly in places to conform to what I think we said. Thanks! David David Plowman (2): libcamera: controls: Add controls for AEC/AGC flicker avoidance ipa: rpi: common: Handle AEC/AGC flicker controls src/ipa/rpi/common/ipa_base.cpp | 64 +++++++++++++++++++++++++- src/ipa/rpi/common/ipa_base.h | 6 +++ src/libcamera/control_ids.yaml | 79 ++++++++++++++++++++++++++------- 3 files changed, 131 insertions(+), 18 deletions(-)