From patchwork Tue Jul 4 23:44:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 18788 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 25C1BBE175 for ; Tue, 4 Jul 2023 23:44:25 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5A2B0628C1; Wed, 5 Jul 2023 01:44:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1688514264; bh=nzBuhtF/BYv0CfA6W1HxeJMEOe0xHgtl2m75R1dNs88=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=u9PQG881xWzso4YRywnpK0JSXyJ9ye+ihtny0QSM+BYwzvinpym0fQRMeghxjof3d u/FWunIygsyajuHkHmHaOVuPFIX9Bo3krWZssEWbYwBUvniVaF72GiSNhQDhy0EkvL JzdnZhWljWszRG6+Y+XUjpwPApPNtFgmZ27nWP4sptFI0EHfYqjJ2g63M/k3e+Ay7b 9m/wh8oxwQ+K45cqHwYXG1P3DfoxZoM3B3YhS4z8VIeQfNldhQrSfBKYmdhxPN14ez b5/YW0VrgcCX0/3DKE4+nuL8LjNyR+JNi4Ade/HPFUgS9SCcGPf3ocOglQdf8CCa2F CcJGIDX4igRlg== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A537D61E38 for ; Wed, 5 Jul 2023 01:44:22 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="O4caaKQH"; dkim-atps=neutral Received: from pendragon.ideasonboard.com (85-160-42-71.reb.o2.cz [85.160.42.71]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id F38108CC for ; Wed, 5 Jul 2023 01:43:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1688514218; bh=nzBuhtF/BYv0CfA6W1HxeJMEOe0xHgtl2m75R1dNs88=; h=From:To:Subject:Date:From; b=O4caaKQH8DQY4MNfT0lgRq3T0b4fi1yo2zv51yZPaznsqeCClgTiAB4BTeim33wk2 DokPo03F9t/arvnZLPJh5YhY6yep4oYbbnKBx/j0z3LkLuOrJpvBzcBlDK0OgVhKZi vrGA8ImvJUYz1Zb5ilORIxIO1iuErSvep/qnq8y0= To: libcamera-devel@lists.libcamera.org Date: Wed, 5 Jul 2023 02:44:20 +0300 Message-Id: <20230704234422.11863-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/2] libcamera: Add an application to verify IPA module signatures X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, This small series adds a new utility, named ipa-verify, to verify signatures of IPA modules. This is useful for packagers who want to ensure the packaging process doesn't break signatures. Patch 1/2 fixes a bug in the Doxygen documentation generation that didn't take macros defined in config.h into account. Patch 2/2 then adds the ipa-verify utility. I would have liked to add the utility to the utils/ directory instead of src/apps/, but that wasn't possible due to the utils/ directory being processed by meson before src/ipa/ and src/libcamera/. I didn't investigate alternative options much, but I can if desired. Another thing that bothers me slightly in patch 2/2 is the addition of the IPAManager::pubKey() function. Ideally the API exposed by internal classes shouldn't be driven by the need of external tools. I would probably consider it to be a bigger issue for classes exposed through the public API, but as IPAManager is internal, it's probably not too big of a deal. Laurent Pinchart (2): Documentation: Add predefined macros from config.h to Doxyfile apps: Add ipa-verify application Documentation/Doxyfile.in | 3 +- Documentation/meson.build | 7 +++ include/libcamera/internal/ipa_manager.h | 7 +++ src/apps/ipa-verify/main.cpp | 64 ++++++++++++++++++++++++ src/apps/ipa-verify/meson.build | 15 ++++++ src/apps/meson.build | 2 + src/libcamera/ipa_manager.cpp | 13 +++++ 7 files changed, 110 insertions(+), 1 deletion(-) create mode 100644 src/apps/ipa-verify/main.cpp create mode 100644 src/apps/ipa-verify/meson.build base-commit: 8da938b00705c7bdc188174f45ee485d0880ee1e