From patchwork Tue Jul 4 22:57:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 18784 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 90BD8BE175 for ; Tue, 4 Jul 2023 22:58:48 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id F0998628BB; Wed, 5 Jul 2023 00:58:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1688511528; bh=Ben1xstmVBvh8S1r/YrSdrbSdE0NWRgdg02/Sy6xcRY=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=m/h4OYgtOuQvHd4y7xz+ghEFPQGANdTOfg2ldMGq8+cY4MwmFULAzwVK3y06iJfD+ nZkJtmy1EdoFbYKyppgbXJJcT/DZA1dT/KdpbeUoqPclFvZTXjudMsFCMhosk0J+g/ bPbMv/YZhjPJCWyBVCMZXnQEs+DCFMNBfgThh/CHW0bJUdnAZXabfN+LlovDr2P3GZ hl87QfTpVyapTNfPEyiEPeEcPGQsItTFw2bLPvSoKtOVC5wtQCpxSWAqh1YtFJYV1H lOQnHHv+KH7bEPP+bIV3BZVIoKOeBpJGOoV6CqnaRGxO7/dG/SNXwXO/4fuSiXvMTJ tNYZSV7Ubpajg== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 83E8B61E38 for ; Wed, 5 Jul 2023 00:58:46 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="PRy12DfV"; dkim-atps=neutral Received: from Monstersaurus.local (aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net [82.37.23.78]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E6D27161B; Wed, 5 Jul 2023 00:58:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1688511482; bh=Ben1xstmVBvh8S1r/YrSdrbSdE0NWRgdg02/Sy6xcRY=; h=From:To:Cc:Subject:Date:From; b=PRy12DfVZxz08Vu7CFPrTrmJTmrwl8wISkFLn7GJKDU/457XKvfxau+MrQ5B94HVW 21fFgjtDiOx0KmG5803FDe0vj+nWYq6AqCBsW8qXwnspDAK4S9TIxSc6tDnYESDe/g /7gaGdeGVV7ymiS75rQnZx0Z6zqstXuVv5YZNJyQ= To: libcamera devel Date: Tue, 4 Jul 2023 23:57:44 +0100 Message-Id: <20230704225746.3838484-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/2] libcamera: Remove CameraManager::get(dev_t) X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Kieran Bingham via libcamera-devel From: Kieran Bingham Reply-To: Kieran Bingham Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Now that Cameras expose a SystemDevices property which reports any associated dev_t identifiers, remove the now redundant implementation of CameraManager::get(dev_t) which was provided purely for the V4L2 Adaptation layer. The V4L2 adaptation layer reimplements the same functionality relying on the SystemDevices data instead. This series removes a public API function and is a clear and intentional break of API/ABI, as these functions should not be used by applications. Kieran Bingham (2): v4l2: Use SystemDevices properties to identify cameras libcamera: CameraManager: Remove ::get(dev_t) include/libcamera/camera_manager.h | 1 - include/libcamera/internal/camera_manager.h | 3 +- src/libcamera/camera_manager.cpp | 42 --------------------- src/v4l2/v4l2_compat_manager.cpp | 29 +++++++++++--- 4 files changed, 25 insertions(+), 50 deletions(-)