From patchwork Fri Jun 30 12:02:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 18769 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id EA5EBBE175 for ; Fri, 30 Jun 2023 12:03:11 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id EF4CF628C3; Fri, 30 Jun 2023 14:03:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1688126591; bh=rwDh8VYiPeGopcG2JMmpXpzPCe7xDVWajxoS8TSBlZE=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=0PFqYI1BuJ5/oy2NkjEkpHx7kQUSUHPhdWpsw9/dwIsNuSqz9xSTc80lbETSYICch mK6/qdGzC39luE7NXyMbebu4c/MupNPddI56/OFMut2x96cAPQVY+2TvARTW+uwSNJ wjP2mxtPftjrVyoF63S8vJjL/Gy86SEfKEV5NnK8OMwijFK0GdbAr5G+pywv2jD6KV ugPmWBakC5x6Jy3VbayXX6+tOiHTOAnFQqI4U7zLNnSuyEDl3Ex/euMvDqz6pNKMyI LRXvcftfQJJw06dxx3fl3+QCtJKCCEeUJFTfTkT5qHTvlYwtSjGWJRTCWZcbiX0iBc 0j0UTCmYgbHgg== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 82E6360454 for ; Fri, 30 Jun 2023 14:03:08 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="qhSf+xNB"; dkim-atps=neutral Received: from umang.jainideasonboard.com.praguecc.cz (unknown [193.85.242.128]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BF4C46E0; Fri, 30 Jun 2023 14:02:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1688126547; bh=rwDh8VYiPeGopcG2JMmpXpzPCe7xDVWajxoS8TSBlZE=; h=From:To:Cc:Subject:Date:From; b=qhSf+xNBtMLhyHf8rj+j8u31NslddkRfHTRaFKv+edC8Nh8Hqyc5d/k6lc1JglE+a /zo07/9qWh48G+PVGnrp302iWMbY7QoCfUcEup9xD9JN8rSX5TM7rllGfO9h6ahlat +jzK1JsNfjOBWnN6I8Ae5ot0PQYW6faQ+/lt4ROE= To: libcamera-devel@lists.libcamera.org Date: Fri, 30 Jun 2023 14:02:58 +0200 Message-Id: <20230630120303.33023-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Subject: [libcamera-devel] [RFC PATCH 0/5] ipa: rpi: CamHelper improvements X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Umang Jain via libcamera-devel From: Umang Jain Reply-To: Umang Jain Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The following patch series does not intend to introduce any functional change. They are just logical improvements that I can see to ease readability of the code and generalise a few things. P.S. - Excuse my limited understanding of embedded sensor data probably at this point. - For readers, some relevant discussion might be in: [PATCH v3] ipa: rpi: cam_helper: PDAF support for IMX519 - RFC because compile-test only Umang Jain (5): rpi: cam_helper_imx708: Use Span<> to pass PDAF data ipa: rpi: Make parsePdafData() available in the CamHelper class ipa: rpi: cam_helper_imx708: Only pass embedded buffer in parseEmbeddedData() ipa: rpi: cam_helper_imx477: Only pass embedded buffer in parseEmbeddedData() ipa: rpi: cam_helper_imx519: Only pass embedded buffer in parseEmbeddedData() src/ipa/rpi/cam_helper/cam_helper.cpp | 29 +++++++++ src/ipa/rpi/cam_helper/cam_helper.h | 6 ++ src/ipa/rpi/cam_helper/cam_helper_imx477.cpp | 9 ++- src/ipa/rpi/cam_helper/cam_helper_imx519.cpp | 8 ++- src/ipa/rpi/cam_helper/cam_helper_imx708.cpp | 63 ++++++-------------- 5 files changed, 67 insertions(+), 48 deletions(-)