From patchwork Thu Jun 15 22:51:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 18744 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id AC0CCC322E for ; Thu, 15 Jun 2023 22:51:40 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id DCE11628BC; Fri, 16 Jun 2023 00:51:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1686869499; bh=+xg2DWK8PyP2u/zu/4LoseaTIv7vgCVu2QGm3O/+GNA=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Ax2oGlzpNwHqaIPNYBl3FL03Djf1fXitB0uDbkFnv77svZwPXKnD/LvalQxp3iLIT /GhnmsGkRecVtJIQ9cr6/gOEpnmRzkwjApuXX5enqGqrQTxga5H260Kn98gVSzw8Wd ytuM/d0rjSoM8c1dPfHh2ICBy4CQNioBS1teIEmloGN9W2wv/7JwQIpZBQKspNBdpc gU9prRidKqi/XjyEpRbiwzmPJSzNsF+vPLjDGXTiDgUpiPWRKgpco00oeUcg0Rs0Xy bWkuTuDxQ72iFKS0ATEFw0O7bZz54rodzNv1K5qAy1Q9VjqTYQ9L/KAZ0mzMAp1ZDH KKQ3xttC8oVyg== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C9CD061E4A for ; Fri, 16 Jun 2023 00:51:37 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="jIxS8ez0"; dkim-atps=neutral Received: from Monstersaurus.local (aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net [82.37.23.78]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DD4CABEB; Fri, 16 Jun 2023 00:51:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1686869466; bh=+xg2DWK8PyP2u/zu/4LoseaTIv7vgCVu2QGm3O/+GNA=; h=From:To:Cc:Subject:Date:From; b=jIxS8ez0Vgh3GtY3oxUveOaK530nREHLokjfVMzX7YvctYiR7nSPoQ6f7kfzVHdAW 13tlScj55tnW3IgkhqZYbwQwTknQggvwES376hQtToGpfMrg62qoAOqb2EVZ/JTuOT zcXfAvUtWRQoxurMWQtptOSrmDtL5jZaAXR8MLMk= To: libcamera devel Date: Thu, 15 Jun 2023 23:51:31 +0100 Message-Id: <20230615225133.622612-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/2] libcamera: Remove CameraManager::get(dev_t) X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Kieran Bingham via libcamera-devel From: Kieran Bingham Reply-To: Kieran Bingham Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Now that Cameras expose a SystemDevices property which reports any associated dev_t identifiers, remove the now redundant implementation of CameraManager::get(dev_t) which was provided purely for the V4L2 Adaptation layer. The V4L2 adaptation layer reimplements the same functionality relying on the SystemDevices data instead. This series removes a public API function and is a clear break of API/ABI. It is (hopefully clearly) dependant upon the series " libcamera: Add new Camera devices property " [0] [0] https://patchwork.libcamera.org/project/libcamera/list/?series=3925 Kieran Bingham (2): v4l2: Use SystemDevices properties to identify cameras libcamera: CameraManager: Remove ::get(dev_t) include/libcamera/camera_manager.h | 1 - include/libcamera/internal/camera_manager.h | 3 +- src/libcamera/camera_manager.cpp | 42 --------------------- src/v4l2/v4l2_compat_manager.cpp | 28 +++++++++++--- 4 files changed, 24 insertions(+), 50 deletions(-)