From patchwork Mon Jun 12 22:47:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 18726 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1375CC31E9 for ; Mon, 12 Jun 2023 22:47:53 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 70A1761E51; Tue, 13 Jun 2023 00:47:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1686610072; bh=EKKN1kSquDXDKGzr48/iKveCivDb6CTbX3zXSfmPrEo=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=j+IctNHMBOa6V5AefZFAsafbg1jRbakkyReFn722HO0EM8qNlHOsWCYKCcPlBYd8e f2SEnPIV99n5AJZvrvZrZgN47AvjK9ntse5HnD24vG1bQfl3BchsKsLes2m01lMLDT GQBBeV3IlY75pa44syoOOYF3L9UZH1XLprKDAC+UQ6fVNmgiHvGVaa6WYS5qCbMxYl 7wjrGb1VfG7WLlUkRhDRmXgmHbFsdQbnMM0SiL4SwK7YcMdYjf7IZdcojYJdMOSEHZ KOYVl18pcFYEcXCkJ6uvZDc3AdRmVZ2w6VuIhjCD/5D/aHUEjqvucRcBlK+4WdjDOu A4mrGIzeKXRnw== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BB01C6020C for ; Tue, 13 Jun 2023 00:47:51 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="nRWachTa"; dkim-atps=neutral Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A9498C7F for ; Tue, 13 Jun 2023 00:47:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1686610042; bh=EKKN1kSquDXDKGzr48/iKveCivDb6CTbX3zXSfmPrEo=; h=From:To:Subject:Date:From; b=nRWachTaJje8Ei/IOB5e0egAXkrEhh0KqHuHyaLiiMMBWtyJQ8I55/Umw9S6Qy2Gw cHyIkFPCxYxQaMZ0w3DPaSet8eBoSHKv6XulC2nGVMBla9ZAmD6HkipXEM/LTFn+xk SimQsxIaFe4G9+WDoTn/LR/vb+JBpXG2SiURjVCA= To: libcamera-devel@lists.libcamera.org Date: Tue, 13 Jun 2023 01:47:47 +0300 Message-Id: <20230612224751.4437-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v1 0/4] utils: checkstyle: Add a commit message trailers checker X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, This patch series originates from a discussion in the review of "[PATCH v1 3/3] ipa: rpi: agc: Gracefully handle missing agc modes" related to usage of git commit message trailers. It led me to realize that quite a few issues went unnoticed through review (about 1% of all commits in the repository). This shows, in my opinion, that humans are not great at catching those issues. The option of fixing humans being deemed too difficult (not to mention ethical problems), so I went for automation instead. Patches 1/4 to 3/4 are small improvements and cleanups to checkstyle.py, with the main change in patch 4/4. Please see individual patches for details. There is, in particular, information in 4/4 that may require some discussion. Laurent Pinchart (4): utils: checkstyle: Add __repr__ method to CommitFile class utils: checkstyle: Support running checkers selectively utils: checkstyle: Don't include commit ID in commit title utils: checkstyle: Add trailers checker utils/checkstyle.py | 127 +++++++++++++++++++++++++++++++++++++------- 1 file changed, 109 insertions(+), 18 deletions(-) base-commit: 0ee9339331c648232e87d2de2ccd5a92cc61cab2