From patchwork Wed Jun 7 10:00:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 18715 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6E57DC31E9 for ; Wed, 7 Jun 2023 10:01:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E75CE62897; Wed, 7 Jun 2023 12:01:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1686132066; bh=CE7YcicQWOrSunI41GZy2zaiIcQqCVo/+mHrxNnWxcY=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=KF7dHEk0JSCWsm54GktSOOinxgD4+tSq3Nhkq6bCIubcv13gEm0SnFeWYng3eEb6n gywmE5257xP0Ns6+OVABU3TPgLR5DgbNfPastdT7z6jsIycZjyj+3MtgiOAbJ4SKUk 61esIAv9KM5F6bemRgBr5MtLWwvll1H5l0BDgCzN9tydvOHnyTL/KiBcj2TLc5Rdrt /BGX96ttXR1xheSXLXoATa4k0TGaUdbu8zXbxvXLu9VaZKjkcvTZriSYrh91CeemAn PwUtLKWmyTxmUqRmjBbtv3iyFNodv8CTMUCcl7e/2qa+apNYlk3ghJ7pHQ9AaVMix5 Eynn53hZD3cIg== Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5AA5460579 for ; Wed, 7 Jun 2023 12:01:05 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="LWuGrO/9"; dkim-atps=neutral Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-3f7a8089709so34583745e9.1 for ; Wed, 07 Jun 2023 03:01:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1686132065; x=1688724065; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=oXKZF/fiAYqffKu9fSNM0feS0KIgkZtWdl9OP8OCsT4=; b=LWuGrO/9uE70VXwORhBSTcZfD3FEfanOdJdY6WJlqErnaRNko9fnL0O+crDFgEUV5p /3XHsfuyJMy5TF7u0rgAofdD/O6IKurX3sP8XFr6zrIhAtuFI+GPN5YQAmlhOh0YSnmH cmhfoBaGpb33ekhTtrfCaI6ivDKcYPe6ywHujMSxar4BhvDF4VYu+pq6N5eXL9o1p0mL rqOBHY1o1eEErr9fWbp12KAHJwRJ755acvvgTo/h7hJhNQZbi2J5U5lsIcy39GPnCAbq jAyzY9XgShnCsvRN7AzPuGhQGhJ8kndxpKIxdUS39qBLu21qVT8DJakuvre5doYD6zRj LrXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686132065; x=1688724065; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oXKZF/fiAYqffKu9fSNM0feS0KIgkZtWdl9OP8OCsT4=; b=dENodu/Kw0snyyj62oQpCcM8szmOH6sSW9rfBNHHeioiimULl/P7bmj21jQd5QJs4u T1xJyFwigLN0KAqfDWS7C3GjyAWplAjOFKSLIoyXTmNNydDwfIZUeRczRae8ibUX54dc 7f2j9h9zRb82vef9ErGk+0PKeK0n576iF4qLCkcXkGd9QorK8rEjsEXwr5JSvxkrfRC/ e+SqKyyna2PDPuAP1ufrkAIyzEnvCQDNvjVKX/17cbCDJt90wBM4rf8kH9bLofBljaRm ZJXFfz1dSkiTquLeYkr6hv4CmbRwFRr8lOWAChrMwFjRks7IYP2q9P1HuH5J/y9KCfYS YTOQ== X-Gm-Message-State: AC+VfDx9w4vP79kDCfWo7OeN8a+z9TpCXngxaMpjzMko1UCCw2ZBBZHs KCCrKm5T+HA2MZRfTBKNZSiXVVtTp+blQKrm2u/4XA== X-Google-Smtp-Source: ACHHUZ4CEAjXZlaB/cuTYhw5rLZuj4xOJImS4D/oSvawvy8czvCTmlMj5xvvRAP2Z++lz3L5uL0BlA== X-Received: by 2002:a5d:5442:0:b0:30a:e5bc:547c with SMTP id w2-20020a5d5442000000b0030ae5bc547cmr3843991wrv.9.1686132064630; Wed, 07 Jun 2023 03:01:04 -0700 (PDT) Received: from localhost.localdomain ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id t7-20020a1c7707000000b003f6cf9afc25sm1556889wmi.40.2023.06.07.03.01.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 03:01:04 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Wed, 7 Jun 2023 11:00:51 +0100 Message-Id: <20230607100054.4576-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v1 0/3] RPi: AGC error handling X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Naushir Patuck via libcamera-devel From: Naushir Patuck Reply-To: Naushir Patuck Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, This patch series address an issure reported at [1] where the AGC would throw a fatal log message and kill the application if an exposure profile was set but the config was missing in the tuning file. Patch 1 adds missing "short" and "long" exposure profiles to all our tunings. Patch 2 is a small cleanup in the agc code. Patch 3 demotes the Fatal log message to Warning when a missing profile is requested, and uses a default profile instead. Thanks, Naush [1] https://github.com/raspberrypi/libcamera/issues/59 Naushir Patuck (3): ipa: rpi: tunings: Add missing short and long exposure profiles ipa: rpi: agc: Use std::string instead of char arrays ipa: rpi: agc: Gracefully handle missing agc modes src/ipa/rpi/controller/agc_status.h | 8 ++-- src/ipa/rpi/controller/rpi/agc.cpp | 53 ++++++++++++---------- src/ipa/rpi/vc4/data/imx290.json | 5 ++ src/ipa/rpi/vc4/data/imx296.json | 5 ++ src/ipa/rpi/vc4/data/imx296_mono.json | 5 ++ src/ipa/rpi/vc4/data/imx378.json | 5 ++ src/ipa/rpi/vc4/data/imx519.json | 5 ++ src/ipa/rpi/vc4/data/imx708.json | 5 ++ src/ipa/rpi/vc4/data/imx708_noir.json | 5 ++ src/ipa/rpi/vc4/data/imx708_wide.json | 5 ++ src/ipa/rpi/vc4/data/imx708_wide_noir.json | 5 ++ src/ipa/rpi/vc4/data/ov9281_mono.json | 10 ++++ src/ipa/rpi/vc4/data/se327m12.json | 5 ++ src/ipa/rpi/vc4/data/uncalibrated.json | 10 ++++ 14 files changed, 103 insertions(+), 28 deletions(-)