From patchwork Mon Jun 5 08:26:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 18700 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CDD26C31E9 for ; Mon, 5 Jun 2023 08:26:12 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3AEB962754; Mon, 5 Jun 2023 10:26:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1685953572; bh=GPheYf4SJ8D9AGCVjR884L3j0T2vxLjctZEtixQlZk4=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=FUwEiaj9sl/6t1kSj7aNH3uxkxryqOJmYRQRQpagv1/12JpmWw94AXRa7VUujNfds Tv7+RwXNXpK4xGutkfT9awQ2usoq37Dn73UYJt+RK6a2RTkbYVCbF+eVAzNFEaAQYl BwqKOlQQcw88Jy1LFfc18EhM6gmf7GCKYDkx2U8qfHt1G2UaIFQM8/b2PM0tErKyli GtBYwhIPq1iV6YAZiXmc11eRVqTxmkulUd7CW5IMk+ygS4e1osKvJZWZCELVawJfnZ uuVuHl6y9Gvafn1vS4gTyMf75z1yKqAPx2XLTLJEVNbe3X2tbgsSHB0AgOLPDwC7y9 idbkQMFqnSY2Q== Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 89CAA61EA2 for ; Mon, 5 Jun 2023 10:26:10 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="oBP1WqpQ"; dkim-atps=neutral Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2af2db78b38so56182691fa.3 for ; Mon, 05 Jun 2023 01:26:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1685953569; x=1688545569; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lZYgWU2/tbFTUCYEDUMlw35sjfXtuyY5ei2oLKJ89rk=; b=oBP1WqpQ2quo8NCNsbJ4x4+6Es0pgvh8QFrxpW3Gey/EmiCGNK5rsVVLCyQluFSQmK KNUQklPFMahe1BXWU7SkOWfPIQa+QnCjPah9X7130wPlGr/Q1m0Gcv3LtEOOI58Vxfte u9Kc06w2lMzPp2DVY4D7xg9HwdkoaSV4depm/WeAsvBQlJRelKzfgtc4aWJRjs6kjkNQ 6NrJuzXXF8b3nCCOnvaJeAWXPhJrtuKly2WgHS6chAdISihFdpBDi8E2QW9cJKxYOE0D 1Zv4EqFCoNy6fLTxTjTiaO1UZtAwuhSIdeBlFd6kcoerPIIQM+Sqy7ktAa1Ils3TVGvC CCDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685953569; x=1688545569; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lZYgWU2/tbFTUCYEDUMlw35sjfXtuyY5ei2oLKJ89rk=; b=aInHK9k4mAZi41AGNaN0smarKXBVLJNIY4nK53ZA6rUC2an+Pl12W+q2RIa5un75zE HoV+Z9cURaVNpBMvf0MhpzubICFN4dklzh50VYjpcKesmzdhaqDwn5/YqhmDeRj9ND/8 UIqyTr2NJSN+ARAhcYN2Nb+boveGic/tTxI6dCRYmUQfh5lXT0UvPYWreSxo7IHR0BXm X4POPt+CRFAHHoFLWCErW2uV+uSp4cot+U8r9Qs8iRVsjefZZMHyNY9OM0KJYQkenrfp aMIO1s98QiBcryojNwOnSaMwRz60r1iJUVLT8UHDricbsiZVhwxJ7AhxIcEg4GjL15Ca v3Cg== X-Gm-Message-State: AC+VfDwcp/qOFuXrISfcuRkAqzwEb8bXIjfOkGOr+E/N7YX5LZseoXkp IwVInW5SLuzxz4cvq7UT2UHdljMF4SakaBy5y1+ncw== X-Google-Smtp-Source: ACHHUZ6H6NPe4H+j/zqUSpMhQa/+dzMovF4XeRKKbNmVetJ0TjmgBmktEtoJcgsl5S5TjGKIz0Urtg== X-Received: by 2002:a2e:9788:0:b0:2ad:9c17:a78f with SMTP id y8-20020a2e9788000000b002ad9c17a78fmr3695091lji.53.1685953569422; Mon, 05 Jun 2023 01:26:09 -0700 (PDT) Received: from localhost.localdomain ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id 12-20020a05600c020c00b003f080b2f9f4sm13520686wmi.27.2023.06.05.01.26.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jun 2023 01:26:08 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Mon, 5 Jun 2023 09:26:03 +0100 Message-Id: <20230605082605.9993-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/2] Mono sensor improvements X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Naushir Patuck via libcamera-devel From: Naushir Patuck Reply-To: Naushir Patuck Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, Some small updates for v3: - Add a \todo in patch 1/2 to note the need for optional vars in the mojom interface. - Pass IPACameraSensorInfo into ipa->init() so that the ControlInfoMap is (more) correctly setup before the call to ipa->configure(). Regards, Naush Naushir Patuck (2): camera_sensor: ipa: core: Add CFA pattern to IPACameraSensorInfo ipa: rpi: Handle controls for mono variant sensors include/libcamera/ipa/core.mojom | 13 +++++++ include/libcamera/ipa/raspberrypi.mojom | 1 + src/ipa/rpi/common/ipa_base.cpp | 39 ++++++++++++++++--- src/ipa/rpi/common/ipa_base.h | 1 + src/libcamera/camera_sensor.cpp | 3 ++ .../pipeline/rpi/common/pipeline_base.cpp | 10 ++++- 6 files changed, 61 insertions(+), 6 deletions(-)