From patchwork Thu Jun 1 09:56:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 18674 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6C7A7C31E9 for ; Thu, 1 Jun 2023 09:56:35 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C749661EA6; Thu, 1 Jun 2023 11:56:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1685613394; bh=daTkJa4Rt1RHhLpUFd4MndIrVUv35U/jsC9AvSpwe0M=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=mHaLhJ2jfTvOuL7X9E60iIRPApHMGuim4LRp9ClBZyTFjBRL0XRBdqUWUZ9Gx1JUx ktXZ6co9K51AE3D8XGrUZkT8MY7gednTiFwmXstQE5ggBa/nLGJdy0VnjMiErk9G9Y E2DU6YLJFSU9KgTx02LRxThy8lDKujjiOHL4QxXvBzV375pF0r/L17CL/tyi2bxxHz 4YOUoYNwHlgvLVAiNwdWNLXldhDkyM2aYpWzEpwvXjqB36CtyC/EegILqsp2MsVA5W LdAspF5PNT/w0LXNTUHqAf13YM+SVY+hzPeXVxLw0s0LofJHO3RG0Iu3Mf5mNRyA5u GYKGlNd+3DNgA== Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C91A61EA6 for ; Thu, 1 Jun 2023 11:56:32 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="b5XM4dK6"; dkim-atps=neutral Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-30aa1eb95a0so682826f8f.1 for ; Thu, 01 Jun 2023 02:56:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1685613391; x=1688205391; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=73uN0vpNsSBwwK8jAejQivunPg0Ny3j07niEXcG9Qhc=; b=b5XM4dK6YwsKJtUlGNXvkB1YuC3veoOiIBA9CklxiM5XAxJ5WSLYnDaARAVVVu47Xn /HxjdqAe70JmH/Nj9Pu58LKnb+e/sx8vZoP9dR4QqVAnKtmMje4RCqae+BAEp1qUZntN T5ylrVkPrCzccU3Rpfp3a3V/VWiGQUa8GE2/KZ1uyIxYO4CJmKS81i8EsOS60YPsC/7v WeHOu4dbEK/K5IHzTXIdZu04F1X8EwogqzPT3qU2zi22rNneI1uTubMSlsF2hMzG+C4u Zt4+OEHLxxHfNEWhEIRFgNm4u/jxq4KH6w/shfHjp9eJbdojB4Zkj+3hnRaU+Usf0rau zP7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685613391; x=1688205391; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=73uN0vpNsSBwwK8jAejQivunPg0Ny3j07niEXcG9Qhc=; b=S5pMkj52EZIPDO8aGrmT4BI3PfBiBDPnaGTIQhCSmMK0DWf/knwpVicP1CrmbcFVG7 I12M0JrcDRZnoko7uM3d6iIkxXxS/sT+Nd4FVJKIX/9z1nUblDkI3a35P2PrZqwot6eI hvvWxK8gt1NO0AArKSfCecXBNuF/eJaJbdcsdELU36Du1UULlpsFYgqykoF9jfh2Nd8e 4pwhUAcEbnDsoSjBfxuPtAc3dKmiySXc5wOAHbd4HyTxbWm0OEUZGEEN/nGHevdbXjvr MIR0YUGb5FbGNXjqpBbVaidK7wIwvvjl5xRd1lfTVXj+1dzxys7L4qCn/D9KW1MoUG4D r4wg== X-Gm-Message-State: AC+VfDwPBPqYBDFgC3Xi8tmsCOEtjIJ5npMY2qVu9t6Syp8Z8Nls728i VYgZjjyNExI+MMx2ub/jLPJzo6sNdoAb1Dthb2Tjuw== X-Google-Smtp-Source: ACHHUZ63RXu4x5aGvT88emxTepw8j6n8TC7lsrGHvFHoIfjwSS8VSXWXjEV2mnWI75eFe3ssIaLNtA== X-Received: by 2002:adf:fd8a:0:b0:306:492c:cdd8 with SMTP id d10-20020adffd8a000000b00306492ccdd8mr1382837wrr.15.1685613391448; Thu, 01 Jun 2023 02:56:31 -0700 (PDT) Received: from localhost.localdomain ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id h12-20020a5d6e0c000000b002ca864b807csm9889531wrz.0.2023.06.01.02.56.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 02:56:30 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Thu, 1 Jun 2023 10:56:27 +0100 Message-Id: <20230601095630.25443-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v1 0/3] Default lens behaviour X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Naushir Patuck via libcamera-devel From: Naushir Patuck Reply-To: Naushir Patuck Cc: nick.hollinghurst@raspberrypi.com Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, From the discussions on the GStreamer focus controls thread [1], we decided to define a default behaviour for camera startup to be handled by the IPA. This series explicitly defines a default behaviour by requiring the IPA put the lens to the position given by the controls::LensPosition default value. Typically this would be the hyperfocal position. Patch 1 updates the controls documentation, while patches 2 and 3 make the necessary changes to the RPi IPA to move the lens on the first call to ipa->configure(). Regards, Naush [1]: https://lists.libcamera.org/pipermail/libcamera-devel/2023-June/038008.html Naushir Patuck (3): libcamera: controls: Define a default lens position behaviour pipeline: ipa: rpi: Return lens controls from ipa->configure() ipa: rpi: Set lens position to hyperfocal on startup include/libcamera/ipa/raspberrypi.mojom | 3 ++- src/ipa/rpi/common/ipa_base.cpp | 15 ++++++++++++++- src/libcamera/control_ids.yaml | 5 +++++ .../pipeline/rpi/common/pipeline_base.cpp | 6 ++++-- 4 files changed, 25 insertions(+), 4 deletions(-)