From patchwork Sat May 6 11:10:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 18606 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 00069C0DA4 for ; Sat, 6 May 2023 11:10:16 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 599E561EAD; Sat, 6 May 2023 13:10:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1683371416; bh=lBXl4bwmvNvbr/pvVISd+96FMpws6Iu+0S64qNGxCRg=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=1OqBqDpnntlgme4sZTdED5wOgvguPO5AwA6mTDDNW2SNLI1I1ZZbdrJMDtU+anUd2 ApTPa1lCOG0y12fy2EOyaXCkjt0e3jwE+Xb4mAyBCGBgZqejJaSxib7anJwVfgVcLd YBY7f5ZR6A7lkyJ9fzkkaz0aSMGiSYkFpRcMAwWXdSN5n4O4jBU4cuXBmk4mn9NZOC nvxVzFhlOQ2vw+JTb8nnSzAmuqdtIABNJ10YDKp9xjOJZLRAImxw6/DjdmfBbtClrX fwJXiNTmrjjSRVWarNjwEKjYEMkoJ/N8rTt1ast1oDFRm+78HOC5EW5I6FTcLlLpJ3 SwkXIYvZdagcg== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C547861EAC for ; Sat, 6 May 2023 13:10:14 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="MGVX0c4h"; dkim-atps=neutral Received: from pendragon.ideasonboard.com (133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B6267800; Sat, 6 May 2023 13:10:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1683371410; bh=lBXl4bwmvNvbr/pvVISd+96FMpws6Iu+0S64qNGxCRg=; h=From:To:Cc:Subject:Date:From; b=MGVX0c4hrbvswAJWQgpOUfFUSWsUkUGXLXpiF/jZDkB2q8InN4vZ3lvCqEXMAuRPU fkbF+7i7ZgUg9HKsZ5NYLGzL4ykBl9dNQSX4Pj3diWorDPb6Km7kXd0ZrlTEdny8jI yf7jSGrk+eluFkcakCaemCqvg4rqWSBBlNGYzH5A= To: libcamera-devel@lists.libcamera.org Date: Sat, 6 May 2023 14:10:23 +0300 Message-Id: <20230506111025.18669-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v1 0/2] libcamera: Add an application to verify IPA module signatures X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, This small series adds a new utility, named ipa-verify, to verify signatures of IPA modules. This is useful for packagers who want to ensure the packaging process doesn't break signatures. Patch 1/2 fixes a bug in the Doxygen documentation generation that didn't take macros defined in config.h into account. Patch 2/2 then adds the ipa-verify utility. I would have liked to add the utility to the utils/ directory instead of src/apps/, but that wasn't possible due to the utils/ directory being processed by meson before src/ipa/ and src/libcamera/. I didn't investigate alternative options much, but I can if desired. Another thing that bothers me slightly in patch 2/2 is the addition of the IPAManager::pubKey() function. Ideally the API exposed by internal classes shouldn't be driven by the need of external tools. I would probably consider it to be a bigger issue for classes exposed through the public API, but as IPAManager is internal, it's probably not too big of a deal. Laurent Pinchart (2): Documentation: Add predefined macros from config.h to Doxyfile apps: Add ipa-verify application Documentation/Doxyfile.in | 3 +- Documentation/meson.build | 7 +++ include/libcamera/internal/ipa_manager.h | 7 +++ src/apps/ipa-verify/main.cpp | 64 ++++++++++++++++++++++++ src/apps/ipa-verify/meson.build | 15 ++++++ src/apps/meson.build | 2 + src/libcamera/ipa_manager.cpp | 13 +++++ 7 files changed, 110 insertions(+), 1 deletion(-) create mode 100644 src/apps/ipa-verify/main.cpp create mode 100644 src/apps/ipa-verify/meson.build base-commit: 0fbf6b57a7bd281c7d187244b7f480c0899cb94a