From patchwork Thu Mar 30 09:56:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cheng-Hao Yang X-Patchwork-Id: 18493 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1525EC326B for ; Thu, 30 Mar 2023 09:56:19 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2DD9C62750; Thu, 30 Mar 2023 11:56:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1680170178; bh=j88cucA4sUx1B/im/+LWfW9t3HUjy++c8fd5Na9SxFM=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=Nj2ipd3Gsp8bcVupIP8SxXk/Aa7x9v5I96yStL/Spk6jwkdKbnmTzMaZIn8eE2WNw 4M0FmL2ziRh+7an0dk7rxdPVI9mwEpfxbQwp+asZ5/Ht00Bm/YAD/+KMposF7oC3D+ KG2TJ1fBoMSj0Ic35YmQH33Y233XSZQuDRfbwkYLAd+PcxxcV2ui2oL5xr9Vk1Sdjd ZAMuEJvuVZD0ys1obZLIksoLfNIVoBFhJugI58NwfpEZ7mm05cKAzNL9xAIYRWY3Bd VeFjfp+LCqvwhtUmCBCiC/mVtuwhoqGU9trVWy0/RwQ6DYqxTJOrtScnxsZfNhHUsX DFiY6/DmwaI9g== Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 844B86273D for ; Thu, 30 Mar 2023 11:56:16 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="WTAr/uyq"; dkim-atps=neutral Received: by mail-pg1-x533.google.com with SMTP id k15so10954389pgt.10 for ; Thu, 30 Mar 2023 02:56:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1680170174; x=1682762174; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=siBoZ4lwt2qq2F9KK0b4eWLYLYrTFYsvLl/dw4pC4Bs=; b=WTAr/uyqdagwSjs6Ej8anGx/Z/LVYlQDqdBz0Vgg71EmckhEdFAGXO7CD3EWICf78O olyAqtzwDVnO3kzjAMcR7XZypraY9b0SzqDZtXmAqjqlKlDOXd2lsH8XFvcx7nuB2btQ NHl3u20eU6AlFHV2z1236aW0CpoFagFIkg1Bs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680170174; x=1682762174; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=siBoZ4lwt2qq2F9KK0b4eWLYLYrTFYsvLl/dw4pC4Bs=; b=eW2y9BnZK1WZiIETxQlDzgKmV8MEYxnphbOLffIT3q/Y80svzfFBwFAF8a1HQ/669M XCR9ngo0BgQJRxRnYCj10lhRuCkdq6SlitXHsTZ5sRf03bCp3lui3fh4ESIsBIsDP6KY 8675RaSffZHQNkwXgc/4qBae1xnjSIlEWVUcnqoPhfTRwyzvI4dAJurSNRP3qLhAdTOb KdoaqMt55nRO6tCQkDVZfeiXsSFOd0rrE+r8wpRf3Wgo1AElWkvD5ZA49hWgJI2m4KEf BKQctwd5S39b0LiYdjgzRfVPp0TkwrkXvymA8nfhKWbMl0Pe6FPn9+6BsugXVt136Bd5 2WYg== X-Gm-Message-State: AAQBX9e3xIhG5P8/WdNSpe/YQZyK09NP+yxYTir53jrZlVDikD23Ij7Z ja/AMMHwx3ZfpAkfSMDdTi7GMuZMKl29SCjbjTM= X-Google-Smtp-Source: AKy350ayIuKtHp+xriCBCLe2A9vtsfOcN27z9p7D3XxKQSyX5bNxVOE4laoGdxcWz8sFY3Nv6Djphg== X-Received: by 2002:a62:6346:0:b0:626:cc72:51a7 with SMTP id x67-20020a626346000000b00626cc7251a7mr22810371pfb.9.1680170174238; Thu, 30 Mar 2023 02:56:14 -0700 (PDT) Received: from chenghaoyang-low.c.googlers.com.com (112.157.221.35.bc.googleusercontent.com. [35.221.157.112]) by smtp.gmail.com with ESMTPSA id 14-20020aa7914e000000b005e099d7c30bsm24422752pfi.205.2023.03.30.02.56.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Mar 2023 02:56:13 -0700 (PDT) X-Google-Original-From: Harvey Yang To: libcamera-devel@lists.libcamera.org Date: Thu, 30 Mar 2023 09:56:08 +0000 Message-Id: <20230330095609.3341579-1-chenghaoyang@google.com> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v1 0/1] utils:ipc: Update mojo X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Harvey Yang via libcamera-devel From: Cheng-Hao Yang Reply-To: Harvey Yang Cc: Harvey Yang Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The chromiumos builder for soraka-libcamera has been failing due to the updated mojo generated files: ``` ... File "/build/soraka-libcamera/tmp/portage/media-libs/libcamera-9999/work/libcamera-9999/utils/ipc/mojo/public/tools/mojom/mojom/g enerate/module.py", line 1458, in Load result = pickle.load(f) AttributeError: Can't get attribute 'ValueKind' on ``` After running the script `update-mojo.sh` with the tot chromium repo, the issue is fixed. Please take a look. Thanks! BR, Harvey Harvey Yang (1): utils: ipc: Update mojo utils/ipc/mojo/README | 2 +- utils/ipc/mojo/public/LICENSE | 2 +- utils/ipc/mojo/public/tools/BUILD.gn | 8 +- utils/ipc/mojo/public/tools/bindings/BUILD.gn | 34 +- .../ipc/mojo/public/tools/bindings/README.md | 148 ++- .../public/tools/bindings/checks/__init__.py | 0 .../bindings/checks/mojom_attributes_check.py | 168 ++++ .../checks/mojom_attributes_check_unittest.py | 186 ++++ .../checks/mojom_definitions_check.py | 34 + .../checks/mojom_restrictions_check.py | 102 +++ .../mojom_restrictions_checks_unittest.py | 254 ++++++ .../tools/bindings/concatenate-files.py | 5 +- ...concatenate_and_replace_closure_exports.py | 8 +- .../tools/bindings/gen_data_files_list.py | 2 +- .../tools/bindings/generate_type_mappings.py | 3 +- .../tools/bindings/minify_with_terser.py | 47 + .../ipc/mojo/public/tools/bindings/mojom.gni | 860 ++++++++++-------- .../bindings/mojom_bindings_generator.py | 62 +- .../mojom_bindings_generator_unittest.py | 6 +- .../tools/bindings/validate_typemap_config.py | 4 +- utils/ipc/mojo/public/tools/mojom/BUILD.gn | 17 + .../mojom/check_stable_mojom_compatibility.py | 46 +- ...eck_stable_mojom_compatibility_unittest.py | 87 +- .../mojo/public/tools/mojom/const_unittest.py | 2 +- .../mojo/public/tools/mojom/enum_unittest.py | 30 +- .../mojo/public/tools/mojom/mojom/BUILD.gn | 3 +- .../mojo/public/tools/mojom/mojom/error.py | 2 +- .../mojo/public/tools/mojom/mojom/fileutil.py | 2 +- .../tools/mojom/mojom/fileutil_unittest.py | 2 +- .../tools/mojom/mojom/generate/check.py | 26 + .../tools/mojom/mojom/generate/generator.py | 8 +- .../mojom/generate/generator_unittest.py | 2 +- .../tools/mojom/mojom/generate/module.py | 649 ++++++++----- .../mojom/mojom/generate/module_unittest.py | 2 +- .../public/tools/mojom/mojom/generate/pack.py | 125 ++- .../mojom/mojom/generate/pack_unittest.py | 2 +- .../mojom/mojom/generate/template_expander.py | 2 +- .../tools/mojom/mojom/generate/translate.py | 408 ++++++++- .../mojom/generate/translate_unittest.py | 39 +- .../public/tools/mojom/mojom/parse/ast.py | 117 +-- .../tools/mojom/mojom/parse/ast_unittest.py | 6 +- .../mojom/mojom/parse/conditional_features.py | 14 +- .../parse/conditional_features_unittest.py | 130 ++- .../public/tools/mojom/mojom/parse/lexer.py | 6 +- .../tools/mojom/mojom/parse/lexer_unittest.py | 3 +- .../public/tools/mojom/mojom/parse/parser.py | 24 +- .../mojom/mojom/parse/parser_unittest.py | 34 +- .../mojo/public/tools/mojom/mojom_parser.py | 119 ++- .../tools/mojom/mojom_parser_test_case.py | 4 +- .../tools/mojom/mojom_parser_unittest.py | 31 +- .../tools/mojom/stable_attribute_unittest.py | 2 +- .../mojo/public/tools/mojom/union_unittest.py | 44 + .../mojom/version_compatibility_unittest.py | 66 +- .../public/tools/run_all_python_unittests.py | 8 +- utils/ipc/tools/README | 2 +- utils/ipc/tools/diagnosis/crbug_1001171.py | 2 +- 56 files changed, 3061 insertions(+), 940 deletions(-) create mode 100644 utils/ipc/mojo/public/tools/bindings/checks/__init__.py create mode 100644 utils/ipc/mojo/public/tools/bindings/checks/mojom_attributes_check.py create mode 100644 utils/ipc/mojo/public/tools/bindings/checks/mojom_attributes_check_unittest.py create mode 100644 utils/ipc/mojo/public/tools/bindings/checks/mojom_definitions_check.py create mode 100644 utils/ipc/mojo/public/tools/bindings/checks/mojom_restrictions_check.py create mode 100644 utils/ipc/mojo/public/tools/bindings/checks/mojom_restrictions_checks_unittest.py create mode 100755 utils/ipc/mojo/public/tools/bindings/minify_with_terser.py create mode 100644 utils/ipc/mojo/public/tools/mojom/BUILD.gn create mode 100644 utils/ipc/mojo/public/tools/mojom/mojom/generate/check.py create mode 100644 utils/ipc/mojo/public/tools/mojom/union_unittest.py