From patchwork Mon Mar 27 09:34:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 18464 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id DA3C3C0F2A for ; Mon, 27 Mar 2023 09:34:45 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3C91E626DB; Mon, 27 Mar 2023 11:34:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1679909685; bh=eV+R/tqBxLNAHfNBvpOkUUV0b6oVb3kJeXv9HAyxuIw=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=M0XR/4b1eBPffsyL/muGMtv0ygxVRVU/PjhJAQ5Y5eVmnz3vC393wBRWXCrGFqGcj zbQnKQpb8X57999maPAPlkcPObaeG+vOf8DJFIKA3V1ZIx/4uGUkjPU7KAxTiXYHPd NFRxSrVNrEbuL3SrxocK9E/tmqaAixHq7H+fyJgsXVoLomZKVRjklvxtWwut80ZSa1 OTVc8YpmZoX5LZs4WpldQildkIQWgU9DX3Jcqauqe7fhD7kozu+o7vMwsXuqjkO3hB KXT/8Z+Hk05p8sbiq0r2ikMEy3fifoTePwCUmWmeX9A7bqUDsJqCrKz5FDDkifNRAs k7Ekcu9MGS7sg== Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C46EB626DB for ; Mon, 27 Mar 2023 11:34:42 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="Ykolt2uA"; dkim-atps=neutral Received: by mail-io1-xd2f.google.com with SMTP id e13so3630203ioc.0 for ; Mon, 27 Mar 2023 02:34:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1679909681; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=d2dsPgdmbIUyl0w7/D9TXlrlafjcnly8fiyHn7hLzY4=; b=Ykolt2uAzsXh/2OKT2k26Tgo0jZAvR11r+lpXcBo2GqVHf9NxmP2tekyrGgsU/J3nP ZsSci0Tcws3yyIRJNJhtzRltmTwgiIZ00F5zZCy2wufak8m69zTISegcVicAC9I62Bvz E7jbOwCXt8OCjyA+CGI8aX/JK7hW6StN7U4nlx+A5CgZke/kaBCd7nOuyZx7NEotSNPc +S5ES8cQfBMBnmDz1WPrxexrREXul7Rm92gRs961GhWlle+REqCRa3Fs5OhNWPnBx6rM WYgsZ9Y9A8RrsuyS10Nh/bkwOSj3g7xyV2w9l6SZ195zNUixbEtzHw4mzP5cm2jUTjQS GKgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679909681; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d2dsPgdmbIUyl0w7/D9TXlrlafjcnly8fiyHn7hLzY4=; b=3stI7DHSPNpKPoZIhShf7bAecP7JsdVMpLpSHkA3qhMqn46LmnswJr7dAKRukCqivY otqmfcA3NL4uT+9V9fPWhSiSAxIfz3dyg6Lx/ahFL/bujZSHPQlrOCFLkeEwDzIKciFS ZF5pMWyqsKM/HkOuouURroyKK43sokTrkjtGsAo0BWsEWNDnoMHU0FHlPexeKuYIenCi vpeXdORaK7uilKGvFFh1TVNiq4PluxPW/FP8ZclsB/wuVYa7ZK0FMqdq9XvRX5Ek8ZqL 2oDFoLv+zS7jxa/l2QQqKXJ5Hkp59FR/XWXUCMMokZUblzJftt+0j0uVcBaX8fKvWQAu Rrbw== X-Gm-Message-State: AO0yUKU2DK+YPOZkkmRGE4Zjx+2PxeVA7GIb9fkRIHH9DPIubJU9EaoX 9EXGrOi7ahhjwn3yDrRLrVUt/fC0+hNc9ecsC4G35w== X-Google-Smtp-Source: AK7set9ZWCvVStGyVUb4ovkWwv2pJElOanTgBQco+l/mIGpdRPxCfKooFd1WwduYGVT581AVOYdcxQ== X-Received: by 2002:a5d:9e53:0:b0:753:568:358e with SMTP id i19-20020a5d9e53000000b007530568358emr8647847ioi.20.1679909681393; Mon, 27 Mar 2023 02:34:41 -0700 (PDT) Received: from localhost.localdomain ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id d12-20020a056602328c00b0075464a69c10sm7658345ioz.10.2023.03.27.02.34.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 02:34:41 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Mon, 27 Mar 2023 10:34:35 +0100 Message-Id: <20230327093439.24670-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/4] Raspberry Pi: Sensor limits X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Naushir Patuck via libcamera-devel From: Naushir Patuck Reply-To: Naushir Patuck Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, Version 2 of this series is significantly different from version 1. Specifically, on Jacopo's suggestion, I've moved the sensor limit fields into the CameraMode structure. This made the code changes less obtrusive overall. Note that the AgcAlgorithm::setMaxShutter remains now as this is passed the "current frame duration based" limits, as the mode structure stores the sensor mode limits. Regards, Naush Naushir Patuck (4): ipa: raspberrypi: Add sensor mode limits to CameraMode ipa: raspberrypi: Use the new sensor limits fields in CameraMode ipa: raspberrypi: Ensure shutter speed and gain are clipped in the AGC ipa: raspberrypi: Fix default frame durations calculation src/ipa/raspberrypi/controller/camera_mode.h | 10 +++- src/ipa/raspberrypi/controller/rpi/agc.cpp | 55 ++++++++++++++----- src/ipa/raspberrypi/controller/rpi/agc.h | 4 +- src/ipa/raspberrypi/raspberrypi.cpp | 57 ++++++++++---------- 4 files changed, 83 insertions(+), 43 deletions(-)