From patchwork Tue Mar 7 10:30:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 18346 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 3FA37BDE17 for ; Tue, 7 Mar 2023 10:30:22 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id AA81F626BB; Tue, 7 Mar 2023 11:30:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1678185021; bh=t9Tc0jBKhK/ElI5LIQii/4IVC4JYm6g0B3hXxaaOVp4=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=nbkYw4YsQ55ZWB4HyqHBpFf7AinjMg3w51LW1iCq8ivEIur00O7rPkA/hUknxVfdp Lox6FfVb7b4lxNKG7gkFKbvVOphP1Ka9u0BlEj0zlpQCzWCmKNvfSTnAMM4tFaEi1r BeFA9ncskKmNWelH55tr4ofEYEq23lXCDX0NsNbfNAwSt2+1AqnhAbRv7zmyrpxNrI G9rYMc6LZXbMzWe9Hhtav7w1Zby9DG0BQKGsoPHD5jgPr/HtI5stt/hMiIH/mvhCrf NfOdGQwraSYdB3QD6BeVJoj5VgNhBe0xAzfucf8GhWPS+yLicbvL5/uKzrrdm2qRlR nMUUt8tu+vYMw== Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6C2366266A for ; Tue, 7 Mar 2023 11:30:19 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="WPBbiE1V"; dkim-atps=neutral Received: by mail-wm1-x32c.google.com with SMTP id j3so7431605wms.2 for ; Tue, 07 Mar 2023 02:30:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1678185019; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VqMOjZYfoUsxh/OZyvstoy6o4xhfdtmzgLofSSrB4vM=; b=WPBbiE1VTJbpwk22Hjc3qFfRLwkK6wdv8t1iZzsAXZA8txD4kXg/TvaAilBqtQLCQB 0tpp9xZJIyeqNMCreFT/nzDK/4CkEX6RDy1kIO6kts+wU2hQH0apg48eNFbNkNDcFBMX 3xA67qhYeix+sVtxNyHejXh+PgMWzH91E/58qBS6ZqHonVEp9ofUFuoI2VnjTI3ZNG5U ZANexo/rxAcLT7b4ZyUOtcZTOcfuVrJm8L9dVAK/fxWr3XAKTScceMYxsC1qCSh6NmZz ySY55m5ktWhsvYLPU3X7ljodyBgLxT1ou8T5LUPX6ZaroH65RhPm7SS2Tj9yWhdSTRWx NXVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678185019; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VqMOjZYfoUsxh/OZyvstoy6o4xhfdtmzgLofSSrB4vM=; b=5sf/zlD+M5EoOJlaivd5h0oEBe/lHkr6XL3LSWLCxBwBe0lMsiFFDmgtz7Dxajxgpr LRyoR35W+kcFCHW8EmQYYwLtnnPrTRJSDacqza7PJ1sM8+cGz9/c8FOKitrDSG5y4qda F+DzmVcwq7DR91EyFZxxRuubw5E51gnCZ0zvQezkSiaNsA1TkYYJ0qcz2FIJc5IedBUl WLuFwTJqmrOMQRHsEX8rOiYbljGHY2oxkBVlcKoJY9QIUxsXeCQgu9oLf21OuG1kA4b/ /hPuTZaURwobzaPxRhp6czyuwRPArtktQw7h72DcOanU70PVzDmR4N5ovvTvxy0UcpGh bO/w== X-Gm-Message-State: AO0yUKX3a/R4EB1+8g4s2Gx61/tMBoaKD2aCJhjaPGVuFY8vH8Lwz/Go agi3wIdx986ZHF6mHRAnihf7sY13c/rdykPdTEQRVA== X-Google-Smtp-Source: AK7set+AMgF/ewtq3qfLAlW3mg2N2oRI8Cvs/ROz9edXg2XkNRPT3nHzurqNffRf1tJASLOfddvvDQ== X-Received: by 2002:a05:600c:3548:b0:3dc:5390:6499 with SMTP id i8-20020a05600c354800b003dc53906499mr12853854wmq.1.1678185018771; Tue, 07 Mar 2023 02:30:18 -0800 (PST) Received: from localhost.localdomain ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id r1-20020a056000014100b002c5534db60bsm12523621wrx.71.2023.03.07.02.30.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 02:30:18 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Tue, 7 Mar 2023 10:30:20 +0000 Message-Id: <20230307103023.3932-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/3] Raspberry Pi: Improving camera timeouts X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Naushir Patuck via libcamera-devel From: Naushir Patuck Reply-To: Naushir Patuck Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, Version 3 of this series has minor changes to address Laurent's review comments. Aparat from the typo fixes, we change the following: - In patch 2/3 we reset lastTimeout_ with the rest of the queue state. - In patch 3/3 disconnect the correct(!) signal. Regards, Naush Naushir Patuck (3): pipeline: ipa: raspberrypi: Change Unicam timeout handling ipa: raspberrypi: Better heuristics for calculating Unicam timeout pipeline: raspberrypi: Add a Unicam timeout override config options include/libcamera/ipa/raspberrypi.mojom | 2 +- src/ipa/raspberrypi/raspberrypi.cpp | 45 +++++++++++++++++-- .../pipeline/raspberrypi/data/example.yaml | 11 ++++- .../pipeline/raspberrypi/raspberrypi.cpp | 38 ++++++++++++---- 4 files changed, 83 insertions(+), 13 deletions(-)