From patchwork Sun Mar 5 23:06:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sophie Friedrich X-Patchwork-Id: 18340 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 9140DBE080 for ; Sun, 5 Mar 2023 23:06:52 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id BB5606267A; Mon, 6 Mar 2023 00:06:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1678057611; bh=JMDj3Ki654fMLqp0+npK52clEojWmhoFdupV/ZiTV24=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=FPcDpuKJRzfsmZOhcgl5CBMVQ4Oj+py3u6b1CSWGunBj4XYvpsCGbXWS3hzUQhixo z+Ghpay7ZU/mQV7J5MD/Tewb16g8yVZzK0mNzU9XTuKTWnA1TW+HCVAUmfA24iUhaq f0fUVQ6i3ot6KtpSvQeyo3DEEsMlOpdkpVousk+dfiALaQ129yfk2OCodAvVoKgClS oWX35M3WjkICxKZcGemOwI3/4QAv1wG55WQ2Rqa8Sl8c2XtAdOJHvsEEHclOYi40qC DuUfBdIt1uggNkIjQz3MljDQk8/eZzoWlsJ+cZyUXLmouRsjrMMGxi7FlT8mao+Kwb qEg3GcCx17l2w== Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 59C6061EE1 for ; Mon, 6 Mar 2023 00:06:49 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=flowerpot.me header.i=@flowerpot.me header.b="P6zz+H0a"; dkim-atps=neutral Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4PVHQZ5fPrz9sbg; Mon, 6 Mar 2023 00:06:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flowerpot.me; s=MBO0001; t=1678057606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=USrzZlVppTqPEhfXNbZA9UAF91HNCs7XERjoI13gt3k=; b=P6zz+H0aSqa1eGAGXrBEpAwrnh2y/h4oH6ygKHaUVxVMicl3gkqAh0f16eJeU/jr5QUBHI l8O5u68S4cnW5PHr1TYDWcVA/kVHRxWJxsChsgde1m+cpvLOmhVtLLHenLI2K6aIQPp1AN yjntnsFyfClrDTis1/ORRa+2VTd2Jc0jlUp6sFjK9+6AChPocaL22DOb1kzSFnXFWEMh5W 7dTmjo6TiiFAkblz5qvHR9bBXklPrY1JkUTPDy7+aBtkVFkrho/BhvVj08IGMlkPws1aDG 4c86uQoai1/cGrjCXE5p2fOj58v8IkoQneeoiEusr+t9C88EK9pdqz4sKS1Cxg== To: libcamera-devel@lists.libcamera.org Date: Mon, 6 Mar 2023 00:06:02 +0100 Message-Id: <20230305230603.3697024-1-dev@flowerpot.me> MIME-Version: 1.0 X-Rspamd-Queue-Id: 4PVHQZ5fPrz9sbg Subject: [libcamera-devel] [PATCH 0/1] fix: pipeline handlers: Stop exponential calls to `createPipelineHandlers` X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Sophie Friedrich via libcamera-devel From: Sophie Friedrich Reply-To: Sophie Friedrich Cc: Sophie Friedrich Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" While implementing the libusb enumeration through udev I noticed that createPipelineHandlers would be called exponentially often after each time I cycle plugged a usb device. As it turns out there seems to be a bug in the camera manager which would result in `createPipelineHandlers` to be called exponentially often after each emitted event on `devicesAdded`. I was able to reliable call the above mentioned function over a thousand times after hotplugging my device only 10 times. Sophie Friedrich (1): fix: pipeline handlers: Stop exponential explosive calls to createPipelineHandlers src/libcamera/camera_manager.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)