From patchwork Tue Feb 21 16:45:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 18289 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 56807BDCBF for ; Tue, 21 Feb 2023 16:45:23 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 95EEA6264A; Tue, 21 Feb 2023 17:45:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1676997922; bh=Vp2UCtISiEP6gpWdmM5+D4c1vjRIH5/iZS1oalkW1P0=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=u3rqdFDcl9fEwLr/Prl/NX1EguB9K2SIOo1JnRvZB1q9S/etH2cj7kS3nBx9JwFqv Xwn/kBHYTL7UesFwT4nwwRrjTKiBtn7dqlSUPv/kDopFhRhBeLzReDk/r9QiPDxfxe Dljjffu9TxfoHH9IL9N0/lxliVasAUNAdj3qgzkgtg0KRNGnkQ+/0cqlkldEzL7Lhz 35B9yenDdrLn9k2c5wn+kp+UKTb4g1iQrDsDyLZMiE6rdBA4E1NkiWBWwrPK4LCNTw GJO3TTfVLh3cenrLYxl9B39fB41lLbAYt43fioUl0WjLWbf0ECVuo3JCW/2QOaBZj2 AdMGX46NuTsxw== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2569562636 for ; Tue, 21 Feb 2023 17:45:21 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="aKZgz7fc"; dkim-atps=neutral Received: from uno.homenet.telecomitalia.it (host-87-16-53-160.retail.telecomitalia.it [87.16.53.160]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 588E3519; Tue, 21 Feb 2023 17:45:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1676997920; bh=Vp2UCtISiEP6gpWdmM5+D4c1vjRIH5/iZS1oalkW1P0=; h=From:To:Cc:Subject:Date:From; b=aKZgz7fcAJLdQcjkc07iqzrK7ayJL3B0SVGAwdGRQa0ZifhN/AcxUdj23KZReTNy0 Y1gIft5aC2pJV5zc6Ezqn2XRfRIPe8X2Um9+HTRHxnJZYLtFdpp4oll3myzc6ILI1q kutiPYeSNPp6MThq2fktLtJctdcnQ3QBG4nRQX64= To: libcamera-devel@lists.libcamera.org Date: Tue, 21 Feb 2023 17:45:01 +0100 Message-Id: <20230221164504.120738-1-jacopo.mondi@ideasonboard.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/3] libcamera: rkisp1: Fix generateConfiguration X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jacopo Mondi via libcamera-devel From: Jacopo Mondi Reply-To: Jacopo Mondi Cc: Jacopo Mondi , libcamera@luigi311.com Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The series started with bug 180: https://bugs.libcamera.org/show_bug.cgi?id=180 which reports how using the self-path for generating a configuration for a single stream results in only StreamFormats up to 1920x1920 to be produced. I have then noticed how the current implementation of RkISP1Path::generateConfiguration() could produce unusual sizes, such as 1920x1432 in case the sensor's resolution is larger than the maximum supported 1920x1920 output. Finally, if StillCapture is requested, make sure it is assigned to the main path in RkISP1::generateConfiguration() to make sure it can produce images in full resolution. Tested on Pinephone Pro with imx258 camera. Jacopo Mondi (3): libcamera: rkisp1: Generate config using main path libcamera: rkisp1: Assign sizes to roles libcamera: rkisp1: Reserve main path for StillCapture src/libcamera/pipeline/rkisp1/rkisp1.cpp | 36 +++++++++++++------ src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 11 +++--- src/libcamera/pipeline/rkisp1/rkisp1_path.h | 1 + 3 files changed, 33 insertions(+), 15 deletions(-) --- 2.39.0