From patchwork Thu Jan 26 13:45:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 18197 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1DCD7BDC71 for ; Thu, 26 Jan 2023 13:46:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3DC3D625DF; Thu, 26 Jan 2023 14:46:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1674740766; bh=RLSropwDLbdONvamjP/7KGDp2u+kYQXaZMVz3WrVoMs=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=cGB37tbZrUxR9isWEEo8C0HrJU1ziD7eo/9hzVjRVjzwhkRq9lslWEiw1z67K+3Dr 5ENYABpvRKt+eptL5wm9cH1SAftZKIJsLopbL4lolg6y9bKW3On+Ty9EiN4f7fz660 owgF63dztbebUx1veGXW4HhCMxtbiVm2tXsFmvw5szpt7L5voqduytXBJapVvVqhgT b4rQxAr70OA9MFmvss9gsYoNzS/OKlSSvEYLC4dECKHDAQRU79c/Gi9f8TweZhnN5a EYIblBXm4v8/1t1TXS36jFU7rVf2boPL9FeQqrd8J6WpUh8VM7cerRQiwVMcgRIDYg U9YEtOIqZtrFQ== Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1721161EFB for ; Thu, 26 Jan 2023 14:46:04 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="XFBscoEt"; dkim-atps=neutral Received: by mail-wm1-x32e.google.com with SMTP id q10-20020a1cf30a000000b003db0edfdb74so3979600wmq.1 for ; Thu, 26 Jan 2023 05:46:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=o3jr7hJw1JnJSausLSQGjZ7fIMRjEbbFUFOpy9X6qSM=; b=XFBscoEt9TONH0u+G6D3A8Vz0X6d2gSfmASoNLwhlhKLMnTTAaW5vGbpOoGIBupVbz isY/fDQ902ZNoWv0svfPCRwQWhZVK4gCL9pVKU2K0Cj5aEN1gtDY57WTAvNzirfSAglM RRS5WLi3MVECIVNxoB9lkzcUvUYCkx26OsIqhrF2P+KonCdmiMgtPjrvZkd1w/0Z9udT xFA1itzxwS8Cl1GMKY7dkvB+xaI5Z4ZF8eLx3T3N2UROnD6Usxaa7gc8c2obIgTlIw6d ULTu7ajaqEGLWZbf2K9rQ/LPfB4gZeN/nwwF59T1MTqfuMvBS8zOHAyF2Wqmomd0jWSX 8j6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=o3jr7hJw1JnJSausLSQGjZ7fIMRjEbbFUFOpy9X6qSM=; b=bUNY+YbURbE+/XHVrnwikxSh1dQiRGTAmsug40rDfi6pqeXbab2Kiqu9/yN5WH8ebR 03j7lNpXxtS7vnYzMvHHYZAoek8nSuqWx90AgSmeRsCk95Hz7Ft2eycC4BcBdalyIchs 0vSy4cQHGTkk/CdjLhbGdY3w6CbCU1CktfVhufRQwKw+T1ptB5xnFc93hntYtvirR/eW prgwkXPxfHhR02xz2s0x/l80/fjVPSJ8fVZApP3B/CvQYgvGSwiZBg7C5w2E4fA6GSpi 352lpmGbcVRBt0PSpYTpwgYzQnPY2LasFhOhNmRovqTvt8CXKnsPKdYzinvxKgEyMxv+ rufw== X-Gm-Message-State: AFqh2kqjsxaExSWOe+ji4Jel/ixofU4VLAECoqw/fjZiz/W0AJlhOFAw /6iiz0QXrmTXRYb34y26+/I3Z7y5V7m6fE7i X-Google-Smtp-Source: AMrXdXvcEuLBtSwDHMGabA1tNx8cWyVPStTKAkNpiN6d2ydCPmNdQWlHF1K16hyJNaN8rajIaUlNGQ== X-Received: by 2002:a05:600c:4f42:b0:3db:2e62:1d69 with SMTP id m2-20020a05600c4f4200b003db2e621d69mr25196520wmq.31.1674740763299; Thu, 26 Jan 2023 05:46:03 -0800 (PST) Received: from pi4-davidp.pitowers.org ([2a00:1098:3142:14:e4a2:3070:eea4:e434]) by smtp.gmail.com with ESMTPSA id m2-20020a056000180200b002bfb5618ee7sm1370567wrh.91.2023.01.26.05.46.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 05:46:02 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Thu, 26 Jan 2023 13:45:57 +0000 Message-Id: <20230126134559.3323-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/2] Add flicker avoidance controls X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Plowman via libcamera-devel From: David Plowman Reply-To: David Plowman Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi v2 contains a second patch which actually implements the necessary functionality in the RPi PH. The significant code has been in the AEC/AGC algo all along, so there's only a bit of plumbing to do. The first patch (which was the original one I posted) has had a couple of small mods. The 50Hz and 60Hz modes have been renamed to Freq50Hz and Freq60Hz, because names that start with numbers don't play nicely with Python. Please suggest other names if you don't like those! I also noticed an existing control called SceneFlicker which I hadn't spotted previously. I've deleted that one because I thought they were duplicates; the new one has more features. But if we preferred that name we could perhaps rename the new ones to SceneFlickerMode and SceneFlickerPeriod? Opinions welcome! Thanks David David Plowman (2): libcamera: controls: Add controls for AEC/AGC flicker avoidance ipa: raspberrypi: Handle AEC/AGC flicker controls src/ipa/raspberrypi/raspberrypi.cpp | 80 +++++++++++++++++++++++++++++ src/libcamera/control_ids.yaml | 69 +++++++++++++++++++------ 2 files changed, 132 insertions(+), 17 deletions(-)