From patchwork Mon Jan 16 00:28:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 18117 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CFC16BD87C for ; Mon, 16 Jan 2023 00:28:10 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 14767625D8; Mon, 16 Jan 2023 01:28:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1673828890; bh=zmck68BBi0tjwKKuZsAvhs+IXirm/XJJuydgKrGYsnI=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=Bn4AXzBh6Hd0/zGgjzF8lfHd1VPC8nHquQmbcaLKFcGcTZ7CTmP8aGWUcvA7FH6AF Ag+dw5A5p5cF++FcghF8uGxnl9P+l1PcboKgpv3aUxJ9Z00hWexeJ2OFL58qccWV1q Vs/QqUPJOtV2is1CyngHzW9+Zx5zkFUxIDUvpmBtNQ6oeBmX9NeJgpu15ms4nq7Kq8 aPRx9nZyAUdvfeVj5bPVByuOmUOaMWgYNHPGnwLPdYrHPIM2I5Mvs1smk1aScUdGXL WY7QOAmqt04NpAG1J884MIlCA13xfJJrn3bzQuEsQ4ATTlYdqiZMaKh0d1Osz8om7f NkY4e8dX2b8zQ== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D8B1F625D0 for ; Mon, 16 Jan 2023 01:28:08 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="v+gvd9Ks"; dkim-atps=neutral Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3BC70997; Mon, 16 Jan 2023 01:28:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1673828888; bh=zmck68BBi0tjwKKuZsAvhs+IXirm/XJJuydgKrGYsnI=; h=From:To:Cc:Subject:Date:From; b=v+gvd9KsbesZDUo0EJPTvwgzBD8UnmFVbfI1TjnVtqwUyHDaoSOABbsL7IkamSS+b 8cvw06FRPH6GWrSVAnRVqIVW/uQjwh6qqb05jtsp0Pm5UYmzwYA9fNFdAP9g0kAudl I8kflBFfDUqFEFH3InA8Dn2rZ0sQyJVPC2W+Qp0M= To: libcamera-devel@lists.libcamera.org Date: Mon, 16 Jan 2023 02:28:00 +0200 Message-Id: <20230116002808.16014-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.38.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v9 0/8] Add CrOS JEA implementation X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Cc: Harvey Yang Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, Here's a new version of Harvey's JEA series, with all the comments I've sent during review of v8 addressed. Up to the last patch in v8 I thought I would address all comments when applying, so I folded them in my tree, and it seemed a waste of effort to delete it all and let Harvey do the same. Compared to v8, I've also added patch 6/8 that returns an int error code from the generateThumbnail() function. Harvey, patch 8/8 may be ready, but I didn't add a Reviewed-by tag as I've asked a few questions in the review of v8. Depending on the answer, I could push v9 as-is. Your review of 6/8 would be appreciated (and feel free to push back if you don't think it's a good idea), as well as a test of the whole series to make sure I didn't break anything (I've only compile-tested this). Harvey Yang (7): libcamera: framebuffer: Allow inheritance of FrameBuffer android: framebuffer: Add HALFrameBuffer and replace FrameBuffer android: jpeg: Add meson.build in src/android/jpeg android: jpeg: Add an internal Encoder class in EncoderLibJpeg android: jpeg: Move generateThumbnail from PostProcessorJpeg to Encoder android: jpeg: Pass StreamBuffer to Encoder::encoder android: jpeg: Add JEA implementation Laurent Pinchart (1): android: jpeg: Return an error code from generateThumbnail() include/libcamera/framebuffer.h | 3 +- src/android/camera_device.cpp | 5 +- src/android/camera_device.h | 3 +- src/android/camera_request.h | 3 +- src/android/cros/camera3_hal.cpp | 4 +- src/android/cros_mojo_token.h | 12 ++ src/android/frame_buffer_allocator.h | 7 +- src/android/hal_framebuffer.cpp | 22 ++++ src/android/hal_framebuffer.h | 26 +++++ src/android/jpeg/encoder.h | 9 +- src/android/jpeg/encoder_jea.cpp | 103 +++++++++++++++++ src/android/jpeg/encoder_jea.h | 35 ++++++ src/android/jpeg/encoder_libjpeg.cpp | 108 ++++++++++++++---- src/android/jpeg/encoder_libjpeg.h | 46 +++++--- src/android/jpeg/meson.build | 17 +++ src/android/jpeg/post_processor_jpeg.cpp | 65 ++--------- src/android/jpeg/post_processor_jpeg.h | 10 +- src/android/meson.build | 6 +- .../mm/cros_frame_buffer_allocator.cpp | 9 +- .../mm/generic_frame_buffer_allocator.cpp | 11 +- 20 files changed, 385 insertions(+), 119 deletions(-) create mode 100644 src/android/cros_mojo_token.h create mode 100644 src/android/hal_framebuffer.cpp create mode 100644 src/android/hal_framebuffer.h create mode 100644 src/android/jpeg/encoder_jea.cpp create mode 100644 src/android/jpeg/encoder_jea.h create mode 100644 src/android/jpeg/meson.build base-commit: aed615e1730d17a3da77ea22d5af43440cc4d873