From patchwork Thu Dec 22 01:01:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 18047 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A749FC3213 for ; Thu, 22 Dec 2022 01:01:41 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D85CF633B3; Thu, 22 Dec 2022 02:01:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1671670900; bh=/r7K4JXKM4F5Uz6CgMt461zJIB9XqT51rUnhXe/COaQ=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=g1R80v9wvdAjSxIOcFHUgAV2SlDJbw9ZHcN6PPZhYtbdr2HXWq65G8xpFrmiimvve VZnmUuwrGwKHYFxHDulAQFSzOJrPfVWWD5A3mN7Qj1ZTGd/V8SmKCmPHTD/WZKsZoH ZIUgpLQhNEZGXpZvdDijnayGZes9gxaanRp6kQqmqPB0bJbD3kJc+cco8e1EaDCL5T LC+P2mMGaXR9UjpmxXpPQxX85Xnn0naxBI+tn0WBdnhOLxevaR4z2RbsKvyWbrwz6Z iI5TiYnQ8UQU4wFtJUg7QZD47Rls0FhKd69V//NMYwF8CUC53dtaGdM3WRV/j/zeZK O6lqzyNqleuBg== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A1DD863398 for ; Thu, 22 Dec 2022 02:01:38 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ReM8ldW5"; dkim-atps=neutral Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 01D3A471 for ; Thu, 22 Dec 2022 02:01:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1671670898; bh=/r7K4JXKM4F5Uz6CgMt461zJIB9XqT51rUnhXe/COaQ=; h=From:To:Subject:Date:From; b=ReM8ldW5vQzLfMk8ejDxsRvPDuq64xlibDSSihKy2F5bWpY/gZuXMxPY79H+Yx3qS 2pV8aLvZ0fgJQnruOcx4zylF2aNB3KZ/omLSX/aTF7B8I5ZokIbv3oR3xlGKLuSVd/ /iNYUubM2jFwtTd4DYxv8BFbPY60gjFotnZCQV8s= To: libcamera-devel@lists.libcamera.org Date: Thu, 22 Dec 2022 03:01:28 +0200 Message-Id: <20221222010132.22177-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.38.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v1 0/4] test: Various unit test cleanups X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, This patch series addresses two issues with unit tests: - The v4l2_compat test is skipped when ASan is enabled. This shrinks test coverage, and can be fixed without too much trouble (at least when compiling with gcc). This is addressed in patches 1/4 and 2/4. - The Python bindings test fails wehn ASan is enabled. This can also be fixed when using gcc. This is addressed in patch 3/4, which depends on 2/4. - The ipu3 and rkisp1 tests are never run in practice. Patch 4/4 drops them now that we have a better tool to test pipeline handlers (lc-compliance). With this series, I don't get any unit test failure in my compiler matrix anymore, which should have been the case for a long time. If anyone still experiences regular unit test failures, please report it. Laurent Pinchart (4): test: v4l2_compat: Reduce indentation test: v4l2_compat: Enable test with ASan test: py: Fix test failure when ASan is enabled test: Drop pipeline test test/meson.build | 17 ++- test/pipeline/ipu3/ipu3_pipeline_test.cpp | 126 ------------------ test/pipeline/ipu3/meson.build | 14 -- test/pipeline/meson.build | 4 - test/pipeline/rkisp1/meson.build | 14 -- test/pipeline/rkisp1/rkisp1_pipeline_test.cpp | 115 ---------------- test/py/meson.build | 17 ++- test/v4l2_compat/meson.build | 33 +++-- test/v4l2_compat/v4l2_compat_test.py | 18 ++- 9 files changed, 66 insertions(+), 292 deletions(-) delete mode 100644 test/pipeline/ipu3/ipu3_pipeline_test.cpp delete mode 100644 test/pipeline/ipu3/meson.build delete mode 100644 test/pipeline/meson.build delete mode 100644 test/pipeline/rkisp1/meson.build delete mode 100644 test/pipeline/rkisp1/rkisp1_pipeline_test.cpp base-commit: f66a5c447b65bce774a1bc2d01034f437bf764b5