From patchwork Wed Nov 23 11:36:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 17843 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id EA27EBDE6B for ; Wed, 23 Nov 2022 11:36:50 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 676776331B; Wed, 23 Nov 2022 12:36:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1669203410; bh=fjW53RK03nSAzQa5qF/jTSezE5AcbaovaMfETW/bEe4=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=BuCfXhtcjTcQVrgiVhw1Xn7QCtTIdLSPHoaLb5dovtBu2drp1zCLlACQ+nDoB1upJ eziAq05LwnAR3jnPTJkrZ/I87z0Ew0Vbtbn/TdVK91zODbcA3aCLNJP+wdYXMg1S58 2WfgipyYU3oNFQaFlsOgM3+f38OOaAoApaPdGzEVq0Yi8UDnt1JngvtlbjGrX03xLG cYziWGONl9mrtpic6jb9EhVxELSEVZuNuqrZRB7/VYTJZc9QQ+ZhQ5YvaQ2xDnGFIS dDWyC7etFtzmR0WJCPWvQyB/EqAxxLp7lkqGG9xV6TVSpbyQtfi1uwi9fbpRLw9l+l frQdwPdnV1VPg== Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 867C963311 for ; Wed, 23 Nov 2022 12:36:48 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="CrJ3RTQL"; dkim-atps=neutral Received: by mail-wm1-x329.google.com with SMTP id 83-20020a1c0256000000b003d03017c6efso539713wmc.4 for ; Wed, 23 Nov 2022 03:36:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=v/y/C6Lz61atGrFiOie5bEE80IBlQAz6kyrBJiYwKAc=; b=CrJ3RTQLGZHhG0kWPN4LHVKF+jh4cBIeMmJaFaX8I1RtRGXj8NhF/YUbh5nBsjOLn4 FiTrQvw4QOk4d4CqY5S9kmsY09ailO0wE0BSdSAJYp7PjjSS1nMxTjmoWPPbydkeQhrl qVH7eMtd1qXK21MKR5UxuR/YgZ56c10ERW6YcHGfguoInqP3Dzljf4MQhdjwJsI1tJ9q Da4ijG7HAu7g26b4fQEgm9po8I/wCYic5itNz5+brMZMbAzylUMHFw+50u05K9EHSiTr 1/y49XGCLPH9gcmyeR6EJ9U5Sj8qJGZQXL3Muj3rk7tkeIbPbFt3FgMsOwuYl6ISbsrZ HaYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v/y/C6Lz61atGrFiOie5bEE80IBlQAz6kyrBJiYwKAc=; b=YD9xtkdtXrQgrRr8y9ncHaJYB8D0CnyGrI7da96uFx0PzCvRN1ceeW2nMlOcQqChQ0 FZKgdp09Phbc4tAe+srXoeYci3cZYNjIuLkFAncUYs7AzcKEwoDOjudYQCzZY58S6uA8 pviOZ3lIwypOC85hICAeUGMBxvEjokfCKzmYNjxYXJ1I2R4F59HyWJC4wHtgEqbfuoYT SFMsxDhxT3FfreeJ9TFRpQpVWbgeggq9/yrMqxQL25MO7b8CUAybxdQZ8OPtl4Ov3nP2 MYwddmbbByt4DxTSe3B0fk0VK7d7Lkl1GMLOPHY/cLAIa+WUfnmFl0efb7/ihq95kJx6 DP8A== X-Gm-Message-State: ANoB5pkTPDk9vltd1A6hhog1TU9AYTy98l6th9XLOu/mSaokeqr+AVLN TSoRJWyk+nE2WP11RX7qdGuvW1hi+VD5eA== X-Google-Smtp-Source: AA0mqf6ztzqehyMezgL5tQyicy6hzT8Hzl5VL0DJY6l7NFCVf+OnXv9yo/D+BE8LMp4W9BDRUxWHJA== X-Received: by 2002:a05:600c:220b:b0:3cf:f747:71f with SMTP id z11-20020a05600c220b00b003cff747071fmr5874389wml.147.1669203407707; Wed, 23 Nov 2022 03:36:47 -0800 (PST) Received: from pi4-davidp.pitowers.org ([2a00:1098:3142:14:e4a2:3070:eea4:e434]) by smtp.gmail.com with ESMTPSA id m9-20020a05600c4f4900b003b95ed78275sm2203219wmq.20.2022.11.23.03.36.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 03:36:47 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Wed, 23 Nov 2022 11:36:43 +0000 Message-Id: <20221123113644.1778-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/1] Resolve invalid attempt to set sensor HBLANK control X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Plowman via libcamera-devel From: David Plowman Reply-To: David Plowman Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi everyone Here's another version of this, now adopting Jacopo's suggestion of resetting the HBLANK when we set the sensor format (thanks!). Does this work better for people? Thanks David David Plowman (1): libcamera: camera_sensor: Reset HBLANK when setting the format src/libcamera/camera_sensor.cpp | 53 ++++++++++++++++----------------- 1 file changed, 26 insertions(+), 27 deletions(-)