From patchwork Thu Nov 17 15:44:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 17809 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C5EA9BE08B for ; Thu, 17 Nov 2022 15:45:06 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3D4466309A; Thu, 17 Nov 2022 16:45:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1668699906; bh=6qvR2cqEa5z6VbqQaCva3AlGSV6g5aUOYlIZuePw9as=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=ORSLSASo4VgqMQhJ/r/PN5cjai8QyyCvBofFj6AvAYpO1OyuXhc80GX1wdsLVvKK1 zqnpl62sjmOrrNznB9LdCdGX4+fw/xHovkdoxfrLgXFIMiqohMF0oa415R6sy7bYTw Jnmg/9TLSEa/aEtmjLfptTZQbaHY65l2kALdTWGQWVIBcN0SGI9LZyp9ZsxHmpH51E 2/XErHwTT+qAvXd1Ej7g4XP+RMGSzSYcWCxy0MjVdKO1IucRARV89V+X3z51g+ZV2B Sq5GcoX/u1yue0aUoeOJKIzjPHu9wqC0HHhx9QPlhF+FfI8X65MGoRpKVfK0m8LDb9 I324asDItkrgg== Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B09AA61F31 for ; Thu, 17 Nov 2022 16:45:04 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="qsQHbMEn"; dkim-atps=neutral Received: by mail-wm1-x32b.google.com with SMTP id 5so1676427wmo.1 for ; Thu, 17 Nov 2022 07:45:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Fx9UkNMjFiRAvjvY0HHIORZYtZxJZMs20iSYQ893Z2w=; b=qsQHbMEniqjdWYoOl4sR85vd+XwP8lzdhQIBWAxATwyXn6PF6qIb9kfuJ1IyblOdm1 setIr6PSPvnvqXXV1mBnmdURuZNsM18MPh4YNw1+3LD8fhVfoLQROLBvUZJvpxzRSa/m JT+vZq7zavHnJu0H/voGfdatDcV/5j+tqUa1UMBEUFpTP0LkmlahLXYkrATbSernk5/4 u36Uix02dXNw2NAwBRHMF7zYXVYyExb1q5KsYgkq65cZDdnjWbRso2p/KSrAKoUl3Ob2 0h07wsHfVy1aU9fwlkdexq2Dwo0ksl9J/QWoBTMD51Qj2Fc/KykhYuOAcEu6M0s4WbN8 upbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Fx9UkNMjFiRAvjvY0HHIORZYtZxJZMs20iSYQ893Z2w=; b=kWRDN9Hy/SD4arYInmH0pOIu1cqE3GwfALkn3rfaR2d+qT2K/f3iYmxAU3/LO2XqTZ 5NtaRw3jpzGe2gzX5uWmZdtQ0o6iWrI8/g7F0/849JymTaYUZuPYI0c+ux3zPefOqBsB LCph6DoB2oLT2pGxiwBQGMIy2YYijIFaojq9fOuMMys+aA65EJrTKlKlOavrhQv3g+sG k8ZmSdw2KT2zh9tJmv+soHHBwJRQzJKUysii9zRZ80ttr3GCti5lf9wcnULy0xjFgLjJ IdgP+43mWaTN0BnQtFk0CqGCY+RMA+GSSbpD9Z01TDG2TsoiCBJZ1MOMXTjB/V9ITDu2 5ZhA== X-Gm-Message-State: ANoB5pl2xsDM7HRopYssSp/f2VPFB7As7KOD+72zJFc0kcC4IFYWonrX vFYdPV109A8sbgoPEAHugHUwJkax/FAaNw== X-Google-Smtp-Source: AA0mqf4qTiKV/vF7+VOoqjx2Y14spUxde2xaQ5EdHkPa1bBt33pi2CRYILsRusTJDVdJDc7W09hZAg== X-Received: by 2002:a7b:cbc6:0:b0:3c6:b650:34dd with SMTP id n6-20020a7bcbc6000000b003c6b65034ddmr2179969wmi.45.1668699903897; Thu, 17 Nov 2022 07:45:03 -0800 (PST) Received: from pi4-davidp.pitowers.org ([2a00:1098:3142:14:e4a2:3070:eea4:e434]) by smtp.gmail.com with ESMTPSA id e21-20020a05600c219500b003cf894dbc4fsm1606687wme.25.2022.11.17.07.45.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 07:45:03 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Thu, 17 Nov 2022 15:44:59 +0000 Message-Id: <20221117154500.8829-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/1] Change LensPosition units to dioptres X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Plowman via libcamera-devel From: David Plowman Reply-To: David Plowman Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi everyone Only a small patch, but probably warrants a note! We've been mulling things over for quite a while and have come to the opinion that we'd rather have the LensPosition control use dioptres as units (1 / distance in metres) rather than "1 / hyperfocal distance". The reasons are that it's a completely defined quantity (no ambiguity about where hyperfocal is) which probably makes it a better fundamental unit. Also it matches Android better! Moreover, I'm thinking that there's still not so much use of this in libcamera that changing it will cause trouble. In fact, many of the small modules we use probably have a hyperfocal distance not that far from 1m, so there wouldn't even be a large difference. I was not so keen on dioptres previously because I wasn't sure how we would find out where the hyperfocal distance was (which is often the thing you really want to know). But we've resolved that we will be able to read a good default position from the control info. How do other folks feel about this, does it seem like a reasonable change to make? Thanks! David David Plowman (1): libcamera: controls: Change LensPosition units to dioptres src/libcamera/control_ids.yaml | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-)