From patchwork Tue Nov 15 09:07:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 17792 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 94F47BE08B for ; Tue, 15 Nov 2022 09:08:02 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id BB1A663088; Tue, 15 Nov 2022 10:08:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1668503281; bh=OLMaFQ9BekaHJLLNAwlwYs0Lx8QkzgcXA7eZGrB3SH4=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=dWbOQ3Jmtw9fpAN+ZpnvUJ0iLlv9sFZlrNQSoPzgrV7ynXAKd+2pTUhvVxB64A3sL D7QJTM9BRPbk6RPJU3zn5GqFZ5hXuL+hk3LRWSB6EGq1sdHQN7IO2ziKrrHxxKZsjw GVXMR4Yxj+c5ZLI95zlQX47+jgpsd+yPRGUnpssHT4qhetRui4RsZUPELkbMjjYf0i j6ObV4oQgO8uMjJerC8xyqo6/fZtZEiq8QZvmjyGixZR2y0D7xvLwp44dlGm1LfARi rOykTHiAiUEk2XfV869IBq/Ab6jHFKhHamYcmJTjDvBErjaSzd5szo/BipRLuwOqRq ifDTEnxDdD61w== Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BCEC063079 for ; Tue, 15 Nov 2022 10:08:00 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="MqLD7W3S"; dkim-atps=neutral Received: by mail-wr1-x42c.google.com with SMTP id j15so23120577wrq.3 for ; Tue, 15 Nov 2022 01:08:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=t9eHv1Ek4X8ed5Lh3uRN5n10+5re6sS15Jxza6TdNbQ=; b=MqLD7W3SbPg/uTyJUmWgP445JB8DCV1VkhojREBKigZQmtpCb2N8c5dU0pzwhmIph8 FkEm+jDZJmo+G2X8BaTQctR1rC49FsSdYqXF44phUzGRJFpvggHLLeMBY+zvMY0tYks+ dyhe63Hbr0+oy0kY0eB4mIppjm68+/uDBkKsD62n36R6RsauU2mXemJz351Dn9dOcs0I cPP3n1aPZbZSstpbKOuB7WPpSmSv2r9JvLgJxmQjcusSfaCjaNLwG3K2FSqSpGI0Vre3 dkMhH7MZ5/JiZPkR2wthTS7RMb+lQZbvhKwsHsfWjjLvzaDLqPRHSmiQzKYa5EDIoZtU T4Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=t9eHv1Ek4X8ed5Lh3uRN5n10+5re6sS15Jxza6TdNbQ=; b=sZ3AEWUGRY1Kwx9fR9ktT4VCF1hqXdxgS4IXymL2sVpzDAvrVPEVtEOqkDpg3fPF4E cczARRZz6dazLga/RIRv6g/OXfFvhoeFD8rXsaMAx5SoHHYzvNyf55LSUsACwbm5WFi/ cY8smd0Sldd6IKBX8KNsov/LOMYhhOIkCr3XFbDG1j+rZir1517kRb9xU8/JL8ZIDKmP QlabedGuhQyTkCEffG58cMWDtWz4LCQEtQ7bGaEhtAQdfMhtfQKWgNA0vNwQn9+jU2j2 51Q+1YcMI5RWB4jFs5YtQ+LCSLvHuLbZpsARkA4bj6D5lbc0xlt6bvrdtcwlB2/AO/TZ AJGA== X-Gm-Message-State: ANoB5plADqx9mtNSEtBebCctY9TPlW9zYCuu+XNcS3EeOEyI/wDF6n7N lVqprwONW7DM75K/rhq+F/YLexlufDVU1Q== X-Google-Smtp-Source: AA0mqf5+fAMIHIfQj+jGNoNMrtmDznSDmoGJtlesg85UBbJiT5AS9NNphga9+XTbchXsPGU/bEGfJQ== X-Received: by 2002:adf:dcca:0:b0:22c:95bc:c70e with SMTP id x10-20020adfdcca000000b0022c95bcc70emr9669541wrm.248.1668503280106; Tue, 15 Nov 2022 01:08:00 -0800 (PST) Received: from naush-laptop.localdomain ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id p25-20020a05600c1d9900b003c64c186206sm15143696wms.16.2022.11.15.01.07.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 01:07:59 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Tue, 15 Nov 2022 09:07:47 +0000 Message-Id: <20221115090755.2921-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v6 0/8] Raspberry Pi AGC digital gain fixes X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Naushir Patuck via libcamera-devel From: Naushir Patuck Reply-To: Naushir Patuck Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, Version 6 of this series forks DelayedControls into the Raspberry Pi pipeline handler namespace, patches 1 and 2 cover this. Patches 3 and 4 update the forked DelayedControls class to add the user cookie with the same set of changes as were in DelayedControls in version 5 of this series. I've removed all the existing review tags from these two patches to give folks another chance to validate the changes. Thanks, Naush Naushir Patuck (8): pipeline: raspberrypi: Fork DelayedControls pipeline: raspberrypi: Switch to RPi::DelayedControls pipeline: raspberrypi: delayed_controls: Template the ControlRingBuffer class pipeline: raspberrypi: delayed_controls: Add user cookie to DelayedControls ipa: raspberrypi: Add RPiController::Metadata::mergeCopy ipa: raspberrypi: Use an array of RPiController::Metadata objects pipeline: ipa: raspberrypi: Use IPA cookies ipa: raspberrypi: agc: Fix digital gain calculation for manual mode include/libcamera/ipa/raspberrypi.mojom | 6 +- src/ipa/raspberrypi/controller/metadata.h | 10 + src/ipa/raspberrypi/controller/rpi/agc.cpp | 10 +- src/ipa/raspberrypi/raspberrypi.cpp | 104 ++++--- .../pipeline/raspberrypi/delayed_controls.cpp | 293 ++++++++++++++++++ .../pipeline/raspberrypi/delayed_controls.h | 87 ++++++ .../pipeline/raspberrypi/meson.build | 1 + .../pipeline/raspberrypi/raspberrypi.cpp | 26 +- 8 files changed, 481 insertions(+), 56 deletions(-) create mode 100644 src/libcamera/pipeline/raspberrypi/delayed_controls.cpp create mode 100644 src/libcamera/pipeline/raspberrypi/delayed_controls.h