From patchwork Mon Oct 31 11:45:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 17735 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D3C1DBDB16 for ; Mon, 31 Oct 2022 11:45:29 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 71B3563039; Mon, 31 Oct 2022 12:45:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1667216729; bh=xTGxAKmFtirzfQ10l2lZMoW52RdeGGlsyz+pC0RwRFM=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=M6tvW+TMngHldqg4n1bYPoikxYyMj9ds5ed6biXEnvj9iReIMiUjLPBeQbQ0Tdkgu L79kCC9MdZ/1KblgfWiMtxSwKX4J4J4g8bWdnt6BCuXHF9fGOUnRU24jiP7gw7e3F+ wEbQSSFTttBp8t+WFfEITB/T4f/mITIjG1YNPrzYFImyapDlxxjce47doHHC5QydGS QSw4IboyUqRztGmkFz7Dvntr4QsueJtOkeutWQoPidEo9oNLg/dL6tqRLw15+cawvU EHSLFu9TAcWqBX7d0Nk2AR+9+T01O3WWwqDtIPL42qOlJC00j+pqjf7vs8yV0OnWN+ YGTc7YLmYvUpA== Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DEE3061F46 for ; Mon, 31 Oct 2022 12:45:27 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="Onx+sHGz"; dkim-atps=neutral Received: by mail-wm1-x329.google.com with SMTP id i5-20020a1c3b05000000b003cf47dcd316so10607402wma.4 for ; Mon, 31 Oct 2022 04:45:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=z3PwAJUsVp/iDHOhMmQEQ9vRq809b3N6QX19I2kAmNY=; b=Onx+sHGzESgppzWBg5TVYUdCYevyG9Milag5fN3mMz1kJEVTD95jWg2MndWw6SLmP5 7h0giAyeHqurgCMPBm6bOfha1qET1NcE1VBAUjyrLxjHLH7ci5c98kngapixhzmurZXz hxXleigjXdfjftcqP/rlyLLTGbQmz+1edpLFzjeY96/Mwn/s76LDSFEE6tyyubHeVPXE joOW/GZgZhaeB7T9WK/QXp4N4qM8CKVB/OLUDj1bNRLfQ5rI+c4BIFORhXGdy3nPuA1w HJt20LdrqoUlvanyihKIadgfkUPvYyspnMx21A0aPSpxeAFS98KbzrlwTYzCIUv95Ecs E/Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=z3PwAJUsVp/iDHOhMmQEQ9vRq809b3N6QX19I2kAmNY=; b=S+oZxwKhCtvtGUQJ3RtrSKe0gm749/07FRIrOe7j/FWwTomOxdTYfT9/bselFjwLxg ewKfe/Jwh3kVxh8wjr2oUwB0Wb5N9HxLgCsagPRsNgrG30jgEN7n8P9Fi8ksYFDEvijs ZWosZ9rDUJZjeRr4FSU4iTePZnlAlcOzXuVEGcs0vLUobf9y2PiBnphKZTxHtcYd3/mj S9So2nrhvI3iB/OhrHfvY3U1li0DXJc4p9N10oplyBqXu9hk8g/Uh6byu5WOS1bIiw9v R//OOkR/u/Z/SdDxk9uHhq5WaYRbVvAC+XZ3sIy/cBBpigdK2Bwe25kGBQjfceXs7gdd 5xuQ== X-Gm-Message-State: ACrzQf1GbP5k2YIEFZ898/hrHGYBavG5ot+DBdXdRHu9vCCLvRbuBmwu yFqtChHYRqRPvrdXzIMN9m6h2WKJq3PuuQ== X-Google-Smtp-Source: AMsMyM7msZNiD9V/f3LXF54iNEOeHXoJad5uUHEbw+/sKALEvhxPJ3vVdgYGMGuHz5Jr97EJbMGOXQ== X-Received: by 2002:a05:600c:1e26:b0:3cf:5238:13fc with SMTP id ay38-20020a05600c1e2600b003cf523813fcmr14349699wmb.151.1667216727095; Mon, 31 Oct 2022 04:45:27 -0700 (PDT) Received: from naush-laptop.localdomain ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id h11-20020adff18b000000b0023677e1157fsm6936354wro.56.2022.10.31.04.45.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Oct 2022 04:45:26 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Mon, 31 Oct 2022 11:45:15 +0000 Message-Id: <20221031114522.14215-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v5 0/7] Raspberry Pi AGC digital gain fixes X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Naushir Patuck via libcamera-devel From: Naushir Patuck Reply-To: Naushir Patuck Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, In version 7: - For patch 2/7, the cookie must be provided in push() and reset(). Updated the rkisp1 and ipu3 pipeline handlers to provide frame numbers for the cookie value. - For patch 3/4, add a test for skipped/dropped frames and cookie handling. - Updated patch 6/7 to use the request sequence number for the context index instead of using a separte sequence counter. Thanks, Naush Naushir Patuck (7): delayed_controls: Template the ControlRingBuffer class delayed_controls: Add user cookie to DelayedControls tests: delayed_controls: Add cookie tests ipa: raspberrypi: Add RPiController::Metadata::mergeCopy ipa: raspberrypi: Use an array of RPiController::Metadata objects pipeline: ipa: raspberrypi: Use IPA cookies ipa: raspberrypi: agc: Fix digital gain calculation for manual mode include/libcamera/internal/delayed_controls.h | 21 +-- include/libcamera/ipa/raspberrypi.mojom | 6 +- src/ipa/raspberrypi/controller/metadata.h | 10 ++ src/ipa/raspberrypi/controller/rpi/agc.cpp | 10 +- src/ipa/raspberrypi/raspberrypi.cpp | 104 +++++++++------ src/libcamera/delayed_controls.cpp | 22 ++-- src/libcamera/pipeline/ipu3/ipu3.cpp | 9 +- .../pipeline/raspberrypi/raspberrypi.cpp | 18 ++- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 7 +- test/delayed_controls.cpp | 121 ++++++++++++++++-- 10 files changed, 240 insertions(+), 88 deletions(-)