From patchwork Fri Oct 28 11:51:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 17724 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A7A6FBDB16 for ; Fri, 28 Oct 2022 11:52:06 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C306B62FD8; Fri, 28 Oct 2022 13:52:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1666957925; bh=EpR3d3vFZiYttlmlz0wx7VYxgeb/6bc8VGVpTjVPF70=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=EzXs/dQEHDnv1nDchkg4MYm21p7ef7gJEHuiDXvavOdZNcWfIM6J0lDhUQ/44rvfo HN0lWmBjRUK6Fz+GjdQiVbdDaCnDCKJEMBz4k5e33unYmn9x4iEUtZATDlu0QAJQ52 TB8/i9G/mR1Zby95Z2Bz7kHVAw67iS2wmltutb1vsE70055QHuyLnUeSKuxm2+eelF tyRzM0gzZZ4sQ3Z1DoQk8KZivz9Xo1lathUsisKVGVEJX6+fzz+4j2LjGuitQ+ibcI qmI3jw5uLpGPTPLR6Vjf2BQXnAe95B4BKqBXmQwPQeHcFhvl8Raz1bkOdvAeoSuA1h kcIgd1TF4Er1w== Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 749FB61F4A for ; Fri, 28 Oct 2022 13:52:04 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="EtGexA/A"; dkim-atps=neutral Received: by mail-wr1-x42c.google.com with SMTP id j15so6291021wrq.3 for ; Fri, 28 Oct 2022 04:52:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vn81R/q0BTNCSbWgL2ow8Sdy68XdVPeZUAETgeRcQ8I=; b=EtGexA/APbjAlfS82gMnXMs/ockylW9AHBWYKqjBT7/VHfXhLvkVPAqFhPbjzYwrkM ghCf77aPSMu/NKaSh+d33wa1KzoCo8EfyiMVZ2Ga3AT5rGpaJZLIDRWt99TrpGnGCR9T 6W7EH4dHR2gxWiODJpB7tTrGaojY+/axlC/1rRI9A0olfjSbAftHLwfkPbMUu1CS/azw pMmx9iV6mBkbR5GZwRHdsGUpmlljWpMn15TbZIiqqZQQw14Pv4GJriLqw+vdGQREtzW2 x5UCfwaQSkwVf9jC/swm387kowi6yCe4M+s1/XJyfYOStenJw+EYoDOz7WRYpY/efEdz HF7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vn81R/q0BTNCSbWgL2ow8Sdy68XdVPeZUAETgeRcQ8I=; b=EoBfzYsUNTl6qBAsAgnLqhHHtoEHHdilThKrvUVCw9pQILyXMnvRmWGDaB7kxxB9Dj fFJ42qyB/RyRDhQyeabu0Tbb6eXh6S7mv4IfiDkR+WztlLDGNXTaro7rOGM38M3stCw4 n6q3PCWy+P9gGUv7HIItJAMTsz6pixnLx1kq/cgHYImjTeD/So97qHXuZO7pjL6gZcwG 6wnuASNY9qtq5Fs8acvtz7vY3keg7Kq0eKMvdaU31GB4UecX3XTExuLFEhTUydFKs+tU zOJsEcbJH6nc6hCK7xKA3XEr+rt8b5kvpMgq+81DhiOFZJMf5XStp4ZNkPT0Yl6k0vmw Z/jw== X-Gm-Message-State: ACrzQf0s7lwyVfUJORJCMBGiG16dt364/sPF7nIDmaO+PIXa9Y/Xl/uL 9Biu4iEPmWV0SuIEwYiciGd1m5HyjrbcXA== X-Google-Smtp-Source: AMsMyM6b8Ay2s+DDSN7ezDlkUWjJFJ3dGJpoLEfG76mmCx8YvXXGr2igpTrl4+kopkYb5AqOsu7WJw== X-Received: by 2002:a05:6000:178a:b0:22e:d215:4099 with SMTP id e10-20020a056000178a00b0022ed2154099mr36035168wrg.79.1666957923812; Fri, 28 Oct 2022 04:52:03 -0700 (PDT) Received: from naush-laptop.localdomain ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id a5-20020adffb85000000b002366fb99cdasm3441686wrr.50.2022.10.28.04.52.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 04:52:03 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Fri, 28 Oct 2022 12:51:58 +0100 Message-Id: <20221028115200.8138-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v1 0/2] Buffer cleanup fixes X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Naushir Patuck via libcamera-devel From: Naushir Patuck Reply-To: Naushir Patuck Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, This patch addresses the issue I talked about in an earlier email [1]. The fixes are pretty trivial, one patch for the RPi pipeline handler, and another for the V4L2VideoDevice class. Thanks, Naush [1] https://lists.libcamera.org/pipermail/libcamera-devel/2022-October/035224.html Naushir Patuck (2): libcamera: v4l2_videodevice: Guard against releasing unallocated buffers pipeline: raspberrypi: Do not unconditionally free buffers on close src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 ++- src/libcamera/v4l2_videodevice.cpp | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-)