From patchwork Sat Aug 10 01:13:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 1771 Return-Path: Received: from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net [195.74.38.227]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D20C761623 for ; Sat, 10 Aug 2019 03:13:55 +0200 (CEST) X-Halon-ID: 16edcccb-bb0c-11e9-bdc3-005056917a89 Authorized-sender: niklas@soderlund.pp.se Received: from wyvern.dyn.berto.se (unknown [155.4.79.45]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA id 16edcccb-bb0c-11e9-bdc3-005056917a89; Sat, 10 Aug 2019 03:13:45 +0200 (CEST) From: =?utf-8?q?Niklas_S=C3=B6derlund?= To: libcamera-devel@lists.libcamera.org Date: Sat, 10 Aug 2019 03:13:29 +0200 Message-Id: <20190810011333.8731-1-niklas.soderlund@ragnatech.se> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 0/4] libcamera: Fix issues with vimc and Linux v5.2 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Aug 2019 01:13:56 -0000 Hi, The recently release Linux v5.2 changes the vimc drivers behavior in a way which breaks libcameras vimc pipeline and some of our tests. This small series aims to solve this and keep libcamera functioning on both v5.1 (and earlier) and v5.2. Patch 1/4 is a small preparation patch. While 2/4 switches the vimc pipeline to use the RGB/YUV capture video node instead of a raw capture node. Patch 3/4 fixes issues introduced by [1] and finally 4/4 fixes an issue introduced by [2]. The whole series is tested on v5.1 and v5.2 on top of libcamera master branch and all tests pass again. 1. 85ab1aa1fac17bcd ("media: vimc: deb: fix default sink bayer format") 2. b6c61a6c37317efd ("media: vimc: propagate pixel format in the stream") * Changes since v3 - Change minimum resolution of a vimc camera from 16x16 to 48x48 to satisfy scaler requirement. - Declare link variable where it's first used. - Fold PipelineHandlerVimc::initLinks() into VimcCameraData::init(). - Mention test change in commit message in 2/4. - Update comments. * Changes since v2 - Switch to vimc RGB/YUV capture video node. Niklas Söderlund (4): libcamera: pipeline: vimc: Initialize device pointers libcamera: pipeline: vimc: Switch to using the RGB/YUV Capture video node tests: v4l2_videodevice: Set media bus and pixel formats for vimc tests: camera-sensor: Test using invalid media bus format src/libcamera/pipeline/vimc.cpp | 93 +++++++++++++++++-- test/camera-sensor.cpp | 3 +- test/camera/buffer_import.cpp | 10 +- .../v4l2_videodevice_test.cpp | 26 ++++++ test/v4l2_videodevice/v4l2_videodevice_test.h | 7 +- 5 files changed, 123 insertions(+), 16 deletions(-)