From patchwork Wed Oct 19 11:04:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 17633 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 2F347BD16B for ; Wed, 19 Oct 2022 11:05:01 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7A6A462DFA; Wed, 19 Oct 2022 13:05:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1666177500; bh=yBjQwvEYFmMMH6vF2kDkoTX06HMb42p2bvH+PJmq9z4=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=26qkwZQeGJB9ioLaAzE9r7oqgmVMOQeBc/ZOTtBzrvwaWeOkvnoU6kupi78GXMyF2 Ktwo89+M5r73DdK8ycSeu/Y/WOWzPKDRHN4cu4NuEA4cIHH6IvS3n9oqztoOi8yLXg BsSwZUzXeFAfhnCEcQejM5yDXKSdXHkEQHcYKlbRal68kVzcXY+m31I8YkHQswyElS Lba/VWbQLfKDfgZqs4uikInJKYL/wsv0Pgdx4gHE7FU+P0OKKJwkA68YcQUBlqnVGj nQmWt+mZjvaQ85RKdmPOrWxqFBO/h8fsqq+BbpNVDqu1MjniEl7y2qAb5k+lbOQPMm oDqT980qqmbzA== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D316462DFA for ; Wed, 19 Oct 2022 13:04:58 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="RcN86jlb"; dkim-atps=neutral Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 41BFD5A4 for ; Wed, 19 Oct 2022 13:04:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1666177498; bh=yBjQwvEYFmMMH6vF2kDkoTX06HMb42p2bvH+PJmq9z4=; h=From:To:Subject:Date:From; b=RcN86jlbVNShy6w7amoMb5+Afrv0vgNcqY9PNE6rLUPBD8WblqVZs7gmLWpWbgYrO jzqwSQICkhdHnVMP7Z2t7rA8FOPxGiN03l7iad0BsphkPgiFUAYgt9fxozKP3xVoT+ I10qXO8HOXwa7QEAUq7otwy+VSTkIg40x0eqIbW0= To: libcamera-devel@lists.libcamera.org Date: Wed, 19 Oct 2022 14:04:30 +0300 Message-Id: <20221019110434.17767-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v1 0/4] ipa: Fill metadata in individual algorithms X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, This small patch series improves metadata reporting in IPA modules by making it possible for individual algorithms to report metadata, instead of relying on the top-level IPA module code to do so. Patch 1/4 is a small drive-by cleanup. Patch 2/4 then extends the Algorithm::process() function to take a metadata contro list argument that algorithms should fill with metadata for the frame. Patch 3/4 updates the AGC and AWB algorithms to report their metadata. Patch 4/4 is then another drive-by improvement. Laurent Pinchart (4): ipa: Drop period at end of \brief or \param ipa: Pass metadata to Algorithm::process() function ipa: rkisp1: Fill AGC and AWB metadata ipa: rkisp1: Downgrade sensor controls range message to Debug src/ipa/ipu3/algorithms/af.cpp | 20 +++++++++++--------- src/ipa/ipu3/algorithms/af.h | 2 +- src/ipa/ipu3/algorithms/agc.cpp | 2 ++ src/ipa/ipu3/algorithms/agc.h | 2 +- src/ipa/ipu3/algorithms/awb.cpp | 1 + src/ipa/ipu3/algorithms/awb.h | 2 +- src/ipa/ipu3/algorithms/tone_mapping.cpp | 2 ++ src/ipa/ipu3/algorithms/tone_mapping.h | 2 +- src/ipa/ipu3/ipa_context.cpp | 6 +++--- src/ipa/ipu3/ipu3.cpp | 3 ++- src/ipa/libipa/algorithm.cpp | 7 ++++--- src/ipa/libipa/algorithm.h | 1 + src/ipa/libipa/histogram.cpp | 2 +- src/ipa/rkisp1/algorithms/agc.cpp | 11 ++++++++++- src/ipa/rkisp1/algorithms/agc.h | 2 +- src/ipa/rkisp1/algorithms/awb.cpp | 7 +++++++ src/ipa/rkisp1/algorithms/awb.h | 2 +- src/ipa/rkisp1/rkisp1.cpp | 23 ++++++----------------- 18 files changed, 56 insertions(+), 41 deletions(-) base-commit: ca247829c3feea28d65b181fd0a5f76ff7120a15