From patchwork Sun Oct 9 04:44:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 17561 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E7063BD16B for ; Sun, 9 Oct 2022 04:44:49 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1FD0362D4E; Sun, 9 Oct 2022 06:44:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1665290689; bh=3Ou5zyzDRmHYn/dLS/5zcxZL4sbQ+H+J49TmYtGHV/A=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=mE3fULsroH8NYJsQtkD3O0e2t8zKP3Pn4IitplexztcvWTCFuhFgWWQ3gTFGxI1Pw 3c9I7PIwwah+mhsQGFBRjjllLzHvBYnj8ktg/axBxHjt02QneFR76H3u3yrOlhZ/NL ykwkateGA6g1QzyTEQmzrdQQ3kRGd4pqi47Y4pjjX6KrLkg4FUBvcTTln7kYw18Rs3 2368PBNC3sKJL34o45mOCwyZoTq1BPhZadO3oBw3sVj+wypi7H6A1RMiMk/FR1Pkn+ jakdA0mmzO4dWqsk7coDiH7UT0427kqij4TFjuEpdFi5sIuwsQ5NFztR9Fzg+Wer31 t+uo0BgZdJR3A== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E84AA61F6E for ; Sun, 9 Oct 2022 06:44:46 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="N7IYDNMG"; dkim-atps=neutral Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 27E1F9C4 for ; Sun, 9 Oct 2022 06:44:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1665290686; bh=3Ou5zyzDRmHYn/dLS/5zcxZL4sbQ+H+J49TmYtGHV/A=; h=From:To:Subject:Date:From; b=N7IYDNMG5keNYNqBMFRU26SZbHNQ3VaCc/zu+6VBdI4XH39OBAcyd49nkmID8rBuT S8ImrVV7RLcVjUFmUWzj5oDt/p6ua1uYBg5XAeVyqm2g4zogYcrbW3G7KPqw1M+Uo6 ymlrbwfiDPPzy5XWNObX+WcCY9bQUZAKX/MtgCjQ= To: libcamera-devel@lists.libcamera.org Date: Sun, 9 Oct 2022 07:44:38 +0300 Message-Id: <20221009044440.21499-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/2] libcamera: Fix compilation with gcc 8.3.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, It is with great sadness that I have to announce the removal of utils::defopt. This feature causes compilation failures with gcc 8.0.0 to 8.3.0 due to (I believe) a gcc bug ([1]), and I haven't been able to find a suitable workaround. Debian 10 ships gcc 8.3.0, and it has LTS support until June 2024, making it an important target. I'm sure nobody but me will miss utils::defopt, so I'll get over it. [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86521 Laurent Pinchart (2): ipa: rkisp1: Drop use of utils::defopt libcamera: base: utils: Drop defopt include/libcamera/base/utils.h | 14 -------- src/ipa/rkisp1/algorithms/dpf.cpp | 6 ++-- src/ipa/rkisp1/algorithms/gsl.cpp | 8 ++--- src/ipa/rkisp1/algorithms/lsc.cpp | 4 +-- src/libcamera/base/utils.cpp | 21 ------------ test/utils.cpp | 53 ------------------------------- 6 files changed, 9 insertions(+), 97 deletions(-) base-commit: 4bf68fdbe1493e57118dad4e94c2a46c50a9c402 Reviewed-by: Jacopo Mondi Reviewed-by: Kieran Bingham