From patchwork Thu Oct 6 13:17:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 17541 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id F1BB1BD16B for ; Thu, 6 Oct 2022 13:17:55 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 25A1B62CF6; Thu, 6 Oct 2022 15:17:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1665062275; bh=+6xvYRj46kznBMCowzuV2zl0LpBCybgqZhppCiNcSr8=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Zk8eCsvADvVJ721dNAoFkSCU9nLuZ+Ww2rxGK+dEJ5A6LNb5CnkE3WZro4Vkct9HW jY4fB5eRrhC8hq8pE56Rrdhz1cA9FA5jW0GzKBHULUhzhaPyjJdbj7otc++6jcXFWX W7EQl45EZ/iDnmKKFlKvVVQ762/StJXtdZDzgxDc1jEO7sTrH8TNn0PjZVZMwOrvsX UvCvbIVU6GMDi1s0Dk02O9BdLrj1KhcQxLnaheUutckVDGByREMa+TmCRBI77x4Uj9 J29oif/tPq/r8IQK/kczXTF3YldkMk8ipaAiJhGMokdtfOFvPy+2H31mCx8yT1mwpF v/cCpN8uXfl6g== Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3938E62CEC for ; Thu, 6 Oct 2022 15:17:53 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="jwARKj4w"; dkim-atps=neutral Received: by mail-wr1-x42e.google.com with SMTP id bq9so2690501wrb.4 for ; Thu, 06 Oct 2022 06:17:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=R1rw6kgCymgQ9vuhVvPa52aUOZYm1KSSxwFNMl4TngM=; b=jwARKj4wXHIoORRGTV1lRZp9Hra5aVpVbPWWuVFzNLrpbMzzBxomG8XlwmeEgl4pxE /Y8Ig+LOizQi1jOQt4u9A937azGRSJ2QszM0ZDBzjiAqAtIAqqCj8yspoYOi23sjFeWN eLl+5XBxg6dp65OPC9WMFAfYZSWRV/U8O+KEcFxziP//WNrDtLthhDPzoRtmuo5tQzK/ Uf2nXqj4Q+yt9ioMW7FUlP/X9+CwPxpsoFiN37iWITz0w1PbBs9cuVGq8WPhSrX56VYJ XWNUR+2uPzWFwOk2F6LKDZY7jxyl+TpzFS6Jj9LfpimdyIgMO/P6ezUZ7tBUbn54Lp/E OcAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=R1rw6kgCymgQ9vuhVvPa52aUOZYm1KSSxwFNMl4TngM=; b=uDuIUNZO7dU2g3sfACXiNF+zR/UFGWxM48YjLdLYHbJ9l1389GsKdVl3MgETpI9GjJ OT7AWmWw1y03U/wMcZfO6wghbGu4q7w/eu5CGCYumn8u5PF5/H7Vj5kj4Pu0QJjV7geM ovLs0qtTys/VGZJXsTqY7gB1u5pntQgF/TgqD/O9Vz1+yyExT0Mg1+VNTLBFhVjxxTcD OpXO/R3CgGktWv8n3Kyd5NePBGSCPaOV5A5aqZLS7JjW2aVzOhH5P9pqgp2LjInOpiS7 XoDDoHsLpaohQdwEWfUcqu3tAGyj0IxII78zpX3OwXjbbvjrHgwVbKZ9LfLZETcIqcbq 5htQ== X-Gm-Message-State: ACrzQf0J+yPreZ0LU/gjiaJvuCZXUVncUhx5MqmukpOjl8mbMwueKw3z CvyqaxNHUYlEB+Uo+ghD6qCFqns1Jduipg== X-Google-Smtp-Source: AMsMyM6orbjPlTC147g/2UizqZwfTaBymxp3ehO2KQopF+4u7FjJti7uL/22/ajZbEeKsLlYU6W3yg== X-Received: by 2002:adf:fd04:0:b0:22e:4bf6:4a08 with SMTP id e4-20020adffd04000000b0022e4bf64a08mr3316424wrr.619.1665062272207; Thu, 06 Oct 2022 06:17:52 -0700 (PDT) Received: from naush-laptop.localdomain ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id q18-20020a056000137200b0022cc7c32309sm17986049wrz.115.2022.10.06.06.17.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Oct 2022 06:17:51 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Thu, 6 Oct 2022 14:17:34 +0100 Message-Id: <20221006131744.5179-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 00/10] Raspberry Pi: Horizontal blanking control X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Naushir Patuck via libcamera-devel From: Naushir Patuck Reply-To: Naushir Patuck Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, Here is version 2 of this series. I think I've captured all of the review feedback and suggestions. Notable changes are: Patch 1/10 - Set the HBLANK to the minimum value in sensor init. Patch 4/10 - Remove unused initialized_ field in the CamHelper. Patch 5/10 - Add HBLANK delay values to imx296. I still need to investigate more with imx296 HBLANK control, right now it's left at a fixed value. Regards, Naush Naushir Patuck (10): camera_sensor: Add minimum and maximum line length to IPACameraSensorInfo ipa: raspberrypi: Add minimum and maximum line length fields to CameraMode ipa: raspberrypi: Pass lineLength into the CamHelper API ipa: raspberrypi: Remove initialized_ field from CamHelper pipeline: ipa: raspberrypi: Add HBLANK control to DelayedControls ipa: raspberrypi: Add pixel clock rate to the CameraMode structure ipa: raspberrypi: Add line length calculations helper functions ipa: raspberrypi: Add line length to DeviceStatus ipa: raspberrypi: Allow full line length control ipa: raspberrypi: Extract line length from the embedded data parser include/libcamera/ipa/core.mojom | 21 +++-- include/libcamera/ipa/raspberrypi.mojom | 1 + src/ipa/ipu3/ipu3.cpp | 6 +- src/ipa/raspberrypi/cam_helper.cpp | 91 +++++++++++++------ src/ipa/raspberrypi/cam_helper.h | 19 ++-- src/ipa/raspberrypi/cam_helper_imx219.cpp | 10 +- src/ipa/raspberrypi/cam_helper_imx290.cpp | 5 +- src/ipa/raspberrypi/cam_helper_imx296.cpp | 16 ++-- src/ipa/raspberrypi/cam_helper_imx477.cpp | 39 +++++--- src/ipa/raspberrypi/cam_helper_imx519.cpp | 39 +++++--- src/ipa/raspberrypi/cam_helper_ov5647.cpp | 5 +- src/ipa/raspberrypi/cam_helper_ov9281.cpp | 5 +- src/ipa/raspberrypi/controller/camera_mode.h | 25 +++-- .../raspberrypi/controller/device_status.cpp | 1 + .../raspberrypi/controller/device_status.h | 4 +- src/ipa/raspberrypi/raspberrypi.cpp | 61 ++++++++----- src/ipa/rkisp1/rkisp1.cpp | 2 +- src/libcamera/camera_sensor.cpp | 15 ++- .../pipeline/raspberrypi/raspberrypi.cpp | 1 + 19 files changed, 247 insertions(+), 119 deletions(-)