From patchwork Mon Oct 3 14:36:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Sylvestre X-Patchwork-Id: 17505 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5C67CBD16B for ; Mon, 3 Oct 2022 14:36:46 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6CF17601C2; Mon, 3 Oct 2022 16:36:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1664807805; bh=mB3Ddk9wGjr0OhTsxQxWW7VRgDwYcd6Q3bDkIe/wTeA=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=hQqPqmpne2zX48xLuysEXCPVl+rx4wl5p7y13GnYfEYW/Np3yfdTv34/BQNCkDm14 zSqguGQr/hdS3ctoTxWP9tSPQD9MXxlB2gA/ufs9eanIgZvpmbB04qLwqtKT/cyeo1 ZupeE1A+08NaPXrcMFYwtVSlt91MNX6fqUgbzReXy7Db6co+myPrVExT1Od0+L09KV WZJFVEtu0F2pT7zDCJPS0oSbtjEaTfpxAa+CnnXOSYxe6k5PTUZSQV3h501bIKaXNU 83M9CdGo1XiC6Losrh6YqmDDkKp5OfGr8iA+F91+Yd4n46vL6HMqHYq2UZsdQe0DqV +AnPmZ/7TrdQw== Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E6A72600E9 for ; Mon, 3 Oct 2022 16:36:43 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20210112.gappssmtp.com header.i=@baylibre-com.20210112.gappssmtp.com header.b="Hj0yxU2Y"; dkim-atps=neutral Received: by mail-wr1-x42b.google.com with SMTP id u10so16928026wrq.2 for ; Mon, 03 Oct 2022 07:36:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=GMuwh2Vtclm5jApJe5OrQRi95kiBAIQSzmoJWJAvtoc=; b=Hj0yxU2YepoGULdeMXkiqBaAmM2nAKQHI0dJ/9XMSEFu9/uian0sjLg8+2qgqqU50C f2MlHh+iK8uAhmAdvBYwAiLwlja/W8ce39cVktrEM7E4U7tVT0KCnOPPSeMYMk682pDJ c6PQiN9DjPugVRxZZyG9BAwRm1Z+RCQpyX+/cMPrMQPOzAzMBgHJjebGlyrLcQMRRvxD Y0lWvhIthbaWuUdxzSkmQJeXn3Rf3Dj0/7U5g8WyNGH4riOKJ5kETntgx8JJBBwCGSx8 hJNNVhIUIx+MOrv2iqx7nyJ6B9gtUScHTRrdKwcvDloWNf26JXQ0SUjzmsg/gjpttm/E yB3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=GMuwh2Vtclm5jApJe5OrQRi95kiBAIQSzmoJWJAvtoc=; b=iNY3F0ANBDgI/lIHDltEX/9rP2hzk+ek3vxr5S/pPqBHqHvH6I2m4qnMpwKwhkIJah ZbVZIew+KsGQaMHPwlTNa3N7RKbM53Ky9l01O2ASZ0P0QEpCk6xdc3HFpwFfKKUklno6 4F/X+5TicE5EzWrAHJoCelDZLVdnplLDpJd0rio0kLS3B2OzlRT34UBaToZgMBS3OkHf RiopT2rpGHwaLkxr3MTGfs4LOETmkLStl1AltD8SZKN0hc46LCLuAxB8gKyFSZ8rkXKV hXGws2zyjPQlV9DGrZWRNKO9JHwZGF49iHAetVGhsCBvhFsfxrQpr4PrWULcdKNiWJRi tOgA== X-Gm-Message-State: ACrzQf0BVZsp0LsuAAK3LqWtXSkAtOwi7Rj2EgwUm40qi/7cvc1MPh63 kgDYYd6ZaZEL9JXtL3FI5oryTdmSV11naA== X-Google-Smtp-Source: AMsMyM7r521VMcP6NYGF6/1rwDUL7IZruZ8vkykcgVPi1+Dp32i4YPcK9xG625EdoEfZvzsm+FMomA== X-Received: by 2002:a5d:64e8:0:b0:22a:bb78:1e44 with SMTP id g8-20020a5d64e8000000b0022abb781e44mr14369731wri.378.1664807803278; Mon, 03 Oct 2022 07:36:43 -0700 (PDT) Received: from BL087.. (rqp06-2-78-234-158-99.fbx.proxad.net. [78.234.158.99]) by smtp.gmail.com with ESMTPSA id p8-20020adf9d88000000b002252884cc91sm10202590wre.43.2022.10.03.07.36.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Oct 2022 07:36:42 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Mon, 3 Oct 2022 16:36:37 +0200 Message-Id: <20221003143638.604343-1-fsylvestre@baylibre.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/1] Add Bayer format support for RkISP1 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Florian Sylvestre via libcamera-devel From: Florian Sylvestre Reply-To: Florian Sylvestre Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This patch allows pipeline configuration for supporting raw format on RkISP1. It also manage the fact that statistics will not be available while we bypass ISP algorithms and that ISP is not supporting resizing on raw formats (so the sensor resolution is forced if necessary). Modifications in V2: - Simplify the code for conversion from format to mbus code. - Sort the bayer patterns alphabetically Things that still need to be developped: - manual exposure and gain will not be taken into account correctly - need to remove second stream in case at least on of the stream is configured in raw format. - should we skip queuing ISP parameters? (tried one my side without success) Florian Sylvestre (1): pipeline: rkisp1: Implement Bayer formats support include/libcamera/ipa/rkisp1.mojom | 1 + src/ipa/rkisp1/rkisp1.cpp | 10 +++ src/libcamera/pipeline/rkisp1/rkisp1.cpp | 64 ++++++++++++++++++- src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 44 ++++++++++--- 4 files changed, 106 insertions(+), 13 deletions(-)