From patchwork Thu Sep 29 07:23:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 17455 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B1D45BD16B for ; Thu, 29 Sep 2022 07:23:44 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 217B962381; Thu, 29 Sep 2022 09:23:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1664436224; bh=0/qFIIAbLfKqMSoUNq5p5S3/gN2B4a2FUUITg89j5mY=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=fyTsh5RIuQ7wUPAvwRapzMLbZmv1oDU1XQEfOn6QQ6vZKkehDgU46rBEpk94yBE37 e3fC77BLbpVV3WqV4DOuH1pCgoCyKwv2PUGGovN2D2vNTgeByuyQyf8bADFV2dkUCS zUISII1v2R5PiBLmX2ZCq2EdPGLDOunDuUzcYYsbl96nYMDUB50i5lagwCEZmBryfG QJw+dl5V3Sz/GIh52tnZ9m1hhsSL0DT7HJDcp37dGeHC9LQjnmET2x/LB4orkdqqsF 0LmV/CpWvNWupUgGeCU7W59XpTEZnWofi0VBYbgzhaO1fr5iDwutjZxGQr2zAobbzD GSeAKwWTsVeNw== Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id F22F2603DE for ; Thu, 29 Sep 2022 09:23:42 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="qgoql39O"; dkim-atps=neutral Received: by mail-wm1-x333.google.com with SMTP id o20-20020a05600c4fd400b003b4a516c479so279776wmq.1 for ; Thu, 29 Sep 2022 00:23:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=MUlGIAYqkOaukfFVsjmkZMjwzHCoReZQq/oTQlqMHTo=; b=qgoql39OX+3FhrHYlSp/dziT6rMsWsSJGLsSbyjLM2qA7rHGtxsb54EeS78OCmI8Lf cZAsCYey17KXLpuQGc0kolIjqZ+BtIAyD4RI1gr2GKNHcuaztqOnomBV+q5702v6+01c X7wg7VTJeO/xmAHJccgrHzN5bOLavue3nCBw7f4JMHKYBNVdpgs1Rdz1criD2vKHeANn 2Sx2cdhRwfAf6bYFj6u/VXVHAf1hswpwoKVqq6act785Rcf24DdmAPU2uva4ac6Usi7e 4Y7iHQAa8gp0nuluuMB0vVs0kfZhAAxUH69hivK8YoF3pzCnu+dWZaXduIWyK8KS/pbe quZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=MUlGIAYqkOaukfFVsjmkZMjwzHCoReZQq/oTQlqMHTo=; b=jbBeBIojkoiIjpzXnfBwmTlpvlS8iGXY2DAcF9/baiNU6LrqDvys0z5o04ZeF+4253 SVklcCVibWT14x5tc1+Q5L3aoJTG7bQyKtsRHzCw5OWdMpYbWDj5pNEkkMzTio/RVi0E I1ZFOfcNIowBukNSWhZ6HtdShTK4N/tnzN8OeWhly49JQW3ASOtH0ALonsZzX2YaSvH6 PocbFJc5Dh5AjP04JTAJymCb7bmB0bCjogSq5ViwqThy+udBs8hIYAfYiVgEF2UvKP77 spfaF/FU4j1p72ujwzhRpw+fws9x8GqZE28sKGKAgvu5nrhUJvLrrSM3zfVx/FC+4rHq 983A== X-Gm-Message-State: ACrzQf2bkBAjh5RRhvdEMxWsmBsGNKp0efUV0+rVTHsVe81eHjsubuSB 4LLxfcojTg1b/PocHSAqfqOreYybH2vlHQ== X-Google-Smtp-Source: AMsMyM4BJXMp8ff4lx2PtfOTmZBq0bAOoQNQtMjAUq/BymSlBMnZJwaWpHvjWmxohDafhB6z4PPIiw== X-Received: by 2002:a05:600c:a195:b0:3b4:fc79:f778 with SMTP id id21-20020a05600ca19500b003b4fc79f778mr9413768wmb.177.1664436222367; Thu, 29 Sep 2022 00:23:42 -0700 (PDT) Received: from naush-laptop.localdomain ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id j6-20020a05600c1c0600b003b483000583sm3929805wms.48.2022.09.29.00.23.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 00:23:41 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Thu, 29 Sep 2022 08:23:19 +0100 Message-Id: <20220929072323.7400-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/4] imx296 colour tuning X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Naushir Patuck via libcamera-devel From: Naushir Patuck Reply-To: Naushir Patuck Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, Version 2 of this patch incorporates Jacopo's suggested changes in patch 1/2. No other changes from version 1. One thing to note about this series - between patches 2/4 and 3/4, we lose the imx296.json tuning file. There is ever so slight risk this could cause a problem with tree bisection if you happen to use the imx296 colour sensor. To avoid this, we might want to consider squashing 2/4 and 3/4 when merging. Thanks, Naush Naushir Patuck (4): libcamera: bayer_format: Add unpacked mono 12-bit format to the conversion table pipeline: raspberrypi: Update naming convention for tuning files ipa: raspberrypi: Add a tuning file for the colour variant of IMX296 ipa: raspberrypi: Fix the imx296 mono tuning black level src/ipa/raspberrypi/data/imx296.json | 296 +++++++++++++++--- src/ipa/raspberrypi/data/imx296_mono.json | 228 ++++++++++++++ src/ipa/raspberrypi/data/meson.build | 1 + src/libcamera/bayer_format.cpp | 1 + .../pipeline/raspberrypi/raspberrypi.cpp | 22 +- 5 files changed, 493 insertions(+), 55 deletions(-) create mode 100644 src/ipa/raspberrypi/data/imx296_mono.json