From patchwork Mon Sep 26 09:57:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 17397 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 770D9BD16B for ; Mon, 26 Sep 2022 09:57:49 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D5E7E6224E; Mon, 26 Sep 2022 11:57:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1664186268; bh=+Mc6gNGjC7p+PCJp38+UiAWlrfZ6rFhWi0bumVpFXJg=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=ZRYIKTelhYgmlHhNqHBoedFljyzCZG6SfExNGsANeM94NxTsmnfOK5sDizu691rGU hCsHs9qA6hPHMK7oJaOxiiwSPT5OGIyAw3lchOIeGTzE6cUWoSd/1+SmQ9328G8Swx VRVovXcNJZjZr/ajCR5lWolKwxbfkmRjAFrMubyavF/YiXuXKcK9kaV5GU3a/GKIQv 6R6Ba1L/9kiSBO4RLMaliEpJEhR9LP/UAHdlG69gINPrEy4l4PYXCAc5PI23IEImQT C8ECkAsVieDbiC0XZrQvvUVlsuF6vBRK6dhFjO5J0YpQaoyRlMuYan0gkCtNBXTsCb lDFO9LaAlp2VQ== Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 71E1D61F7C for ; Mon, 26 Sep 2022 11:57:47 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="Dqbz+trf"; dkim-atps=neutral Received: by mail-wr1-x430.google.com with SMTP id y5so9372253wrh.3 for ; Mon, 26 Sep 2022 02:57:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=YQVBEYWt6bPuBcfozozYJE6TebEAQvjjtBlt2JIF9hY=; b=Dqbz+trfFpgtjGKAGUyQMP7h6LN9U8kd2IkmUdIvrK+zH1ev/cHeMmKOiNpQa2rVq2 V9raVxhkIKQiCKUEosHMhClQ4HgU6yr7tBRM0rKtIny1ZVgn+vqhOeQKmRADstPOoNBt NFnZkIVWY7/JIbyPXVPAn8prrhY/2oT1EBTr8NdK6EG2PFyp2Z+ce45D/5QUNEKfSPQV XAmS9/mbMhLYE77ZaFkvLDD3gl3gRPny8aW613KMF6Q1y37CPWPyyjb9RRLM6/uyyP2D a0XMOrIk06CD+G72g3oFSP1nRimulCwspUy6d2RIV8qiIxnMTcBinTCemkSrp5BnFWsH rO8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=YQVBEYWt6bPuBcfozozYJE6TebEAQvjjtBlt2JIF9hY=; b=bmWW80vnLs0UZZXZu/8e+ePKY6QK2TBv0UD1y4WCaKxjTQBTBJksCAjF8d722T4saW zRXzeDUf6wEstYeY4tpybfeXvgal5n+0dcV3vlVGxMH7y0N4FWG0HEAVwW/PgR3GHRUo 7lLagLynABPRVJBqrfPPVVdViiMQe9CN8C2sGI7dVefCpWYStN5nRgVE8Hto80ZGFrNI 70SYFQMnksW4PEG5fpvPjfr6l/mBDRp1y0dVVCjMuwlFMq+CtGtHhhjrKSBXXvj2aN8R MJ5jI5eFKBfCaXzTV2vxLupFRb1xrxtDW1GAbOHndB4iV4kcikiNyzkaofQT6SkGK7Ly 4RBw== X-Gm-Message-State: ACrzQf0zcv6KHoFOMzt9ySR9ictzdzTghUsnOxPoxhFs5JrbuzSZj8Wc hJfdEvX6NI8fBngLzYKvJQgjvntUm6wJ9YwO X-Google-Smtp-Source: AMsMyM5qImq9mZ2MrqD8oTDJze13ZS4kqY6C7tfnluMNmJsKuxXLx0eNFb3qEgZiG45b0JpSFB/V7w== X-Received: by 2002:a05:6000:1a8a:b0:22a:43ef:94f0 with SMTP id f10-20020a0560001a8a00b0022a43ef94f0mr13103200wry.279.1664186266810; Mon, 26 Sep 2022 02:57:46 -0700 (PDT) Received: from naush-laptop.localdomain ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id p22-20020a05600c419600b003a4efb794d7sm10160671wmh.36.2022.09.26.02.57.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Sep 2022 02:57:41 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Mon, 26 Sep 2022 10:57:30 +0100 Message-Id: <20220926095737.30506-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/7] Raspberry Pi AGC digital gain fixes X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Naushir Patuck via libcamera-devel From: Naushir Patuck Reply-To: Naushir Patuck Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, Version 3 of this series addresses the comments from Umang and David - mostly minor typos, and a simplification to the new Metadata:mergeCopy() function. Thanks, Naush Naushir Patuck (7): delayed_controls: Template the ControlRingBuffer class delayed_controls: Add user cookie to DelayedControls tests: delayed_controls: Add cookie value test ipa: raspberrypi: Add RPiController::Metadata::mergeCopy ipa: raspberrypi: Use an array of RPiController::Metadata objects pipeline: ipa: raspberrypi: Use IPA cookies ipa: raspberrypi: agc: Fix digital gain calculation for manual mode include/libcamera/internal/delayed_controls.h | 21 +++-- include/libcamera/ipa/raspberrypi.mojom | 3 +- src/ipa/raspberrypi/controller/metadata.h | 10 +++ src/ipa/raspberrypi/controller/rpi/agc.cpp | 10 ++- src/ipa/raspberrypi/raspberrypi.cpp | 82 ++++++++++++------- src/libcamera/delayed_controls.cpp | 20 +++-- src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +- .../pipeline/raspberrypi/raspberrypi.cpp | 12 +-- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 +- test/delayed_controls.cpp | 52 +++++++++++- 10 files changed, 156 insertions(+), 60 deletions(-)