From patchwork Mon Sep 5 07:39:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 17296 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E14CDC3272 for ; Mon, 5 Sep 2022 07:40:03 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4542F62056; Mon, 5 Sep 2022 09:40:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1662363603; bh=YUUTL0Oekmbu6gBDNIWOYJ3aZgdgm5Wt9W3bCTryqEY=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=ZptakDBebkfbpjX69gnOERue7Rdq9sYKz4160HMnQdUvmfQN12jYmW3A10UzDBtdL PhhjOP4T/nnD+yQiJfCMZn37mpic/0p78hWXT/dKUI+xkeHRhhw8Q1DY8/ddI1Wg7Q ZdX5ve3GVRvx76ZwMxv5WssaXq2ht3Y/QLAj3lZX2pxjiXd4wKn8rGzxeMckNvTiO+ dAbL5tyq13jcFRuv2dSzufkFqtuiuzStrsWCUA0cMoVcB85Pst4chy0hDCbQ5QrIjF 8e6AcGEISMdVPlxTKJWeI/DBL3WqiIzbp2tA7NWkCAol6HGJHzSqdCQGhBOZl7rqfr W/sLV2BatZqBA== Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 373686201C for ; Mon, 5 Sep 2022 09:40:01 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="e0VwM6PF"; dkim-atps=neutral Received: by mail-wr1-x432.google.com with SMTP id az27so10120581wrb.6 for ; Mon, 05 Sep 2022 00:40:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=Amq3SNoJSODVAnewSBsfTAUPyQvjbdtiTy1AqATBYDI=; b=e0VwM6PFGEmXWLX3O6YD67luvpxvC2KGdKvH7N8bGjdS1IiKmKqU9vtl7h03Nq8Gp9 PBNQFLuUFQRAWWmBvEHIe2qr3/b6RCmCMapjIQ8lbJFPMAC5QKq7u1dDQOO9gkewmJNC LQ/CFgVwWJ6nm/oXM9uN9NOqyhAqH5EedolCgI2t6jenUZIM+ckAy6vu61z+gIcs2ewN kUr68wEI8U67VLscEoriYbEAYdMGyD58f/K7OQkrp2N1oRtUP4wJ5OPP5OZPBr6z/uZn TYSp0ebP7UZ5mAepJ/9xEsmdAinJ5tWx+zQmPKIRoenfIxk6OtfHDJDppZ3Dyms4YsP4 MgcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=Amq3SNoJSODVAnewSBsfTAUPyQvjbdtiTy1AqATBYDI=; b=eSVqKFtrbJ+cWJpWXNh8foo0PaCu0TrN90ligOs5BzDpGfoqM3zJ2y9fHQqILvBFdI vd8xjvDLqI6uGRTYhx79KEm6j0zc6a0WFWMRVSxRsOmw6UPjSEcuw78yB0KVwhujRyQA hG/uQwLBhyUdgWDoa/SuVfrQ4Xm4ZgQ3qiq3/3iZYtzPqCWm4TjIi42snKrx7PjAbiL0 V003gsaq9RzoeiBcq/vrW7kUJaFxu8TrDPXfZ74cdmDyUoribFczO0Yf7lFZjLT8cOTD MXzZPrSjlULoifCQYbz4QmP2uZKq7J0WnkPpAQDtAshVV1qCgdWql3GPLURcwHZHLtzb 4Eow== X-Gm-Message-State: ACgBeo2a0022f2KJ4JvcC+DlT4VS68uWn3mYJOQ4apBG/CKIAipW/RsX jvp2egfQ190LC6Cl5Bptu9wWLZ7PRHuY4bVP X-Google-Smtp-Source: AA6agR6u2GoP3NvZH60O7UASy3PDQ80IeGAqEcg1ZOII3gnsf+GZHbdsTeuSKeksXcM+a1uV518sOQ== X-Received: by 2002:adf:eb02:0:b0:225:2b94:d14c with SMTP id s2-20020adfeb02000000b002252b94d14cmr24368900wrn.291.1662363600515; Mon, 05 Sep 2022 00:40:00 -0700 (PDT) Received: from naush-laptop.localdomain ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id v16-20020a5d5910000000b00228a6ce17b4sm1342841wrd.37.2022.09.05.00.39.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Sep 2022 00:39:59 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Mon, 5 Sep 2022 08:39:49 +0100 Message-Id: <20220905073956.7342-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/7] Raspberry Pi AGC digial gain fixes X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Naushir Patuck via libcamera-devel From: Naushir Patuck Reply-To: Naushir Patuck Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, Apologies for sending out a v2 so quickly, but David noticed a problem with Request metadata with this patch series. I have fixed this for version 2, so please disregard the v1 series. Thanks, Naush Naushir Patuck (7): delayed_controls: Template the ControlRingBuffer class delayed_controls: Add user cookie to DelayedControls tests: delayed_controls: Add cookie value test ipa: raspberrypi: Add RPiController::Metadata::mergeCopy ipa: raspberrypi: Use an array of RPiController::Metadata objects pipeline: ipa: raspberrypi: Use IPA cookies ipa: raspberrypi: agc: Fix digital gain calculation for manual mode include/libcamera/internal/delayed_controls.h | 21 +++-- include/libcamera/ipa/raspberrypi.mojom | 3 +- src/ipa/raspberrypi/controller/metadata.h | 12 +++ src/ipa/raspberrypi/controller/rpi/agc.cpp | 10 ++- src/ipa/raspberrypi/raspberrypi.cpp | 82 ++++++++++++------- src/libcamera/delayed_controls.cpp | 17 ++-- src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +- .../pipeline/raspberrypi/raspberrypi.cpp | 12 +-- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 +- test/delayed_controls.cpp | 52 +++++++++++- 10 files changed, 156 insertions(+), 59 deletions(-)