From patchwork Mon Aug 15 14:16:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 17125 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 56E72C3272 for ; Mon, 15 Aug 2022 14:16:44 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id AE11761FBD; Mon, 15 Aug 2022 16:16:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1660573003; bh=J0HIxsPnGpCyUH+SS9ooLdJb6/bN/AydjTixGE1jLQg=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=WnkZJx/N4AQiCSGYfbgmT/0FQO28hfdbIOaZFMdTpQSVgl3y86fUsPkEjTZZKqY0u d4RmToRDRrK+ECXtEYB+R0d4k3Ub2nieEYFHQVVvlexFUZW2zSI8X60cup+RsNhPdl ad8T379qfHUG8N/QrB9m0W8w7QeNP+A75jAbvoDA2hUF07PEcp005OXI4k1muzsPB0 sCg1cB9FkF/t1W2PQ8NjK/lQD69iH4ocG3Usoh14j3QRQneIDRRAlfXIwg/m955qol 4Mvv7ZryvXHCxwmi8HEIESZXyOlmIKVoRpRD9baKNktdAWSRFacl1oAwURMni1y95I x62V9YcjN0+cg== Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5841061FB9 for ; Mon, 15 Aug 2022 16:16:41 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="KRJKx5Vl"; dkim-atps=neutral Received: by mail-wr1-x436.google.com with SMTP id n4so9202421wrp.10 for ; Mon, 15 Aug 2022 07:16:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=GmFck5cTsXiZRMm1LHiS6TAqnWkDN6MrPxf/ZsiyS7Q=; b=KRJKx5VlipB05C6qHie4j8Iz9xTK3oeccAk5SvFTmjUNe3thTqfJKDGfgGdPKukIxb 68HttFrjE29f68jKANsiEf4GHLjW5WfrZYuk9Zk4cJ7CbxoyvXlIO/o+GK5zuAALW4S1 BTxBHXjM2MufxN/bq/z0iILqnEF0vsngpfckqLfwV8A7bukMZ8y9nC7Hb6UEGlm+wOqU hHXh/8xOGJZeUtRkGtJq+eZtWj/ybqrBhl87/8v6b0LjErFJBLNEYm6GM7oNfQVmV4G6 vTrJAa68twpZXOasGM/HENq7soywbsJhq66s1t4ckYa+qqwwVY5nxoL4wfjfKWcYwocl JXnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=GmFck5cTsXiZRMm1LHiS6TAqnWkDN6MrPxf/ZsiyS7Q=; b=Xm/+t0SufgXPmhbjVWzaEhKeDRn6E7+yTc/GSoX3SDP813iqbaN1G+y6QJ8zBG6dLB zEZ5ON9mkikxG02Ypjend0I9z/3GrQWQip+F0n4YUVze8VKxTHE3h2F2BhGzrud9YVpw J9sGDB9Zgz6VKq3ByhrQwuPQSBewhc0wYs7ng1f5wx2u32d8ED8r9BeaJDAIvztHi4xX l9yc7i5GqyBNUM+7UCsdT2ilQB0O60R0Z9RNpr5Ropp2j3MFPJs/DhbptUv9dwbVrdmY jNpJd1Sr9adK+XrlZnzxpg1K8tH0hgMrFp20aHyekSkMcIlOcNregIPNdpyI53RfAaeY p4BA== X-Gm-Message-State: ACgBeo3xQvezEyh7JgMXMIHHG+7jWHNZuHvs0N996tnTCvQp9qoA9jHC hwaeegYVF11vxd/oYHT417tob3AB8m7E7g== X-Google-Smtp-Source: AA6agR4/zWaktaKspYYqdSH5BzguIno/vyJXVpDbwNhAsr3gcs24Vn4Fj9bURCpg/Wcy1Jq9SySp7g== X-Received: by 2002:adf:f188:0:b0:224:f6d7:3100 with SMTP id h8-20020adff188000000b00224f6d73100mr5102885wro.542.1660573000592; Mon, 15 Aug 2022 07:16:40 -0700 (PDT) Received: from pi4-davidp.pitowers.org ([2a00:1098:3142:14:e4a2:3070:eea4:e434]) by smtp.gmail.com with ESMTPSA id bk12-20020a0560001d8c00b0021f0ff1bc6csm7294282wrb.41.2022.08.15.07.16.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Aug 2022 07:16:40 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Mon, 15 Aug 2022 15:16:36 +0100 Message-Id: <20220815141637.4159-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/1] Raspberry Pi: handle monochrome raw formats correctly X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Plowman via libcamera-devel From: David Plowman Reply-To: David Plowman Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi everyone This is actually a replacement patch for one from an earlier set, where I had changed the "R" (greyscale) pixel format colour space from YUV to RAW. But it seems that some platforms are handling non-raw greyscale sensors, so this would cause a regression. I did at one point suggest altering the PixelFormat class, but I'm guessing there may not be a huge amount of enthusiasm for that, so this seems like a reasonable workaround for the Raspberry Pi. Please let me know what you think. Thanks! David David Plowman (1): pipeline: raspberrypi: Detect monochrome "R" formats as being raw src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-)