From patchwork Mon Aug 15 13:31:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rishikesh Donadkar X-Patchwork-Id: 17123 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C325EBE173 for ; Mon, 15 Aug 2022 13:31:29 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 12CB561FC0; Mon, 15 Aug 2022 15:31:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1660570289; bh=PRPfJQVSUEgt4kYMh7UxJsAY+9oZCj9eLPynp6K1/Cs=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=hro3mkSI2VuA7GMeFsFMqWBux8LqIKl2He4/JuCfjbfRuO5OKlAwT6rtH/JqqG4AZ CP5hgGpIqQtNZYuiEEmkTr4KqLF8RZAHI890vQUey6IJBM2to134YVDHcNq4kGGlCn mYfS6ScGSXsuHg4UaGdcMsMxPvgayYnfYLdLyFHYdyeJ8a1HkbBwh3noIndHjcD3PV RfiRtOmyOX0x+HmQgqm3+ER9xYviPF1b/d2IFo9eW/MUxiAn2HqVay9JddNuX7Vo/9 irSdjzriPUP5XaJ45d/oqr+Rbiv8j9Z3hVXOiRW87DUZqlpWJnD+8ssVnAUCjet2cn TpqGLueKu4Qlg== Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 852D361FB9 for ; Mon, 15 Aug 2022 15:31:27 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ajgydCTZ"; dkim-atps=neutral Received: by mail-pg1-x52e.google.com with SMTP id v4so2160923pgi.10 for ; Mon, 15 Aug 2022 06:31:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=2wlUhTuMYkfa1Ec7n2KXtkVOb35oGJXcd0lNtp5spwo=; b=ajgydCTZjqG7KI22P0z0fdi5v0yUDJg5hOdTZOpF8FAijrZdH/n5vlGW+1cJMyUfSY 92AIe//orxrtbzn0uxm71hyNbrLGSHiEmMKxm5Jqu9aOkaMknAdO4b7HiNTqqTM92Opu cEHE2ndUJccFp0tsj8ttB0LBLmVUhuK1cFt+mqjJJ9ouSnzqDJGEpuJZeSld5W09tMt7 kUBASX+CvDNkicVW8FZC2/L7mzuAM3bzgFcsb8cpXtY6h7VwPs8AnIlsPb2qozou+Xw9 Q+Aokwb/kgD87AF/abSrbFdFJ4O/QcJxtzrb1SZHZacz/VdDEqRAwfoH63/44maOTGEv bcRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=2wlUhTuMYkfa1Ec7n2KXtkVOb35oGJXcd0lNtp5spwo=; b=J6hsoW/wXcT+oYJt/g8quIQAOTCuDossY6ttLDjMVXpXISv3eAaFFQwrmTT58gxRU2 2lbKmXj+e1z5KpLcgID/c3oX36b8ZJQXtrZVkqP5ZjpiIW451TQr0bTmv5ACKkN8Do2j Ufrx5k+YawRzeoMrMnezXLkTu+NA6dv+OGLEYUkoyN0aVFqw9Pr6cexVn1X8PcJ6ReSP C7ISFBFeHb1sDExCOUCpmQS5H8sMSdN8vQPIRMUFMprHAsThSOhZRKcfdBwErcZbeVZ5 YcIPcXxDOuk278l+ef+xqwGnhaq3hIMWIP1ykkAgjtK3JcZsfyYY5rwZ6ioZlxGj4c0B tL5A== X-Gm-Message-State: ACgBeo2wwvCyoou2uJ0SXNbzfHAdsL3Bb8uPIQgr1AvTAQG7jBSrc3u5 b4dnxmsxB92bAm0ioaTC/C09w4svWcu7og== X-Google-Smtp-Source: AA6agR6lIL7Z195Kjxbx32o1y6xbNCI+UfvGCUs/jPCmYr3yC39lXLt3LmyZfGBSnsatocoXO61ZOg== X-Received: by 2002:a63:c158:0:b0:41a:6685:59de with SMTP id p24-20020a63c158000000b0041a668559demr14137394pgi.95.1660570285635; Mon, 15 Aug 2022 06:31:25 -0700 (PDT) Received: from localhost.localdomain ([49.36.101.94]) by smtp.googlemail.com with ESMTPSA id e3-20020aa798c3000000b00528bd940390sm6532068pfm.153.2022.08.15.06.31.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Aug 2022 06:31:25 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Mon, 15 Aug 2022 19:01:04 +0530 Message-Id: <20220815133105.15025-1-rishikeshdonadkar@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/1] Multiple colorimetry support for libcamerasrc. X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Rishikesh Donadkar via libcamera-devel From: Rishikesh Donadkar Reply-To: Rishikesh Donadkar Cc: Rishikesh Donadkar , nicolas.dufresne@collabora.com, vedantparanjape160201@gmail.com Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" GStreamer pipeline supports passing multiple colorimetry as a comma separated list. For Example : gst-launch-1.0 libcamerasrc ! "video/x-raw,colorimetry={bt2020,bt709,sRGB}" ! glimagesink In this case, if supported by the camera one of bt2020, bt709, sRGB should be applied. This series aims to adds multiple colorimetry support to the libcamera gstreamer element. ... Based on top of [v3 PATCH 4/4] gstreamer: Provide colorimetry <> ColorSpace mappings. https://patchwork.libcamera.org/project/libcamera/list/?series=3360 ... --- changes from v1 to v2: - Moved the function colorspace_from_colorimetry() from PATCH 1/2 to PATCH 2/2. changes from v2 to v3: - Rebase on top of [v3 PATCH 4/4] gstreamer: Provide colorimetry <> ColorSpace mappings. - Use the comparator utility function gst_video_colorimetry_is_equal() to cut down code. - Rename dup_stream_cfg to pristine_stream_cfg. - Log the colorimetry that is selected from the list. - Change the API for the function gst_libcamera_configure_stream_from_caps() to pass pass state->config_ here instead of taking it in a holder variable reference. --- Rishikesh Donadkar (1): gstreamer: Provide mulitple colorimetry support src/gstreamer/gstlibcamera-utils.cpp | 73 ++++++++++++++++++++-------- src/gstreamer/gstlibcamera-utils.h | 4 +- src/gstreamer/gstlibcamerasrc.cpp | 2 +- 3 files changed, 58 insertions(+), 21 deletions(-)