From patchwork Wed Aug 10 15:03:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Utkarsh Tiwari X-Patchwork-Id: 17066 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1E939C3272 for ; Wed, 10 Aug 2022 15:04:00 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4C4C76332B; Wed, 10 Aug 2022 17:03:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1660143839; bh=amL7jzbj5CfuhDH+4jAhrRGA203aUKWp6Qn2Rk8hKp8=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=AurRtslM6xzIJSnCfLp4n8VdSHt+g8bv8rAXv+rbiR2B61eeIBPbmsHrypy8f3Jw4 I5qOCefgYbKaR2z0fyfxl6RN9GQutBwrnF0F5IysReTEAfEJF64MrJFLYqY5AkJRQI 2xgRKEYu5aWFMmP0XrDOHLwv4jDLGsRT+aBjDQxWrdy0T+o638ufKuLg/h7Z9q4AUs VtcNl3SiLqfviRxagf1K28s8+nR07AwzNrB6k+9Szvx1yBpPYXjVsH3xiYq6B2ZPHt 6sieTww5Ii77AfMaCq+i62OxRpjUhzA2BDd4ueNIqLOOucCuRqCm7D29dq6qn7zsRN qOb4xwrTSrorQ== Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 64654600EA for ; Wed, 10 Aug 2022 17:03:57 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="l8ytys5c"; dkim-atps=neutral Received: by mail-pg1-x536.google.com with SMTP id s206so14604721pgs.3 for ; Wed, 10 Aug 2022 08:03:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=3FCFVU6NTTd1dlJ67fPs2dA/naYN3spmswWxCNJ9r4E=; b=l8ytys5cWc4TSbmR12xjP4TLIuM/0vbBhabYn9ALRdTREXkC9qo0yNNF7q7YcT5mkz w5LBspXvhZBMr8KdSUllaSY0DLnPV9nulE2V6oSge6xOFdDlQ94Z6tOPEpXQ+xZQ8U2m k51mOonhKEp1jgN6YjDLLy39h4xy08WsHxaNQdAqmbFb6fDMcoJQlHOnDpUVmE/5anJT OCUc1h0tpVUTbkVxqtu+jqT358H/ma744kwCL1w8uqMALvxwy7qUqLuU8fQdqRoeBb5d pq8Ll61UEPsOnIUrOXhS9sSHrnw8q5y1Ft4m3B+E5CLvmSYvxMEaBE3NPMfb76rw+5aG UWag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=3FCFVU6NTTd1dlJ67fPs2dA/naYN3spmswWxCNJ9r4E=; b=jeDb52Y20rNO3YcjmQW2+0HsKQbqgBsqb0PLPv/z99FvDQ1vO3bm7ZX7xo90WQH8Pp DDrcEsYnh1LuB/smVM89LEoT0ILpD4NHRNXHosfnI/4HxZdLqfZudTlqIiyK1xMUhR8B cP6mJLhaBcHQWQsiJ592m4PrlnhwKx0zf0cA2sx8ANxx1oQpgvqwprmVv8uw8WneZr+u k4XHBjX1eOM3bQap8p3vJEslpl6TydVO60XEbVjdTyBNIHaVwkarbrxpn7mbMZ1aJxyC qC3TrrJCjWcpOfaSI7fmZBbzah7fE8f5ehWVof/1OWJxtyd1gdNQ6iW88ho4k9hBQ50p T45Q== X-Gm-Message-State: ACgBeo1iLmdQyXnWL1IUiovOZB3Lg/1/E8C6Bp0Ntn0H45x8mYXbTFwr 2GDurjAlViop7y3+u2JebUEZrJfrR2Q= X-Google-Smtp-Source: AA6agR7zsmMItD51HeA5YHbryVWXHR4CMDWQJKOAlhq0QU68jgF6GU5z+VYKrZ3OF8qIZHkcsxDxpQ== X-Received: by 2002:a62:1d86:0:b0:52d:9df0:2151 with SMTP id d128-20020a621d86000000b0052d9df02151mr27283466pfd.33.1660143835416; Wed, 10 Aug 2022 08:03:55 -0700 (PDT) Received: from localhost.localdomain ([2404:bd00:3:d2bc:2a55:4cae:bf8f:f4ed]) by smtp.gmail.com with ESMTPSA id b3-20020a1709027e0300b0016f1319d2a7sm12882624plm.297.2022.08.10.08.03.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Aug 2022 08:03:54 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Wed, 10 Aug 2022 20:33:41 +0530 Message-Id: <20220810150349.414043-1-utkarsh02t@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v8 0/8] Introduce capture scripts to qcam X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Utkarsh Tiwari via libcamera-devel From: Utkarsh Tiwari Reply-To: Utkarsh Tiwari Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Difference from v8: 1. Fixes the commit message in 1/8 2. Removes various useless headers in cam_select_dialog.h 3. The cameraSelectDialog_ is now only created once in 6/8 4. scriptPathLabel_ now has permanent parent captureWidget Each patch include their differences from previous versions. Difference from v6 : 1. This series now merges https://lists.libcamera.org/pipermail/libcamera-devel/2022-August/033137.html 2. The capture script button now lives in the CameraSelectorDialog 3. We now show the capture selected scripts path 4. Now the implementation of CameraSelectorDialog lives in it .cpp Normal Introduction: Hi, This series aims to add a Dialog box which can be used to select camera while at startup and trying to switch cameras. The series first adds the dialog to be used just for selection of camera at startup and then moves on to replace the current QCombBox in favour of the dialog box. We already got the ability to load capture scripts to run the capture sessions in cam. This is patch series introduces both a GUI way and a cmdline way to load the capture script in qcam. With this we get the ability to load a capture script and to stop a running one. It utilizes the parser in cam. A Screenshot : https://pasteboard.co/mO811IF3RQtk.png Utkarsh Tiwari (8): qcam: Use QDialog for selection of cameras at startup qcam: Support Hotplug for Camera Selection Dialog qcam: MainWindow: Replace cameraCombo_ with CameraSelectorDialog qcam: CamSelectDialog: Display Location and Model propety of camera qcam: Queue requests only through MainWindow::queueRequest() qcam: CamSelectDialog: Add capture script button qcam: CamSelectDialog: Display Capture script path qcam: Add --script to load capture script src/qcam/cam_select_dialog.cpp | 205 +++++++++++++++++++++++++++++++++ src/qcam/cam_select_dialog.h | 71 ++++++++++++ src/qcam/main.cpp | 3 + src/qcam/main_window.cpp | 161 ++++++++++++++++++-------- src/qcam/main_window.h | 20 +++- src/qcam/meson.build | 4 + 6 files changed, 413 insertions(+), 51 deletions(-) create mode 100644 src/qcam/cam_select_dialog.cpp create mode 100644 src/qcam/cam_select_dialog.h