From patchwork Sat Aug 6 19:04:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Utkarsh Tiwari X-Patchwork-Id: 16993 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B0797BE173 for ; Sat, 6 Aug 2022 19:04:52 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CE4F963328; Sat, 6 Aug 2022 21:04:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1659812691; bh=GDtrlosmy3p+KA/bJZnd9AaftjnwfSU6RG6Qas+6E6g=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=PGUuY3HD+imHoDmbcXjbSyXtgmQt/oOpGeZma4/Lu43TKuEeafokbmyYP/c3Pb4uy UZAX0bjAt4uavFty8BaywHYyw6spSghOsG+cLQytLJrunNh3G+l4V5JUVBg+MyDQyi TIPbbS0O+YwdbTJyd4pO0KmsyuPGIrQtQTqhiV96Lhgmpk24UT13fJT/Xz1ZyjZhTK pBR2mIq/TB8ytPTUl22IAtthIpm2/E+uktUeIrCoSyiOJ3nS6oWOQqMRUKfCJq96gc KbW4s4soS/Ite1tf19RpKVE/OMhLCClzvetlfYjcUolngShQ2BWJfmQcNAcTf1Oo5/ HfmH1u6O1/eTg== Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DE305603EF for ; Sat, 6 Aug 2022 21:04:49 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="f1MxM1nj"; dkim-atps=neutral Received: by mail-pj1-x1032.google.com with SMTP id t22so5531729pjy.1 for ; Sat, 06 Aug 2022 12:04:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=HNcdfBYhud5G5Y8Vp2ZIaFDSerPhdui0ZPQ81k3qXUY=; b=f1MxM1njRTI5JA/d5rC78OIcK9TQrvgIUHXb3DknEY/WopHgpRZGvaeHByR7bpl620 Z4uhVXkkh98ntJ0evaUJnxX41OmM3N2jhkxFaK1Eszix8PlgC0Ou8CnUHBklr7Ts2alz 1ZL5Upl1ox8RTmXpPLUwHfV1roryWzn6Qe6qlaAt144iQY9Y4jlFbitBIJZApjWFQiEo NQAOgYjv3jiFCtokX9PIdrSEF3b+PUUKqAcxw7ZuMRJ693kbuiUSobB+4/GU+XT7dFLn Nu7MHNROXw2Fb9E7fojRyvT9KpBNL/n2vGgNS+kjH19LEE1FoQyUGzM9nWQYAN3Bw1/R H3WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=HNcdfBYhud5G5Y8Vp2ZIaFDSerPhdui0ZPQ81k3qXUY=; b=vDKIHBY89uCkD9qidZQUBhZ8cuxMp/CzFqCc7wb5el9N8ycfC06hsnbz1XVEc5zSli rt5j/57iBsch5T3fhtOdPdZtZChyh7rOSTmd6TExQBduBWH4hswuJK9N6oILag4C6QFQ scdgfIOr11fZwyR9V77QjX4UlRBMIMU155lxtbsTxxEHvl1eW4/9bs13hAsWXbD9oa9r iznt9qyWYPIshaFAY9Wlo6Fxvb9YgBuACPFoOrfgQO8TaUdCUJWg/rFZnpSk/xC6zeXE LndaVSvc1w3pk7oKlXOZKtLODy2YVhK+lsqQHk+nDvxYqBkctbrwnq0lT6/1olRInnJL Yp+g== X-Gm-Message-State: ACgBeo0XYcWarFQDBeECQ5K1QObdmSFvsxecDNfj5R37cRLBr8jtlvWh rbYFEzwzFKpcsv5Shgw+sFZ611SWmVA= X-Google-Smtp-Source: AA6agR7mpVg68Kezt4vUqmPyWxgvZBQ1dvwThLaHNXrxix8WwFrJZLL9c7MVLfxe67nn6mTCib2zmA== X-Received: by 2002:a17:90a:d585:b0:1f4:f9a5:22a9 with SMTP id v5-20020a17090ad58500b001f4f9a522a9mr22179647pju.49.1659812687753; Sat, 06 Aug 2022 12:04:47 -0700 (PDT) Received: from localhost.localdomain ([2404:bd00:3:daa9:adf3:a099:1bff:e55]) by smtp.gmail.com with ESMTPSA id z17-20020aa79911000000b0052f20d70845sm406025pff.150.2022.08.06.12.04.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Aug 2022 12:04:47 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Sun, 7 Aug 2022 00:34:29 +0530 Message-Id: <20220806190433.59128-1-utkarsh02t@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/4] Improve Camera Selection GUI in QCam X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Utkarsh Tiwari via libcamera-devel From: Utkarsh Tiwari Reply-To: Utkarsh Tiwari Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Difference from v1 : 1. The CameraSelectionDialog now lives in his own class. 2. The last two commits are interchanged (for no reason). Due to moving it in a class the commits are quite changed in code but remained same in nature. But I would be dropping any previous review tags. Normal Introduction: Hi, This series aims to add a Dialog box which can be used to select camera while at startup and trying to switch cameras. The series first adds the dialog to be used just for selection of camera at startup and then moves on to replace the current QCombBox in favour of the dialog box. A Screenshot : https://pasteboard.co/bpbcDniGx1qd.png Utkarsh Tiwari (4): qcam: Use QDialog for selection of cameras at startup qcam: Support Hotplug for Camera Selection Dialog qcam: MainWindow: Replace cameraCombo_ with camSelectDialog qcam: CamSelectDialog: Display Location and Model propety of camera src/qcam/cam_select_dialog.h | 137 +++++++++++++++++++++++++++++++++++ src/qcam/main_window.cpp | 57 +++++++-------- src/qcam/main_window.h | 9 ++- src/qcam/meson.build | 1 + 4 files changed, 170 insertions(+), 34 deletions(-) create mode 100644 src/qcam/cam_select_dialog.h