From patchwork Fri Aug 5 13:53:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 16975 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id AB708C3272 for ; Fri, 5 Aug 2022 13:53:22 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id EE8AC6332B; Fri, 5 Aug 2022 15:53:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1659707602; bh=3y1ZYl8vc9oa1hMf8SQYD262PwQ8T9xR/ikWq0Tw2pI=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=NI4oA670b98MFcTH8BNZz9/5u6X3t2lN+4MDNXbEOxBirKkP4Ifdg99rzN+/OfQtl 0yU28IPMf3XZw7nnIYcavgtBS1edccaagQpZA/UeLwYaCpf2hWCd4iKRThvugLWcSG 89aJQQrfTIE4KN7Z86LbPAXTRNXkPsL+r4JhiURvjgPzpiR6mtuOHk+QvOO+zCFKeN 2FtkM2/fc2b1UAlrVVho9FFmhoUYLVIEl9IhKAQirpyUB1TWdvn4BCQECEVYWwtBlp b2QvIh69gPmNpxH6M8/UI2BCMshmza1eYod6bGRo7h4Fa1a37lJNYsWdQ4kBLIWYFA dw4oN2dgdq6Rg== Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C6917603E4 for ; Fri, 5 Aug 2022 15:53:20 +0200 (CEST) Received: (Authenticated sender: jacopo@jmondi.org) by mail.gandi.net (Postfix) with ESMTPSA id E558B1C0006; Fri, 5 Aug 2022 13:53:19 +0000 (UTC) To: libcamera-devel@lists.libcamera.org Date: Fri, 5 Aug 2022 15:53:02 +0200 Message-Id: <20220805135312.47497-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 00/10] libcamera: Align IPU3 and RKISP1 interfaces X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jacopo Mondi via libcamera-devel From: Jacopo Mondi Reply-To: Jacopo Mondi Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Resume Kieran's RFC series at https://patchwork.libcamera.org/project/libcamera/list/?series=3313 I have here rebased, as some changes part of the series already went in, and addressed review comments on v1. Tested on IPU3 and RkISP1 without noticeable differences compared to master. Thanks j Kieran Bingham via libcamera-devel (8): libcamera: pipeline: uvcvideo: Report control errors libcamera: request: Add PFCError flag ipa: rkisp1: Rename frameContext to activeState ipa: libipa: Provide a common base for FrameContexts ipa: rkisp1: Convert to use the FCQueue ipa: libipa: algorithm: prepare(): Pass frame and frame Context ipa: libipa: algorithm: process(): Pass frame number ipa: libipa: algorithm: queueRequest(): Pass frame context Paul Elder (1): libcamera: request: Add support for error flags Umang Jain (1): ipa: libipa: Introduce FrameContextQueue include/libcamera/internal/request.h | 4 + include/libcamera/request.h | 10 ++ src/ipa/ipu3/algorithms/af.cpp | 10 +- src/ipa/ipu3/algorithms/af.h | 8 +- src/ipa/ipu3/algorithms/agc.cpp | 11 +- src/ipa/ipu3/algorithms/agc.h | 5 +- src/ipa/ipu3/algorithms/awb.cpp | 9 +- src/ipa/ipu3/algorithms/awb.h | 8 +- src/ipa/ipu3/algorithms/blc.cpp | 6 +- src/ipa/ipu3/algorithms/blc.h | 4 +- src/ipa/ipu3/algorithms/tone_mapping.cpp | 9 +- src/ipa/ipu3/algorithms/tone_mapping.h | 6 +- src/ipa/ipu3/ipa_context.cpp | 43 +----- src/ipa/ipu3/ipa_context.h | 16 +-- src/ipa/ipu3/ipu3.cpp | 23 ++-- src/ipa/ipu3/module.h | 2 +- src/ipa/libipa/algorithm.cpp | 4 + src/ipa/libipa/algorithm.h | 6 +- src/ipa/libipa/fc_queue.cpp | 133 +++++++++++++++++++ src/ipa/libipa/fc_queue.h | 114 ++++++++++++++++ src/ipa/libipa/meson.build | 2 + src/ipa/rkisp1/algorithms/agc.cpp | 28 ++-- src/ipa/rkisp1/algorithms/agc.h | 7 +- src/ipa/rkisp1/algorithms/awb.cpp | 42 +++--- src/ipa/rkisp1/algorithms/awb.h | 7 +- src/ipa/rkisp1/algorithms/blc.cpp | 4 +- src/ipa/rkisp1/algorithms/blc.h | 4 +- src/ipa/rkisp1/algorithms/cproc.cpp | 7 +- src/ipa/rkisp1/algorithms/cproc.h | 5 +- src/ipa/rkisp1/algorithms/dpcc.cpp | 4 +- src/ipa/rkisp1/algorithms/dpcc.h | 4 +- src/ipa/rkisp1/algorithms/filter.cpp | 10 +- src/ipa/rkisp1/algorithms/filter.h | 5 +- src/ipa/rkisp1/algorithms/gsl.cpp | 4 +- src/ipa/rkisp1/algorithms/gsl.h | 4 +- src/ipa/rkisp1/algorithms/lsc.cpp | 4 +- src/ipa/rkisp1/algorithms/lsc.h | 4 +- src/ipa/rkisp1/ipa_context.h | 11 +- src/ipa/rkisp1/module.h | 2 +- src/ipa/rkisp1/rkisp1.cpp | 36 +++-- src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 7 +- src/libcamera/request.cpp | 76 ++++++++++- 42 files changed, 556 insertions(+), 152 deletions(-) create mode 100644 src/ipa/libipa/fc_queue.cpp create mode 100644 src/ipa/libipa/fc_queue.h --- 2.37.1