From patchwork Fri Jul 22 07:05:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harvey Yang X-Patchwork-Id: 16729 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7E352BE173 for ; Fri, 22 Jul 2022 07:06:11 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CEDE76330F; Fri, 22 Jul 2022 09:06:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1658473570; bh=z2l24ifED42hCEXtTRLYPugbPbMEda1pqOHxibQOG7s=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=tiRgMIekrAT5l5sA4sq4jsP+cHjE6YPNrc39p0in1ypi3ZYtXVP0ugB12pA/q/Pns Eb4CdFdSo0EiOkrD3dhVY6g6CkwZVlxRtxuLtmhdTqPoPiVyeUGfwxR/unXp7hDR6X PT/0OaEl5Qs0XTydBkg6S/A+oivODiwAoaFgWlqhY9jUXmOHMXoYWevV0DRHDiEuPU 7LMwKYRZOVHsVPfvSHJQ3TMqbqE/Nz5GZvM7+vtlygwJx1q6bLlh9abASN2xZIWwAM +ya35kA+xHESyLvGt/3zsG0i+8kTGoUPEM9Kb/cuGmyvIGjwKTuXqz+60KAycLizpf lZOL1qB2oZMJQ== Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 778DA6330B for ; Fri, 22 Jul 2022 09:06:08 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="exgZtvuu"; dkim-atps=neutral Received: by mail-pg1-x530.google.com with SMTP id bf13so3696644pgb.11 for ; Fri, 22 Jul 2022 00:06:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Yy1MOB7ChFdl2p9eZpuAtKFL3KiE4VOh1KEHyE4m+pk=; b=exgZtvuuAZWi0Jje5tEkdsLtw3VhNKcHhI+JZXW6CrymUOTIQHE9tEHEN7y3EizXTQ gfV2o8VPEhwc6d+Ukp7LgIp+wHFSMaziAJGcVtWeK1C+NziLX7GqUo7czA7fEnXbujVa 6VoeltCyL+tlctaYYkQBY2Kdujr2Qd+/ta6To= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Yy1MOB7ChFdl2p9eZpuAtKFL3KiE4VOh1KEHyE4m+pk=; b=yfkuP/AzR93yoId89CLRBeED1ycRKE7JM6LxgGFsPrgcGzBX9srcizGqGGk/9bcIjZ NOTxJQTFn6UhQqxss+elGgEeexyEHuctXd06v8lceTYu+c2lSZv63FYjEtdGXTMLIV0v 3qKFmuMokxe0T1z4yG5US37adsrpzCI8H5DyiaLToIQpKf/G15/+hp39nP73aC0SinVE MJKWpduRTQPpK3JJ66oQVvfYu5rfhP5UyTqfP4sr4sKVDHEmadvtNn1XlOT7ZoEdm8Cb +MI1FD14VKBaClsE/PuYIFFoVaI+e553vuwMcy4Lhx0W/aWLtckjLAO2+qXeYwCV9faj 8QLw== X-Gm-Message-State: AJIora/uLHKPbu6DMpPkdlcu/2edt3S2c0uqo8d/NwPxsA2Z+rcCBGVH VNz8gKH9qdJEItKwZYOBc5NxNa34qiGqWw== X-Google-Smtp-Source: AGRyM1skDI2pAIWjvYKYKxW/atSNUJzye6JgkhlZW8zC+S2CcOV3FaXdWrZa6RM0bA70UmuelyDwrw== X-Received: by 2002:a63:4042:0:b0:411:bbfe:e736 with SMTP id n63-20020a634042000000b00411bbfee736mr1981381pga.1.1658473566485; Fri, 22 Jul 2022 00:06:06 -0700 (PDT) Received: from chenghaoyang-low.c.googlers.com.com (231.137.80.34.bc.googleusercontent.com. [34.80.137.231]) by smtp.gmail.com with ESMTPSA id gb17-20020a17090b061100b001f1694dafb1sm2550114pjb.44.2022.07.22.00.06.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jul 2022 00:06:05 -0700 (PDT) X-Google-Original-From: Harvey Yang To: libcamera-devel@lists.libcamera.org Date: Fri, 22 Jul 2022 07:05:59 +0000 Message-Id: <20220722070600.2949278-1-chenghaoyang@google.com> X-Mailer: git-send-email 2.37.1.359.gd136c6c3e2-goog MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/1] Android adaptor thumbnail buffer lifetime issue X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Harvey Yang via libcamera-devel From: Harvey Yang Reply-To: Harvey Yang Cc: Harvey Yang Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi all, Han-lin found that soraka-libcamera cannot pass a cros-camera test: Camera3SimpleStillCaptureTest.JpegExifTest, as the output thumbnail is not a JPEG file. The root cause is the thumbnail buffer's lifetime issue. Thanks for Umang's & Laurent's review. I followed most of your suggestions and sent this PATCH v2. Please check :) BR, Harvey Harvey Yang (1): Fix Android adaptor thumbnail buffer lifetime src/android/jpeg/exif.cpp | 13 +++++-------- src/android/jpeg/exif.h | 5 ++++- src/android/jpeg/post_processor_jpeg.cpp | 2 +- 3 files changed, 10 insertions(+), 10 deletions(-)