From patchwork Tue Jul 19 12:10:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 16687 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B7EF3BE173 for ; Tue, 19 Jul 2022 12:10:18 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 126C263312; Tue, 19 Jul 2022 14:10:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1658232618; bh=igIe/JlwpLipCqTSTuzX7Uq/fOuUZ8cTgffdvEMaCHM=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=UJU6xoDeVE6FY2Yjv72Rpm2bxdWJbHWQZWiDp77rIe3S2tbrhxYjEXGlgzzLKXohW CLCFSKlU5pTJNyFAcraqOz+R6SM4iRA2Q4KqhpSez2u9U95XmTa6oKCoE1HqiCSXaU qsgFrFgqRTfAP1iRgGoV2A/BktNHpJlrWD/Pp6npjlYthDhej2FDh0Xh0LWg8jA2Jp 8LpwzFEbfPtiCLrs/gSoYUJr6QQChMsQ7qDOTHuGPZmrx67uolLWmfzFePkTvkYTF/ co8kziu6v0u6zZ76xj/F3R+maVtwRvxoCEK8XN9QWnjrGK/CdO9jHHUdbIma5ieQok cSxwOvH470IeA== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 60BFE603F4 for ; Tue, 19 Jul 2022 14:10:16 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="KD/Vag5O"; dkim-atps=neutral Received: from pyrite.rasen.tech (softbank036240121080.bbtec.net [36.240.121.80]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9CAB96EE; Tue, 19 Jul 2022 14:10:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1658232615; bh=igIe/JlwpLipCqTSTuzX7Uq/fOuUZ8cTgffdvEMaCHM=; h=From:To:Cc:Subject:Date:From; b=KD/Vag5OYEvjPpxeBW7+LhUJQIHM2U8WplIjVU/oFVzsZLtYd2/JpSXPGzFgxOs1k zkMyNRHxl3XYH+3+3X2rXxD8kienfiqf/mrLMOiO8z03aTLCsjpz6gto61xK3SmfXm 6hgomJAqrpEIZsTl8z/1AIafqRx/CR07FDoEBkKw= To: libcamera-devel@lists.libcamera.org Date: Tue, 19 Jul 2022 21:10:01 +0900 Message-Id: <20220719121003.1829916-1-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [libcamera-devel] [RFC PATCH 0/2] rkisp1: Get supported formats from driver X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Paul Elder via libcamera-devel From: Paul Elder Reply-To: Paul Elder Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This series makes the rkisp1 pipeline get the list of supported formats from the V4L2 device, as opposed to hardcoding it as before. This lets us add support for, notably, UYVY without having to worry about driver versions. The current implementation of V4L2VideoDevice prevents this from working as-is, so it is massaged in patch 1. This series also obviously deprecates the series that I sent earlier today: v3 "pipeline: rkisp1: Support devices without self path". That series was meant to be a quick fix for the formats that we know are supported for all versions of the driver. Paul Elder (2): libcamera: v4l2_videodevice: Get formats even if no framesizes pipeline: rkisp1: Query the driver for formats include/libcamera/internal/v4l2_videodevice.h | 2 +- src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 50 +++++++++---------- src/libcamera/pipeline/rkisp1/rkisp1_path.h | 6 ++- src/libcamera/v4l2_videodevice.cpp | 12 +++-- 4 files changed, 38 insertions(+), 32 deletions(-)