From patchwork Wed Jul 6 09:06:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 16555 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4C27DBE173 for ; Wed, 6 Jul 2022 09:06:49 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8BC1E60400; Wed, 6 Jul 2022 11:06:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1657098408; bh=a16m8ppH5Vcp9TRKk7SQQCPXTF3QjFDwDZaDx2yP9q8=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=dKRPJg0HFy2nIw+q9QTa8a/DNj9vwGASv3cV8kSbgAgE+7Aym41pMHliQ8TbM6hxX xS3lduwIfE8KFpFAXivoUBOwX49fJw2+/bz1NXiFSF0usP6eKSCjo1XB+hAfUy996A vn+oJUOUas976Z4N3eZWXz9/pXVtfoJ8kxZpQt6IF8jQcD0BgWgIsx1e0Ddc4rOtou QTX+7+ebhgcMSpSI/V8iFttyDML4cM3YYFYwTs77QRb0rzmN3FWzRzR0KYQ+sF1MSO 2t56HRgrqL/h7e6sY6N5RoRU48Z5+YUvP1xsI4OqOPCtiDFEzuf3eyUJYJqZElebCe Q1ru7yOXmNWVg== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A84B60400 for ; Wed, 6 Jul 2022 11:06:47 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ko5OM+c5"; dkim-atps=neutral Received: from Monstersaurus.ksquared.org.uk.beta.tailscale.net (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D1B2F30A; Wed, 6 Jul 2022 11:06:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1657098407; bh=a16m8ppH5Vcp9TRKk7SQQCPXTF3QjFDwDZaDx2yP9q8=; h=From:To:Cc:Subject:Date:From; b=ko5OM+c5qgx6IA7lOVWLjx4xhukYSFdgsczf9UpW08Ohalht9grg9DevzVKXOq0ik LypidgTojWkVeefqjkAQQ8vwRSZ0wDoAQwx+ET7vIN85Ydk14h9kwBb0CSAoreW9e3 seYyR7XrpjsUtdA/wi6SfmAn6JSMTyzvKbnvH4B4= To: libcamera devel Date: Wed, 6 Jul 2022 10:06:39 +0100 Message-Id: <20220706090642.2750987-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/3] qcam: Support 'X'RGB formats X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Kieran Bingham via libcamera-devel From: Kieran Bingham Reply-To: Kieran Bingham Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" While validating the QCam implementation on ARGB formats to support other ongoing developments, I discovered that the XRGB and RGBX style formats were not supported by qcam, while they could easily be. This series adds the X variants (where the alpha channel is present but invalid or ignored) to qcam to support rendering of those formats when provided by hardware. The Qt native format support is updated to use the RGBX variant to indicate the alpha channel should be ignored. Without this, the image data is transparent, and while running - it appears as if no image is presented. Kieran Bingham (3): qcam: viewfinder_qt: Fix include orders qcam: format_converter: Support X RGB variants qcam: viewfinder_qt: Support X RGB variants src/qcam/format_converter.cpp | 4 ++++ src/qcam/viewfinder_qt.cpp | 9 ++++++--- 2 files changed, 10 insertions(+), 3 deletions(-)