From patchwork Wed Jun 22 10:20:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 16306 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 68563BD808 for ; Wed, 22 Jun 2022 10:21:00 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3743965636; Wed, 22 Jun 2022 12:20:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1655893259; bh=pSirsqL9Mildg3rspcRlgZlnmt3kzoODIbSLMVEMHNU=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=ZKdHNNe5AyfBjfpvd5DAPYz91hFCeaEW9k471/PNaELxzz0P2sA89BmCc3V4ojVIJ l4DW2AHYjbaZW1HeD/cm/Ee+FykQwGqurvUopCUFnXwhVS7XsPWGrgXJv6VBsYU3OS aaqaSlMvQztW7UVBENDlj4Ij/WB22+Cv50HPeHnPo5N89yc3GvBrycM7ea3Oso4Zbe MJfdxByvyRsvtzEH/QTiqk6aiuSCGipEFaU9yUDqsWLufG6431ijLSoNRQt3xJPhW7 MdzI0iJDDbnlQOursrlskLiswfdqIlOtGUSPpniC+97mQVUgInsVGiiO8gcUPGkeGf KgOyx5gRBmwGg== Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0869E61FB2 for ; Wed, 22 Jun 2022 12:20:56 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="r7m4fiVb"; dkim-atps=neutral Received: by mail-wr1-x436.google.com with SMTP id v14so22716167wra.5 for ; Wed, 22 Jun 2022 03:20:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ibzTcj61J8/z2p4u95ljPE4vFpwf3hW3Mo9UIY2P07E=; b=r7m4fiVbLYgac5qFdlPDkQMMcXXwqKTEMRHcoN8IQyBTlaXraEpfblmISp5Lwhexid 7/obODe14ZAf6e7dkEWgodBAA6HBewdGVn7Vg1PGSGvzuH1XFq8EY9O3+Fl5iTsAzLXl 0F4FYv6FOIRHJRGQSHULUBV0+xuDMZno4y+n8hTk7MtQsoDJDUIOUgu+qUqCXHFO0J1y QBcnn8Nwdjz3skN7qwYL+z+JKem6ZoIyb3jrWh0pqyphlx8uY8UqzTJOD4mSmcJjEMIM 86xsiBFi4R9imELR54qWyUgnrCKD3jUXGLu+c+rvnBe7ygJe5v714P3XIUffU6sKg23H lk5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ibzTcj61J8/z2p4u95ljPE4vFpwf3hW3Mo9UIY2P07E=; b=pfh5CytO22AS24gwroFNBPIMRJsdzOKTmS4JdOT3yVhjkuE47FC4gwM6AHjar6HE2t UNzd9ziPMghd+x60qpAseXHWjNzCliIxn5bMsobu2ul2lsVdvUTQBG5YAYtcVvs/Daga MvOg59T+LkjyEaGMPT8JJcrB7nnGCdzZ0vKuIrVHUV6QPakN5As3M8EB/61HB42NDaHk egIMWgIrhFLtx4sSSoc/F2sc9nHHo6EPAktusq+jiTdCegQP4b9FCSZfebuUx1bRC4aW eQb9ZpB7cOm3tZ1d8kwwEmuGo9P1XFX8cJd6lMHAyshn1I8QU/5zKLB5UpKYDXbxok/O tWZA== X-Gm-Message-State: AJIora9RWvKEkWwX0CCAZju2oM4JtNCFKxdgA+kz4GjsT64OuwijMj24 qLpi/3tuTr+h5XJkcDmXckz09zQKC8wHjK3S X-Google-Smtp-Source: AGRyM1tjJIy5vNoHfWPLFEv91JqsGFTi5V3tExePz/yfR5qZztEp1+vppIn+ITYO3upm3znBR8FEdg== X-Received: by 2002:a5d:570e:0:b0:21b:8aec:3e69 with SMTP id a14-20020a5d570e000000b0021b8aec3e69mr2517080wrv.177.1655893256182; Wed, 22 Jun 2022 03:20:56 -0700 (PDT) Received: from naush-laptop.localdomain ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id h204-20020a1c21d5000000b0039c693a54ecsm26849423wmh.23.2022.06.22.03.20.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jun 2022 03:20:55 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Wed, 22 Jun 2022 11:20:44 +0100 Message-Id: <20220622102047.22492-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/3] Correct ControlInfoMap from the IPA X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Naushir Patuck via libcamera-devel From: Naushir Patuck Reply-To: Naushir Patuck Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, In v3 of this series, I've made the following changes: - Added the Bug tag in patch 1/3. - Fix typo in commit message in patch 2/3. - Patch 2/3 also keeps some default values for ExposureTime, AnalogeGain and FrameDuration controls during the ipa::init() as requested. - Use the frame duration to calculate the correct exposure time limit in patch 2/3. I've left the code using the ControlInfoMap::Map mechanism to add values to a ControlInfoMap container. At a later date, I may attempt to change this by adding a ControlInfoMap::add() member function. But if this API is to be replaced by something else, it may not be worth it...? Regards, Naush Naushir Patuck (3): pipeline: ipa: raspberrypi: Move ControlInfoMap to the IPA pipeline: ipa: raspberrypi: Correctly report available control limits pipeline: raspberrypi: Advertise ScalerCrop from the pipeline handler include/libcamera/ipa/raspberrypi.h | 55 ---------------- include/libcamera/ipa/raspberrypi.mojom | 8 ++- src/ipa/raspberrypi/raspberrypi.cpp | 66 +++++++++++++++++-- .../pipeline/raspberrypi/raspberrypi.cpp | 41 +++++++----- .../pipeline/raspberrypi/rpi_stream.h | 1 - 5 files changed, 92 insertions(+), 79 deletions(-) delete mode 100644 include/libcamera/ipa/raspberrypi.h