From patchwork Mon Jun 20 16:50:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 16287 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CEC7ABE173 for ; Mon, 20 Jun 2022 16:50:37 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8340165635; Mon, 20 Jun 2022 18:50:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1655743837; bh=aEQfRcpkCUUdMeel50bFM6ZIcdcyXvXH75p+sQHXUBA=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=pvsZ0QrwrdSrFz2Wf3p+/kSLE5ZBDyfWdWZrSUJPv04nHdb9z+XYMcwTDeF3HH7OA pLNwhUv4tehNPjbB26kXc+DT4xRhOfru/MxC3hloBzMuO/PjvVTkRCjFqe2x+bzjMq aIC3HeQKuZlTmlCHvE8H8x7BDfgeWNlw7O8Z/AVDj/b/A1PVqRSnTf1+2/VPGSa/yq 1aULlGp4TFy0Bek8cXQvzaMTIBsekftdaSZ1u0bYB8cSnQ+Iw7DuLVt+z67vkxlwai cNpUTuQ1D3Lux6OkrVNubE6gF/0GjboAj4n+825QgmLFE4q5pcsltruXPX/SF0Ot/N wfkmEzfDIZHlA== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3831560498 for ; Mon, 20 Jun 2022 18:50:36 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="f+aSBxyr"; dkim-atps=neutral Received: from perceval.ideasonboard.com (unknown [IPv6:2401:4900:1f3f:e389:cb58:4104:f66:a571]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1E26B25B; Mon, 20 Jun 2022 18:50:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1655743835; bh=aEQfRcpkCUUdMeel50bFM6ZIcdcyXvXH75p+sQHXUBA=; h=From:To:Cc:Subject:Date:From; b=f+aSBxyry+xwUHFuIwNI8XdMm4OA0JP8wFeWhHhfKeeeHV+/6If0gKbxTA+3Cjzx1 y46VxnSjAXn/xlEJGpPRNNC1SqxIqL0P03SbXqPR1KBgRNYqI5Zt3YI3trykXay5EZ cW8oihbgz9rfUTYntq2mTYWfCNBULxz8Y90tVOMg= To: libcamera-devel@lists.libcamera.org Date: Mon, 20 Jun 2022 22:20:22 +0530 Message-Id: <20220620165027.549085-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/5] Apply clang thread safety annotation libcamera-core and v4l2 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Umang Jain via libcamera-devel From: Umang Jain Reply-To: Umang Jain Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Ressurcting the continuation of thread safety annotation by Hiro. I have excluded two fixes from the series which are submitted standalone on the list as: - libcamera: base: thread: Protect exitCode by mutex in exit() - libcamera: camera_manager: Protect cameras_ by mutex in cleanup() Original cover letter: This applies clang thread safety annotations to libcamera/base, and libcamera/camera_manager and v4l2. I cannot annotate Signal and some variables in thread.cpp is because the used Mutexes are invisible from their header files. Hirokazu Honda (5): libcamera: base: semaphore: Apply clang thread safety annotation libcamera: base: thread: Apply clang thread safety annotation libcamera: camera_manager: Apply clang thread safety annotation v4l2: v4l2_camera_proxy: Apply clang thread safety annotation v4l2: v4l2_camera: Apply clang thread safety annotation include/libcamera/base/semaphore.h | 10 +++++----- src/libcamera/base/semaphore.cpp | 2 +- src/libcamera/base/thread.cpp | 22 +++++++++++++++------- src/libcamera/camera_manager.cpp | 17 +++++++++-------- src/v4l2/v4l2_camera.cpp | 5 ++--- src/v4l2/v4l2_camera.h | 14 ++++++++------ src/v4l2/v4l2_camera_proxy.h | 12 +++++++----- 7 files changed, 47 insertions(+), 35 deletions(-)