From patchwork Thu Jun 16 09:11:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 16234 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5F490BD808 for ; Thu, 16 Jun 2022 09:12:29 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8690665631; Thu, 16 Jun 2022 11:12:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1655370748; bh=HDHtbipgyaUsta40ua6BKVoLPyrZROMGccS+EOl+WQQ=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=bF0N0dzh5BzHQyAkHov6crGoTE6yq/AjzIIiAfpBmAB3wBM6XZdiOMyGVfPJL4+Bf XAM4H22Zxqfe5WSRQcSrAKBxsFi7mn8Hv5hmFXkbtfP1gleLAWSzwlF4o2VfKnz1zL r3QYry/jnb3UgoV5u/q1PLN5x6u9BJmZTtfQIm6SasHWSio6T8hPiALUveBRNoJkHB diWX7rychg5NVApxeFUIVbyJGJIzaPrv6JpnhYxKu2fG2sol9x/uK6/7DtTnbnnU4B 2DjI7dTDIN3fKTg4PJ+/sfLqTIAeKFa4RiAKBDAw7asqgk37h+P77WuYHJetLDQT7T qRRtWV4q3LZaQ== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 71112601F1 for ; Thu, 16 Jun 2022 11:12:26 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="YeduVW5w"; dkim-atps=neutral Received: from tatooine.ideasonboard.com (unknown [IPv6:2a01:e0a:169:7140:64d1:a349:8ac7:1dd0]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BA65C898; Thu, 16 Jun 2022 11:12:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1655370745; bh=HDHtbipgyaUsta40ua6BKVoLPyrZROMGccS+EOl+WQQ=; h=From:To:Cc:Subject:Date:From; b=YeduVW5wj7XDdMFdRYYgGEl5lPs9IWM6vyjdBJhp9qxKqSlf0lXaoq5KpgP2IzQ0F /KaZnaAuhSgT00xsWd1yhJ5GAwK2zfqN7Rt11r7tpioT+DGzbYkK4O8l06EBABe3yk XvMUiMN0B3AA3QBiDEKauwPYKI/S9cS0O0cJDX4c= To: libcamera-devel@lists.libcamera.org Date: Thu, 16 Jun 2022 11:11:48 +0200 Message-Id: <20220616091148.67870-1-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [libcamera-devel] [RFC PATCH 0/1] IPU3 AWB gains correction X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jean-Michel Hautbois via libcamera-devel From: Jean-Michel Hautbois Reply-To: Jean-Michel Hautbois Cc: bingbu.cao@intel.com, sakari.ailus@linux.intel.com Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi there, Bingbu, Sakari, I cc'ed you because this patch is not aligned with the current documentation in the intel-ipu3.h file, could you have a look please ? The part which worries me is that the green gains should be 0 for the white balance to be correct which is not stated in the documentation at all. In order to demonstrate it I captured two frames, [1] is the actual SGo2 image quality, and [2] with this patch applied. [1]: https://pasteboard.co/hUcL4U6eyyAH.png [2]: https://pasteboard.co/2XIbkkL8kitl.png There is a very clear benefit, that's why I submit this RFC as I think it needs to be clarified :-). Thanks ! JM Jean-Michel Hautbois (1): ipa: ipu3: awb: Correct the coefficient factor src/ipa/ipu3/algorithms/awb.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)