From patchwork Sat Jun 4 21:11:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Rauch X-Patchwork-Id: 16170 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6DE3CBD160 for ; Sat, 4 Jun 2022 21:11:54 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6B15165639; Sat, 4 Jun 2022 23:11:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1654377113; bh=j/Wp4QwTAaSIuLqXrmf91AQAhGfQ9eo5wHBD1Palp8w=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=HvmpgoH+tPO3ZIOI/5v8tRNGMWhA1Lqvez31m4+jSnWvZSGk1NZ3CiAYsABc/bg+6 GolLXhrq2W4tmOulZVkq372FDYJ/yKWBUsztDqI6Uo30Fwc6TQkT4mZ3P38jW8iZvg BNUsuaRbbY1TM5Kt2YU1Wbf4fi/qYkiC+D1KkFwYtlu8G6OCvl2ax49ULtsjrjybJ7 VZFiqPWRvehqoHfOJsjYUOLFJwDohtho5HjYxXn9Z2j6mHtYHU52CyiCiIvEGG8IK4 DASSKdYLLLQkNbtStZIgmrD1Vwse1brVr5BmJlTDhHY20Kd7MtIxuAJV5vHInJ+H4b R0oEjXpGXfSvw== Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 79AAF633A6 for ; Sat, 4 Jun 2022 23:11:51 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=gmx.net header.i=@gmx.net header.b="JFY5CewW"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1654377111; bh=j/Wp4QwTAaSIuLqXrmf91AQAhGfQ9eo5wHBD1Palp8w=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=JFY5CewWPadFGSE4vVgpIuqpR7JSClAuoMyld1y8Y0jYwOx9V8A9CEJIiWx07Bzkk L+cIyWM/3uOL6FWzDzMa4ZwHLYgjD/EXOXUoswOnPLMdZ3fnrxVdtoXI37qc5+eN+j 7k0KFlSaKtW0PyfIS/NTeEOBRhaXds/s6KFiIKVY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.localdomain ([92.18.80.244]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Ml6qM-1nVzUA3wOC-00lYqt; Sat, 04 Jun 2022 23:11:51 +0200 To: libcamera-devel@lists.libcamera.org Date: Sat, 4 Jun 2022 22:11:43 +0100 Message-Id: <20220604211148.188421-1-Rauch.Christian@gmx.de> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:GwCvCEi+r4mBkY7vnkrLXuOiYUwMVXaZ4MXPgcY7/RfIMDWgDIW yqTgskwKUXEpruX6ETRZMUe3ny0z1qEhZUebwdyCEDd2oYxqwrb34WxlfIzMkAy6U+O5YCp BHQG9fva67P6QXDcdkeFUr5VFta0MU7IZr2zzsswjl4GpeiDVc01cD+ET75wJ4TZiP0z9Mf 8e/nnsHc5+6udIx2D6iww== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:6RKO7n2/BtI=:MtjdHUDsjuRn1rm+8nwFgN ocuyS6008KhBzmPa7eZeSOkNJJw2uJRwUYJkHUPfpxn1IgoFMnTfFATPyuj4xAduk4HMeoQ5F 4dUHpiQlSXxIzQLXX7dYEOxRCgsB2GmJMq3glZPi18hcmo9IFls2lmTAUGL4nDcGlsUlluc1P fuMq5YhqfAvqXueh+PGOXDBFIOk6BmLF0SXLPQu18GcIDncr0nhtkwt8AImdWeHB0E4vbuP4I 3cdwxyWdKbMDDuG6X0QELZlJeWMqP9Hjbj45J/5diT80xACVHO/Zew1PpPGEsbXObb1q55cX8 uylryEhVWldh8c5vhDk9gXG2+v8ICj3QqI/wx15B2pSm2dldLc1V71rlSoO+gYiw7w++ZVbsr tQNxgxZ1eOwwwODH3A8SXVTugMQ3qA1WOh2J/3mi2sY9WQhNZbP4nHjfazJwxvrLnZF49kmyH JGuCP8msXMeB6wM3C00tkb+N+9xYargcxSiTRDAz/ZkTwKEyi3EjPSD/1dcJXRxJWXjaD/+N7 M4902N5LsOxmOqVbfXhdJBflBUnfpEvzxPX2bLAI1CKnhppkroO+5IwoPtzKxh30jPxDuRQOv a77a8f6raqR+uv/FV9xfUBQBEOFkhgaS8FSTvHvRijeFhx4lNlK66/BZXGbiaxMwAckIHPode w/lSSW7BCY1ol+r4GnqVmxPhlEkeVkpT8e1pdl4vrsqRKzCRQsPR8yL/FJb4OXvLjGCz5RX+3 AHrkb9GQazI0FHYeiEV09yGtqs4UFo6bRjlQ9GpcDItGsCkbnQhiM0JE5VfA/WqT9n4joOlng ZeBnXBT7GA0vnOOGjDO7tSWnj0Kiajeb+/Sg5ZGjxaCDDZcCsWKiQ0pWzKWdbQnDxTpx2yDkB 4lcJijN2Hv36eEnGNbdjpeL4gcj4CgX3sytjC3cvX8+Rv5kI4Ae3eP/rozBvOBs5/xzfLO1Bh geeyE0Vd8m8c6azQ/YhXbE6YVzMCIUshQtN7ZD3OFKxipodASyhloxbz77NIl365L7htPG6v3 TAmrKbcja5Tmt+ZvYxSMPMVSL/Qh+z/iRlGhe0k5sW3WA9IAUulduveKu4GUPNNIdTT6yyFMU IYyeOvfFqzsOeuoz5NV3m6DTQYtxEQsDkE5XK2aQKFFp6TbuPz1ONznTA== Subject: [libcamera-devel] [PATCH v7 0/5] generate and use fixed-sized Span Control types X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christian Rauch via libcamera-devel From: Christian Rauch Reply-To: Christian Rauch Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, Compared to the previous version, this 1) avoids a couple of more "value_or" fallbacks if the validity of a control value or property was previously checked with "contains" and 2) avoids references to potential invalid control values or properties. The last point fixes compiler errors reported by clang. Best, Christian Rauch (5): libcamera: controls: Use std::optional to handle invalid control values libcamera: ipu3: Fix rogue whitespace libcamera: controls: Define size of array controls as a shape vector libcamera: controls: Generate fixed- and variable-sized Span Controls libcamera: controls: Apply explicit fixed-sized Span type casts include/libcamera/controls.h | 7 ++-- src/android/camera_capabilities.cpp | 12 +++---- src/android/camera_device.cpp | 21 ++++++------ src/android/camera_hal_manager.cpp | 2 +- src/cam/main.cpp | 4 +-- src/ipa/raspberrypi/raspberrypi.cpp | 21 ++++++------ src/libcamera/control_ids.yaml | 4 +-- src/libcamera/pipeline/ipu3/ipu3.cpp | 11 +++---- .../pipeline/raspberrypi/raspberrypi.cpp | 9 +++--- src/libcamera/property_ids.yaml | 4 +-- src/qcam/dng_writer.cpp | 22 ++++++------- utils/gen-controls.py | 32 +++++++++++++------ 12 files changed, 81 insertions(+), 68 deletions(-) --- 2.34.1