From patchwork Sat Jun 4 09:30:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 16149 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 57DB7BD161 for ; Sat, 4 Jun 2022 09:30:34 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7441C65635; Sat, 4 Jun 2022 11:30:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1654335033; bh=BrUs/DolxG8gz8hDdEvURQzA1piOrCOPic6gUiaRAJs=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=NerktYyQGXbexBYaKDDAplt2i42l2leo2wNl7/1T263Zep9r+ovVUKxwVq1SwHOom JnmH6akr4rCCzRn9+XPhFqlqbNfjMJNyebQBDcWa6tErJsDFpaGGUik9U82P3iHKP3 7y5oLHHeGwzBr+lBmG7v93IFSFCHp4011P4TgfND1tclxihpKKRL/0RlxZrp/GoygK i+i9P5rjDGNwHHdi9DfqP6CaynALILYCKlp+ZrENtxqz1RlsZJ5Evc9TdBotUktxSt +pJkUh/s6W9sOa/5u8h1mO2tpxKVKLi6DS/KicahBRknH4fNjvK7lM89CYfAP61osY FpJQvKbSLanwg== Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 957C96559A for ; Sat, 4 Jun 2022 11:30:32 +0200 (CEST) Received: (Authenticated sender: jacopo@jmondi.org) by mail.gandi.net (Postfix) with ESMTPSA id 0FF9CE0005; Sat, 4 Jun 2022 09:30:31 +0000 (UTC) To: libcamera-devel@lists.libcamera.org Date: Sat, 4 Jun 2022 11:30:20 +0200 Message-Id: <20220604093025.77737-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/5] Plumb the YUV processor in X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jacopo Mondi via libcamera-devel From: Jacopo Mondi Reply-To: Jacopo Mondi Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" v3: - Add comments as suggested by Laurent and Umang - Assert sourceStream != nullptr - Rework requestedStream handling to simplify it This change allows to include 13 more tests from the Camera CTS test. android.hardware.camera2.cts.SurfaceViewPreviewTest#testDeferredSurfaces android.hardware.cts.CameraGLTest#testSetPreviewTextureBothCallbacks android.hardware.cts.CameraGLTest#testSetPreviewTexturePreviewCallback android.hardware.cts.CameraTest#testPreviewCallback android.hardware.cts.CameraTest#testSetOneShotPreviewCallback android.hardware.cts.CameraTest#testPreviewCallbackWithBuffer android.hardware.cts.CameraTest#testFocusDistances android.hardware.cts.CameraTest#testPreviewFormats android.hardware.cts.CameraTest#testSetPreviewDisplay android.hardware.cts.CameraTest#testImmediateZoom android.hardware.cts.CameraTest#testPreviewFpsRange android.hardware.cts.CameraTest#testPreviewCallbackWithPicture android.hardware.cts.CameraTest#testPreviewPictureSizesCombination Result from running the now 244 CTS tests report 5 failures (3 straight runs out from an hard reboot with the same result) =============== Summary =============== Total Run time: 20m 3s 1/1 modules completed Total Tests : 244 PASSED : 239 FAILED : 5 ============== End of Results ============== ------------------------------------------------------------------------------- android.hardware.camera2.cts.CameraDeviceTest#testPrepare junit.framework.AssertionFailedError: Preparing surface used in previous session must throw IllegalArgumentException android.hardware.cts.CameraTest#testImmediateZoom junit.framework.AssertionFailedError android.hardware.cts.CameraTest#testLockUnlock java.lang.RuntimeException: start failed android.hardware.cts.CameraTest#testPreviewPictureSizesCombination junit.framework.AssertionFailedError: expected:<1> but was:<0> android.hardware.cts.CameraTest#testRecordingHint java.lang.RuntimeException: start failed. ------------------------------------------------------------------------------- Only 2 of them are newly enabled tests: android.hardware.cts.CameraTest#testImmediateZoom android.hardware.cts.CameraTest#testPreviewPictureSizesCombination which does not seem to fail because of failures in handling 3 streams (actual resons to be investigated). Running the current CTS plan which does not require YUV duplications results in =============== Summary =============== Total Run time: 18m 32s 1/1 modules completed Total Tests : 231 PASSED : 228 FAILED : 3 ============== End of Results ============== android.hardware.camera2.cts.CameraDeviceTest#testPrepare junit.framework.AssertionFailedError: Preparing surface used in previous session must throw IllegalArgumentException android.hardware.cts.CameraTest#testLockUnlock java.lang.RuntimeException: start failed. android.hardware.cts.CameraTest#testRecordingHint java.lang.RuntimeException: start failed. The same tests fail on current master, with some more flukes. There are no evident regression as far as I can tell. It's hard to estimate the exact number of failures as there are flukes and results are not consistent, but in the last run of CTS on plain master I got 7 and 5 failures, which is comparable to the number of failures with the series applied and the new test plan. Thanks j Hirokazu Honda (2): android: camera_stream: Add sourceStream android: camera_device: Use YUV post-processor Jacopo Mondi (3): android: camera_stream: Create allocator unconditionally android: camera_device: Postpone mapped streams handling android: camera_device: Print the correct number of completed streams src/android/camera_device.cpp | 112 ++++++++++++++++++++++++++++++---- src/android/camera_stream.cpp | 12 ++-- src/android/camera_stream.h | 6 +- 3 files changed, 110 insertions(+), 20 deletions(-) --- 2.35.1