From patchwork Fri Jun 3 22:07:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Rauch X-Patchwork-Id: 16142 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 65C32BD161 for ; Fri, 3 Jun 2022 22:07:19 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8D41365640; Sat, 4 Jun 2022 00:07:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1654294038; bh=ZNrab0D8EUOz7DZQiRZuLY2X8IHsPU6uC9+seTUIiUw=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=M5wgq1UivkIz1djCplpwfuPRhLWPL78BD+Fnas2mlOhYmE1m9iTaLniSJCEJz7X2N +CcD/ETQX/1vJkoI+U5x94LqDCB/zRWD+JI4U1OUmI2vsnmQbq3oyM1BPi1R5EyRwS Z/dedZk1cagPqwafW0VivB9gf9ThlVIiwuVFqZ1leO6CJLPwHXgFpkECQ5hcr2P19r RpqQ5mGsNqEA9whf9z6ttHoLisswimiZ33z5/GfW5a44pDo2bySuOGrw/LJ9pLrftZ Styg/DAkE3ugYnsv5ebCsraRvUJ7XvfPyFCGT4mKSSThy5U55S9Nky4KLLoujwYREI zNL9KXEn4etpA== Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1EA316040E for ; Sat, 4 Jun 2022 00:07:16 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=gmx.net header.i=@gmx.net header.b="lX6YN5Uj"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1654294035; bh=ZNrab0D8EUOz7DZQiRZuLY2X8IHsPU6uC9+seTUIiUw=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=lX6YN5UjM3aAOYVN3dm1LTAbxsqj/9oqRUl3fyUbr9MYs5/gcthlD4tE1tuaaRHCc +qTo8p/1T9lYNN+rjwASCMi48tcmU09IjJINCID/beardn6gnQZ96Teo3b1VyUlbkQ 9nKNGNzEVzW3K/X0X4rAQXL7mJznAvdY6/FUz7Ro= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.localdomain ([92.18.80.244]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M3DO3-1nwQda2Gmz-003fXN; Sat, 04 Jun 2022 00:07:15 +0200 To: libcamera-devel@lists.libcamera.org Date: Fri, 3 Jun 2022 23:07:07 +0100 Message-Id: <20220603220712.73673-1-Rauch.Christian@gmx.de> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:h5+/dGP23ckpuFYnjproleyr8QEnnB1Wz3n8gaO8AwyO91gA3Mx VsoKeH7l5LO5Ix1mX7IGbMHYkRQSQ6BIJcW02siqnIyxmwrfcjZzuss13BBCiN5AiRxvm6P OokH64Wym7MeS3TqSlUefwlEwktVxokW76X+QJA37Y0PWi6d6SK02dujEj0ek02Rql2uLAX YTYR6NFIG9jLd+n+LejQQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:alih0APUkes=:n8mjQ42q74Fij7kk7AvXou k9AyfIbVIoTRm20OpJnLBQJRvSO/lYqGzu06KCqfmYqXAhhVECKUqT1KgBw/HSEZ7vxmdLlan cShyx5Gf/+GaDJ8GMavCXW6DX+k6YKt/2v3B/LfLkskym+UKeLWrc6h3JryJWDPJU0hfPOoPP JG3T6ttN44M57Dird3V8gF/qTsIwFT033Dj5GAG1tZd1/ICLf09mtftxYfdWUrwQ3gNm2uV2k HH1Sx2hMLGWAaP8R84cNtLwbIX8kDcor5pRTB+itFVXIlGXqZKge5JXBEbCtEH0LEYYWpPJRy L7avAEUeOclGJAkutOe+tQEQSsnwng1unEAoV/0NwdNa9cNDP9wxlWK7A9jveIZkL+rkvD1CB D2I3ESNmLi4hdUs4QBxKWhOpZEK3FTgS5oglpy8z9Vz4LQzhm60ZgQcWzG9Y5XMBs+4kvZ8K8 y9tv1x+cxicnk5rdgn2GPT2kC/tFaM4SHAbfP2CF4R22jIgluiXyJqsjWtT9JwbNIDyN8ZgDS m2g0wPSOcWRwsyTjI/eoDCVqJgofMyBJrx6xd7y1Vfv9pXHdaqigG+nvdi0Y0eK1xwiPfjQeL hPtAcA6IheBr+7RqP34JqPvVQHD9omv1YwNFhqoIDBg2QHDwRGaIpXqy2E1WQhzs3vkiahG7j nbylhucWLLVkJvgrKCQ0o7lKA8rXTcC6MnfWSGOnOx/ZY3GcM5qIaWEa4DZu5V8HAQbstmC0H SfHKCUgozuSfRYGuPxonAmGt0l7cdeRT5v2O0cFmk+FVauyY5XwKVioEkSFw7Ai2P+fm7btlk ETGS7nNBxiLL0OTZO+2Yjoyr6P6+kpRIv296PWEPp3Pr/esc9rW4VEv58qt6PghQKcqlhws+4 r7ugi0wUuy4p1dkZXMQDvrIpwvZ7fLgQo++dEIRMjS9fwIdGCy2l/hQ9tAj/Y9g7k2AFWqaUx frRLe2ZvAnxHnqgpyoBmIdQTtXNrkakeXEZCn0hYluh65YFjQO1CmoL+OH2LwR4G874BKLWBo a9Cabxua6KTDha2+LmYbbZV6ty8ebOhEcqjJFJsvVC11GX/SrwPUCvXRBgDyvdmMvEYKJWoL8 svR2zWl2U7eCk8h/9hSfIr/ucvyrhwjBBX58QOICCkBajoMAB7s0r1mvw== Subject: [libcamera-devel] [PATCH v6 0/5] generate and use fixed-sized Span Control types X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christian Rauch via libcamera-devel From: Christian Rauch Reply-To: Christian Rauch Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, Thanks for all the feedback. This revision 1) fixes the "gen-controls.py" script for Python versions below 3.8 (e.g. for the Chrome OS SDK) and it 2) simplifies the optional value handling. Specifically, wherever a value was explicitly checked with "contains", I am now dereferencing the optional value directly (*prop.get()) without using "value()", which might throw an exception, and without the fallback "value_or()". I am also attaching a minor patch to fix a whitespace error that was not discovered by the checker. Best, Christian Rauch (5): libcamera: controls: Use std::optional to handle invalid control values fix whitespace for indentation (replace spaces with tab) libcamera: controls: Define size of array controls as a shape vector libcamera: controls: Generate fixed- and variable-sized Span Controls libcamera: controls: Apply explicit fixed-sized Span type casts include/libcamera/controls.h | 7 ++-- src/android/camera_capabilities.cpp | 8 ++--- src/android/camera_device.cpp | 21 ++++++------ src/android/camera_hal_manager.cpp | 2 +- src/cam/main.cpp | 4 +-- src/ipa/raspberrypi/raspberrypi.cpp | 21 ++++++------ src/libcamera/control_ids.yaml | 4 +-- src/libcamera/pipeline/ipu3/ipu3.cpp | 11 +++---- .../pipeline/raspberrypi/raspberrypi.cpp | 9 +++--- src/libcamera/property_ids.yaml | 4 +-- src/qcam/dng_writer.cpp | 15 +++++---- utils/gen-controls.py | 32 +++++++++++++------ 12 files changed, 77 insertions(+), 61 deletions(-) --- 2.34.1