From patchwork Wed Jun 1 23:17:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Rauch X-Patchwork-Id: 16126 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 3171ABD160 for ; Wed, 1 Jun 2022 23:18:19 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5F4BA65633; Thu, 2 Jun 2022 01:18:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1654125498; bh=6i72WclrdWLH9TeWspVy64s+wKqv4XYzx6v37uapdP8=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=aoePcf5x8AB8+IZ092J1bMhmYWzMaS/hPhK/tPStg9hlpefTbGUgTrSrKtL3WmJLh c9XWVwnB5CQm9kJCf0zbi9nhVWKW5l5AUrSQPw/sdYb0YePmYyMKW7qCp+wXI/Irc3 /9wEr0h2Ts4QIpgYd7/sjf7TfnfqKFdbINySLKMzFOmD4hAeBCRENaJtgfukQU7PH2 McN5vHbD7ZeR0Zp1YxdSHGtgxU+Olqb3Hc4uvMTXGFH5mFjwQOJE1cXhq/2PntUw1j e7RGBtCUr81PWTNaNgT0RDJIQLCd0j6gqUThXs57jh/vb/hkbxqQVRJ0ndejAxUbIX /aMSY3R2Kq0WQ== Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F1016040A for ; Thu, 2 Jun 2022 01:18:15 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=gmx.net header.i=@gmx.net header.b="hGK1GvoZ"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1654125495; bh=6i72WclrdWLH9TeWspVy64s+wKqv4XYzx6v37uapdP8=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=hGK1GvoZR/j7MYi4PyEAlXXAQXmD43bGuL2+32OrNKDlS52nby7/w3Bm0AvsG7+Uf 6kY/cc5gb+TBtmPtWNCQDEjuKi3sMibRj1bHfuaPTtI0Af8dbA4coX9oQWnYw+50fh OE+ba/fNnbFKhBNoiwwqSrDgDsYuF8S4OrvbFfa0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.localdomain ([92.18.80.244]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N6KUT-1nl13P3sPh-016hFp; Thu, 02 Jun 2022 01:18:15 +0200 To: libcamera-devel@lists.libcamera.org Date: Thu, 2 Jun 2022 00:17:58 +0100 Message-Id: <20220601231802.16735-1-Rauch.Christian@gmx.de> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:odL66a14HG/6Njs+X2MsLEAOQZecJHz5ppzLhFVq2BAm0xjrhvJ q7GtPpXdEcDeDcq8mS90DKGxFQWlUALhSOGys5aLkjFY9T1fvLvuvoQO+8UqSBxe6jzBZnR 7kQP1OCo0FBhSmXKQ8jgmtY+ceJ2QBEtQdPskyybd0dd49gZG+mQxkKItCQszP8g9PGkBJJ l9Pb3jPPtzTclQ4rukZpw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:8jHcHBAKPEE=:8t9Se/l7K+SQtB0pVzYzmb EsGrCKomN/uIHuFibP1Nt13dex7/Xvgwzf16Yjhb08GH0nBh1jjweM1Phynvlew/d57ffdQBT F7/wr8xS9j5q8cMJryivEXdjqtRcYmmYCPUQ/zL2YnlFcBsXVQzywsfiDncj41+gD0Oo/aS/s f0YfiIzbPzmaNgXLPwfJK62gDex20ItIbRPyzTRxfukthke+S//EMcYpRGKp6ZyI3XJuXfGji 1bTSZ2IMv8gOP8k58ROlSWsGQR4STpA3bQtZZnaYfvc4Tb7XjFiiPnW7u9LQtKekiJvHnxbGY 05DEzal1q7CCPOJPmS+DR7nLiOjOiX47tiMW+2z2SvwNpO6CxGA3f6ZZGaMiG8+LH2dd3dJsg sGE6iMBkDO1+5a6O1Ns2G4Mw18eoz1TnAD972QLyoq7XZJLV2RWZu0Hf+RS5q9NaFca7pCGTO 8LT169jgMJOxT6CPEzMwJNAbhseuYrlv7SUo0Ttflds8KIxhtZMFwDXU57GPxbXUmhFykYRSv gxLVIW+flHxWnmPmYny/AusiUEUARw1kpby8cEHWSHvIImx4M4pcZvfkNn2KhNaa+TLXCA6kt J6RgKkXQ57EX5x2d4On7ewFHtVb/7HwwP7noVKa8OVnbkch/NrcwmT/oSk/SLSd7PhJ47IHRr l/s5dLBjbNwLnJ5F25+jIX8bATJAugRWMdpZBP+Thmgep1rk41yFTgP0F1kCq84H+UoUVLyXa k91W8bv7Sj2TX+eZbQosv6Xku/ws+rl0YOHjxPTmxlIZYeIFoPxwpcDy6U/NoE4/xrjzfCk7H c01ak3LzplqIfh1fjfK7Xhz/C9oykv1Pjzt+Tyao1ls2+uRaNAURom/9B9/gqkWSMYRbIauH1 Jsb2Friwunhzx50SoRUEfrars07T9TiEnwGt+uGOzzsHeXc8rYkFb1ona3P9YEOU+SD4BZuWj Dk4OL1jOt0/rKxI9UypFKFvA7LuFLNzCzDIaHaglHhSOa4HBoM2UFMO3QxkGZp07O0gPKrf15 AK+w5AEEK95wOTVNYuG7Wmsx4m4COOYZMH6yCq+2lyY6f1158h7is1qxmFPf7r7b/PoIF7owe KXsKzzondveuPUonz7V7hipHAshlwKHsgRfDyBpnlQ10djL173/sF65fA== Subject: [libcamera-devel] [PATCH v5 0/4] generate and use fixed-sized Span Control types X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christian Rauch via libcamera-devel From: Christian Rauch Reply-To: Christian Rauch Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, This is the rebased version of my patch set with minor modifications for an additional control value that was added in the meantime. I additionally prefixed and capitalised the commit messages to follow the estalished commit style. The last remaining concern was about the use of "std::optional". This has been resolved now by accepting std::optional in the public API. Best, Christian Rauch (4): libcamera: controls: Use std::optional to handle invalid control values libcamera: controls: Define size of array controls as a shape vector libcamera: controls: Generate fixed- and variable-sized Span Controls libcamera: controls: Apply explicit fixed-sized Span type casts include/libcamera/controls.h | 7 ++-- src/cam/main.cpp | 4 +-- src/ipa/raspberrypi/raspberrypi.cpp | 21 ++++++------ src/libcamera/control_ids.yaml | 4 +-- src/libcamera/pipeline/ipu3/ipu3.cpp | 9 +++--- .../pipeline/raspberrypi/raspberrypi.cpp | 10 +++--- src/libcamera/property_ids.yaml | 4 +-- src/qcam/dng_writer.cpp | 15 +++++---- utils/gen-controls.py | 32 +++++++++++++------ 9 files changed, 62 insertions(+), 44 deletions(-) --- 2.34.1