From patchwork Wed Apr 20 16:26:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 15688 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id ADA4CC0F1B for ; Wed, 20 Apr 2022 16:26:45 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E333A65645; Wed, 20 Apr 2022 18:26:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1650472004; bh=AYJSuQwbIPWcmsC/l6nZepyOABPpQeqfmAHq6LRbW30=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=3EVQVfnZ4qJezIJLt0S2CUQ9B4T6Md1RnhCU5G36faYWfMCD4QYsvoOLwJck8UfQ2 WizrlBdtcMKoPiGtH15MKsqZfl3ZKXlM4ew03gEv3ROef7KlU6HXjGHpVIotkEWhjo YlLMF/bSDYPmAUqr4k+K8wotmSqC7m0S7ByJmltNRkeXkSKQWDtRAixkmYwiG4s8EU PJFSsybj4l7P2rEnrKlj4kY7HFje4WAS9fYJsW0CP9OlCC5XR7Wm4ieHIla5dYmqsG VYkQTOUyI54re1Wth1GsXozypDCo5ZEuZ8AnXZpm+rNis0/UaqGZmPwiRGIFjWSDfm P784bs4ec3g5Q== Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 52FF1604AB for ; Wed, 20 Apr 2022 18:26:43 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="TBCd0nph"; dkim-atps=neutral Received: by mail-wr1-x42a.google.com with SMTP id bv16so2975718wrb.9 for ; Wed, 20 Apr 2022 09:26:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QxQXue6UkuG7HbOlX//yWVAT5uci9n0oEFEdSOdq0D4=; b=TBCd0nphaRJ2C55VH1JYp7IsE130LGSmG3Y+FZyZiSUfP7xWFDauwO/A1AQn094TUf bY015ymJuFsJ9Ausn5Fa6sfBncMaumbHBmb2tlKObZEzAf+Hs+pSyBmo1IfyU9xdvie5 yzUHWWoKEwrwQoXMdX/Ppg8S+FQl8zmR25M8cER2MG5sIjG5xAIKbeHt8aRneS+tyYec YX8hiQ/zMNPzvGvhHnh04inNhcOZahGLiy3tv2T6bn3vEhcmHx9Z9cqBjtBd3k0A01LV EJUThhsgMzWhUunSxi6iUmzPns4yKTkg35YdK9zUd9jJ4LcJirGqLYDUDqkFV+AfytWs 1D7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QxQXue6UkuG7HbOlX//yWVAT5uci9n0oEFEdSOdq0D4=; b=BJFDPRNYiKJeigwZeQ+IwCJRoMFgepbHdmWyZ6nxC4NDf9n84B++xZOUiM/xiWRxxX bvljfEtTP4TTuYkLZBe76yOxt36Chgw03sh0ec0oBTB3N9onBKMxn+lOEzTLgnhq6ZVy FHIp/2N1hHI91oSvzCoeQfP8G4566cAp+8WsGGWdXJemULmDrneHYSrL5u4wKbZjfybU XwJiDEhpW4C6lPbWC+fp/i5vjdUT0uzyCwlG3KkLSbaViPyN2DBQV7Zuast62F0zN1cD 2BGqoHtdV6JQLe5mH/lbXURlT+qByNVpKGo8eqxNNe/GK3FTeIIHWFfMsPhrt3CVuNFi AT5A== X-Gm-Message-State: AOAM530AVU1cNtI714+wTBgELerCgY3TtECUnkCKVl86UD+Ydmp0LJH9 qJAsFAWLGEMNRISfXz6q5MtXMuepMD6cj7s7 X-Google-Smtp-Source: ABdhPJzGEDKepbC70AZQ37Z1gx1aPBPYRxdAsrAJFLPpEvKkimsBip9W8ooIzcVOtE6Igu7FwEZ4DA== X-Received: by 2002:a5d:5705:0:b0:207:a299:27e2 with SMTP id a5-20020a5d5705000000b00207a29927e2mr16094259wrv.59.1650472002524; Wed, 20 Apr 2022 09:26:42 -0700 (PDT) Received: from pi4-davidp.pitowers.org ([2a00:1098:3142:14:e4a2:3070:eea4:e434]) by smtp.gmail.com with ESMTPSA id c12-20020a05600c0a4c00b00381141f4967sm298910wmq.35.2022.04.20.09.26.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 09:26:42 -0700 (PDT) To: libcamera-devel@lists.libcamera.org, Jean-Michel Hautbois , Han-Lin Chen , Kate Hsuan , Jacopo Mondi Date: Wed, 20 Apr 2022 17:26:21 +0100 Message-Id: <20220420162622.16521-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/1] AF controls X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Plowman via libcamera-devel From: David Plowman Reply-To: David Plowman Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi everyone Changes in v3: * The controls have all been "un-draft-ified". I've moved them all up the file to the non-draft section. * We had a discussion about having a "custom" range, but I think the conclusion for the moment was not to add it. Please correct me if I'm wrong there. * The AfLensPosition control has gone. Instead LensPosition is defined to use a scaled "dioptre-like" kind of unit (hyperfocal distance divided by focal distance), so that 0 = infinity, 1 = hyperfocal, bigger numbers = closer. * The AfState has been reduced to just reset/scanning/focused/failed. It is expected that AfMode will be reported on every frame, and also the new AfPauseState which says whether CAF is running/pausing/paused. * I note that there's still some discussion elsewhere about the units for defining AF regions, and whether they need to have associated weights. * I haven't carried any tags over for now, I think things are still at a stage where everyone needs to review the changes, if that's OK! The state transition diagram is cosmetically updated, but not materially different. It should be in the same place, but in case you've lost the link: https://docs.google.com/drawings/d/1rU2nS82dEC8Y2eY0lKPkQQhd67gKLOl7PvSeUcL1j_E/edit?usp=sharing Thanks! David David Plowman (1): libcamera: controls: Controls for driving AF (autofocus) algorithms src/libcamera/control_ids.yaml | 318 ++++++++++++++++++++++++++------- 1 file changed, 258 insertions(+), 60 deletions(-)