From patchwork Tue Apr 5 00:42:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Rauch X-Patchwork-Id: 15614 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 413C3C0F1B for ; Tue, 5 Apr 2022 00:42:25 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7E72A65645; Tue, 5 Apr 2022 02:42:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1649119344; bh=L58yo0hqb9MxxO6U5FmSo9OCZT4aycyVKaMayn82rbs=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Rt7xIRQEVL66OqX8+5lbRGyhvkMyaplqxxlvi0CVxFlhPuzHM3OEe+r488cnIVZDW rMuxT6ctI+RjXhpo4cO30lOdmXnbvKF3pYtVgfW8YSB1cYW25v5vQj/XFstra0KpqA 0ETqy1W0Wr9t7jf3TUGjFuVo4U1YaPhYQ2icbtWHNN9ewEWmj2fpO/kLy3OIbZH+mE 6NaXr8LS5m8wAWLZjGDaMZauNje6EmxwrH0L6nNAe8BZ2GArH9p3LT+PuGLnCCqGxs WNa4/155zsrqBnnij4JLsp/gpLYWBnXLEBycfxwVMzDXGMozxgLkAXZWL3WdbCCxT7 8qKmjDRSzscsw== Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5CAC360397 for ; Tue, 5 Apr 2022 02:42:22 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=gmx.net header.i=@gmx.net header.b="Uswpe0Ao"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1649119342; bh=L58yo0hqb9MxxO6U5FmSo9OCZT4aycyVKaMayn82rbs=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=Uswpe0AoAjfK3KCT6pQuQOY7r4UMBslSJHLv74ypyfNT6F5+SMivzUNkAGO6y/FRK aLtZQ4kqKHzF4uCFWSO0S+ZLwK+wkrBg7D6pzZD2iJUyGruJG3lko9nAslj8EMdoUN O7lxoM+jrTWxaKDIlpSIoV14jZL7W+GoIsRv44Bw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.localdomain ([92.10.251.63]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MdvmY-1oB9XX3Yjm-00b1UD; Tue, 05 Apr 2022 02:42:21 +0200 To: libcamera-devel@lists.libcamera.org Date: Tue, 5 Apr 2022 01:42:10 +0100 Message-Id: <20220405004215.86340-1-Rauch.Christian@gmx.de> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:WV6CZKAUy8HjpdWaG1ZEaXU14ECyFH2K7YI7EhR+Qa8eVZROPDM Zs4bvVTF5FAb86CfnyEC1GrRLsKLKB3oy1JE8DA9K9XuUANSEoZF/CEa+YlP/RQbtPceD+V wDgtuiaXW6xmeYTID6uI4b8TCFFAQI8I/W7jyZ3wY37NBhxF0T3w/Equ6/rnWNCfS9Yojlg GVw5eVGWgRjPNrfi5GH+A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:2p5p7ZkGPL4=:YwEQEHhzb4/4B8gLLFahl8 Sod0DrBpRFJgG72Fl/1Xw7ex9f3cH9BCr4MnvYOssssekmi1CRoA1nvLU7IzyxdMdM/a0E4W1 Meq+zB32V+BvAIzOljkUcOTKtVB6Nt3BmnvHt5HunbntK7Y3dPL6PBNWW+r810jJwPJ3PtSAu 5/4yNU4msqJcOonBDUl13hAkea9OP7N0qtwhdrhKzdmSsp58zhy31cjfsNp1KT52b8Ap/iQ4N Fw0PLI9JrcTXKEmzq3Re8UiSVpRK1VBh2pGTFyPxbEGHpXMkBY+UOxjrj74RrAlzep2Nfnvuy MF1sPmutlISOJFJBuZ8R6+38qbqpABGwbLyowWrUHRn6kaqJv3963/PlItabhVk1nUPWWvr6w jIYLldnQGFYVb4SzK5Qwq93Bn1ipt1JblroCUQRyorJT7TfZoj4vW7WYDBJSr06dcTZeYTqgv Aohn+W/Zo7fon5gXpwmZvxkOZcupxCBz+FYwCirPULZYEFznaKKI5suFjtObG/DzW0uEGsmN0 d98Jde5vJDz0JGZVpcQdhSMXe/HOqyVSxrc4lNLKAiEZMJV8j6tBCMZRFwDT8jcL+k3cq9/Bg foXF95OUBNVXE22cQH2J9/OANTJO4vv9xl57njjSp6cJ+qNpKskaanupvHaJkSy7Oj9GllPPF SDQ6EAW6XXVBG3/qRdl5O2hF4EIcG8dpTfZRkaz1Rq4qAyIdctcNwkkKNgqeqhln5JuizSeDu ULDPe67DAipWwp0YY/fzSghVoNcHWXodACmRq0617xkhvk+n8llOM7YMLrSB9DmFd3xoOiWcO Q0e+WQiLoPhMIFLPUEOgKUWUvvZivoXd24UFr0GtewNDJgX79nsXuqMTc5/aiM66hP7ApQuF0 yjRO9Lq5o+O828pHjJbltP7cxaLCZ3zFBA/v2NgqG/hhIcgu1WupGIDOeOIyEAU4HHEzXyM4S 5DaIxQWE12ibYunYQhlLPgrbCw2FP7ZkGvYYjun3Rejj/l05s/2p+G74HoFq1N6VH2agLHyu6 f/ZWCcg68sanpKgCsJowjhUVVla1aLmOJCrIjCQX/LwuJWOTg8e0JQDspLPpxcP7f6p6njXP+ V6HMbiVqGu56aE= Subject: [libcamera-devel] [PATCH v2 0/5] generate and use fixed-sized Span Control types X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christian Rauch via libcamera-devel From: Christian Rauch Reply-To: Christian Rauch Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, This is version 2 of my fixed-sized Span patch set. The changes from version 1 include changes to the code style in "gen-controls.py" and the way how memory for default constructed fixed-sized Spans is allocated. The default Span constructor in version 1 used a temporarily constructed "std::array<>" resulting in the Span storing a pointer to deallocated memory. Version 2 replaced this with an empty Span. In practice, this means that a Span will store its target fixed-size as the "extent" and its current storage capacity by "size_". Best, Christian Christian Rauch (5): define Span size as shape vector generate fixed- and variable-sized Span Controls provide a default fixed-sized Span constructor apply clang-format style apply explicit fixed-sized Span type casts include/libcamera/base/span.h | 47 +++--- include/libcamera/controls.h | 2 +- src/ipa/raspberrypi/raspberrypi.cpp | 21 +-- src/libcamera/control_ids.yaml | 2 +- .../pipeline/raspberrypi/raspberrypi.cpp | 36 +++-- src/libcamera/property_ids.yaml | 4 +- src/qcam/dng_writer.cpp | 142 +++++++++--------- test/span.cpp | 4 +- utils/gen-controls.py | 33 ++-- 9 files changed, 154 insertions(+), 137 deletions(-) --- 2.25.1