From patchwork Wed Mar 23 13:56:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 15518 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id EEAFCC0F1B for ; Wed, 23 Mar 2022 13:56:22 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D4232604C4; Wed, 23 Mar 2022 14:56:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1648043782; bh=VLSr1QD0oeV7CD0kyPRKGHVJ2O8+OVqBkXqGvUce93M=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=VZHDEn7y+lpcKb+eQxsJSs1dEeth1U8RdJC9IXEdgKBBhnk5hg0+MeT5Kn1/i8i+K /icHkqeBWAr9+NsabJv3SjlD1JGZR0Du0uV663Yeq7DzjBcDS2qCcyx8KgJ/bCaUsd YSQPwQBdDzNVQ0VHZNSO+Ssr5o501NAApp8VQ0dmokU9hdbxQ8/pRj9QYWbistsB+m aPDX4YiJib9n/gOFTzV5ObMkvIBpg4SnAiFNQRFfbTDD+v0KJpftqlwNGHNmnU3vMT pdVxJZQ9FyS0fjQYMqfUB9En2RaXU8YbR1SiU0BCptcMWDRcDT/T/F5T4QdzWDWd/m H0eDa5vObjegw== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 930FA604C4 for ; Wed, 23 Mar 2022 14:56:20 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="rdnhKqkd"; dkim-atps=neutral Received: from Monstersaurus.ksquared.org.uk.beta.tailscale.net (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 219D69DE; Wed, 23 Mar 2022 14:56:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1648043780; bh=VLSr1QD0oeV7CD0kyPRKGHVJ2O8+OVqBkXqGvUce93M=; h=From:To:Cc:Subject:Date:From; b=rdnhKqkdR9o5X6FOsnJke8dp7tgcUnoFFXC/6cQBB0hBA6GX+0ct91T4AowV2pd/q pHebP+ZBlCLfEJAwOQPOfgXzPo4FWIQ2GoTd2zj+7d9mzDtu610Mi2tfNd42ksGA4L d3d6sK2trY92nRdij+3B8GnxoEZkU2IJ59I5XAm8= To: libcamera devel Date: Wed, 23 Mar 2022 13:56:09 +0000 Message-Id: <20220323135614.865252-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/5] ipa: ipu3: af: Small improvements X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Kieran Bingham via libcamera-devel From: Kieran Bingham Reply-To: Kieran Bingham Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Following review of the IPU3 Af implementation, the following additional improvements were identified. No functional change to the running of the algorithm is intended or expected, though this does remove a memcpy, and adapts to use a Span for range based iterators, as well as hopefully make it easier to use custom ROI's and return the AF regions in later developments. *** This is only compile tested! *** Kieran Bingham (5): ipa: ipu3: af: Move constants to implementation ipa: ipu3: af: Use geometry classes to perform grid centering ipa: ipu3: af: Remove redundant memcpy ipa: ipu3: af: Use Span for y_table_item_t ipa: ipu3: af: Simplify accumulations of y_items src/ipa/ipu3/algorithms/af.cpp | 141 +++++++++++++-------------------- src/ipa/ipu3/algorithms/af.h | 15 +--- 2 files changed, 57 insertions(+), 99 deletions(-)